From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Harsha Sharma <harshasharmaiitr@gmail.com>
Cc: devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Change foo* bar to foo *bar
Date: Sat, 09 Sep 2017 15:10:31 -0700 [thread overview]
Message-ID: <1504995031.26889.0.camel@perches.com> (raw)
In-Reply-To: <20170909165056.GA6145@kroah.com>
On Sat, 2017-09-09 at 18:50 +0200, Greg KH wrote:
> On Sat, Sep 09, 2017 at 10:09:37PM +0530, Harsha Sharma wrote:
> > This coding style (foo *bar) is more common for the kernel code.
>
> You also did something else in this patch that you did not mention here,
> which is not ok :(
what is that?
> Remember, only one type of thing per patch.
Seemed like only one thing to me.
prev parent reply other threads:[~2017-09-09 22:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-09 16:39 [PATCH] staging: rtl8723bs: Change foo* bar to foo *bar Harsha Sharma
2017-09-09 16:50 ` Greg KH
2017-09-09 22:10 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504995031.26889.0.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=harshasharmaiitr@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.