All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Harsha Sharma <harshasharmaiitr@gmail.com>
Cc: devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Change foo* bar to foo *bar
Date: Sat, 9 Sep 2017 18:50:56 +0200	[thread overview]
Message-ID: <20170909165056.GA6145@kroah.com> (raw)
In-Reply-To: <1504975177-11843-1-git-send-email-harshasharmaiitr@gmail.com>

On Sat, Sep 09, 2017 at 10:09:37PM +0530, Harsha Sharma wrote:
> This coding style (foo *bar) is more common for the kernel code.

You also did something else in this patch that you did not mention here,
which is not ok :(

Remember, only one type of thing per patch.

thanks,

greg k-h


  reply	other threads:[~2017-09-09 16:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-09 16:39 [PATCH] staging: rtl8723bs: Change foo* bar to foo *bar Harsha Sharma
2017-09-09 16:50 ` Greg KH [this message]
2017-09-09 22:10   ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170909165056.GA6145@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=harshasharmaiitr@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.