From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: Problems after recent changes to meson-gx-mmc driver
Date: Sun, 10 Sep 2017 17:08:25 +0200 [thread overview]
Message-ID: <1505056105.24771.53.camel@baylibre.com> (raw)
In-Reply-To: <6a4baa6c-e5f0-fe51-f958-adde9e39b4c9@gmail.com>
On Sat, 2017-09-09 at 22:20 +0200, Heiner Kallweit wrote:
> I checked further and setting the tx clock phase back to 0 fixes the issue for
> me.
> ("mmc: meson-gx: change default tx phase" changes it from 0 to 270.)
> But as you write 0 seems to break certain other systems.
That was my second guess ...
As I mentioned in the commit message, 270 is working fine for the setups I have
tested but I always wondered if that would be the case for every possible
setups/boards/modes.
Would you mind testing 90 and 180 as well with your setup ? I'll make another
pass on the different setups I have access to. Please stick to hs200 and drop
hs400 for this test. I'm still unsure if doubling the clock after doing the
tuning may affect the phase tuning ... lets keep that out of the way for now.
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet@baylibre.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
linux-amlogic@lists.infradead.org
Subject: Re: Problems after recent changes to meson-gx-mmc driver
Date: Sun, 10 Sep 2017 17:08:25 +0200 [thread overview]
Message-ID: <1505056105.24771.53.camel@baylibre.com> (raw)
In-Reply-To: <6a4baa6c-e5f0-fe51-f958-adde9e39b4c9@gmail.com>
On Sat, 2017-09-09 at 22:20 +0200, Heiner Kallweit wrote:
> I checked further and setting the tx clock phase back to 0 fixes the issue for
> me.
> ("mmc: meson-gx: change default tx phase" changes it from 0 to 270.)
> But as you write 0 seems to break certain other systems.
That was my second guess ...
As I mentioned in the commit message, 270 is working fine for the setups I have
tested but I always wondered if that would be the case for every possible
setups/boards/modes.
Would you mind testing 90 and 180 as well with your setup ? I'll make another
pass on the different setups I have access to. Please stick to hs200 and drop
hs400 for this test. I'm still unsure if doubling the clock after doing the
tuning may affect the phase tuning ... lets keep that out of the way for now.
next prev parent reply other threads:[~2017-09-10 15:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-09 13:14 Problems after recent changes to meson-gx-mmc driver Heiner Kallweit
2017-09-09 13:14 ` Heiner Kallweit
2017-09-09 14:05 ` Jerome Brunet
2017-09-09 14:05 ` Jerome Brunet
2017-09-09 19:53 ` Heiner Kallweit
2017-09-09 19:53 ` Heiner Kallweit
2017-09-09 20:20 ` Heiner Kallweit
2017-09-09 20:20 ` Heiner Kallweit
2017-09-10 15:08 ` Jerome Brunet [this message]
2017-09-10 15:08 ` Jerome Brunet
2017-09-10 16:20 ` Heiner Kallweit
2017-09-10 16:20 ` Heiner Kallweit
2017-09-10 16:48 ` Jerome Brunet
2017-09-10 16:48 ` Jerome Brunet
2017-09-18 13:44 ` [PATCH/RFT] mmc: meson-gx: include tx phase in the tuning process Jerome Brunet
2017-09-18 13:44 ` Jerome Brunet
2017-09-18 19:11 ` Heiner Kallweit
2017-09-18 19:11 ` Heiner Kallweit
2017-09-19 11:08 ` Jerome Brunet
2017-09-19 11:08 ` Jerome Brunet
2017-09-19 18:54 ` Heiner Kallweit
2017-09-19 18:54 ` Heiner Kallweit
2017-09-27 16:24 ` Jerome Brunet
2017-09-27 16:24 ` Jerome Brunet
2017-10-02 12:30 ` Jerome Brunet
2017-10-02 12:30 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505056105.24771.53.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.