[PATCH 3/5] mm:swap: introduce SWP_SYNCHRONOUS_IO

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kernel-team <kernel-team@lge.com>,
	Minchan Kim <minchan@kernel.org>,
	Ilya Dryomov <idryomov@gmail.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: [PATCH 3/5] mm:swap: introduce SWP_SYNCHRONOUS_IO
Date: Tue, 12 Sep 2017 11:37:11 +0900	[thread overview]
Message-ID: <1505183833-4739-3-git-send-email-minchan@kernel.org> (raw)
In-Reply-To: <1505183833-4739-1-git-send-email-minchan@kernel.org>

If rw-page based fast storage is used for swap devices, we need to
detect it to enhance swap IO operations.
This patch is preparation for optimizing of swap-in operation with
next patch.

Signed-off-by: Minchan Kim <minchan@kernel.org>
---
 include/linux/swap.h | 3 ++-
 mm/swapfile.c        | 3 +++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/include/linux/swap.h b/include/linux/swap.h
index 8a807292037f..0f54b491e118 100644
--- a/include/linux/swap.h
+++ b/include/linux/swap.h
@@ -170,8 +170,9 @@ enum {
 	SWP_AREA_DISCARD = (1 << 8),	/* single-time swap area discards */
 	SWP_PAGE_DISCARD = (1 << 9),	/* freed swap page-cluster discards */
 	SWP_STABLE_WRITES = (1 << 10),	/* no overwrite PG_writeback pages */
+	SWP_SYNCHRONOUS_IO = (1<<11),	/* synchronous IO is efficient */
 					/* add others here before... */
-	SWP_SCANNING	= (1 << 11),	/* refcount in scan_swap_map */
+	SWP_SCANNING	= (1 << 12),	/* refcount in scan_swap_map */
 };
 
 #define SWAP_CLUSTER_MAX 32UL
diff --git a/mm/swapfile.c b/mm/swapfile.c
index bf91dc9e7a79..1305591cde4d 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -3168,6 +3168,9 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
 	if (bdi_cap_stable_pages_required(inode_to_bdi(inode)))
 		p->flags |= SWP_STABLE_WRITES;
 
+	if (bdi_cap_synchronous_io(inode_to_bdi(inode)))
+		p->flags |= SWP_SYNCHRONOUS_IO;
+
 	if (p->bdev && blk_queue_nonrot(bdev_get_queue(p->bdev))) {
 		int cpu;
 		unsigned long ci, nr_cluster;
-- 
2.7.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)

From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kernel-team <kernel-team@lge.com>,
	Minchan Kim <minchan@kernel.org>,
	Ilya Dryomov <idryomov@gmail.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: [PATCH 3/5] mm:swap: introduce SWP_SYNCHRONOUS_IO
Date: Tue, 12 Sep 2017 11:37:11 +0900	[thread overview]
Message-ID: <1505183833-4739-3-git-send-email-minchan@kernel.org> (raw)
In-Reply-To: <1505183833-4739-1-git-send-email-minchan@kernel.org>

If rw-page based fast storage is used for swap devices, we need to
detect it to enhance swap IO operations.
This patch is preparation for optimizing of swap-in operation with
next patch.

Signed-off-by: Minchan Kim <minchan@kernel.org>
---
 include/linux/swap.h | 3 ++-
 mm/swapfile.c        | 3 +++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/include/linux/swap.h b/include/linux/swap.h
index 8a807292037f..0f54b491e118 100644
--- a/include/linux/swap.h
+++ b/include/linux/swap.h
@@ -170,8 +170,9 @@ enum {
 	SWP_AREA_DISCARD = (1 << 8),	/* single-time swap area discards */
 	SWP_PAGE_DISCARD = (1 << 9),	/* freed swap page-cluster discards */
 	SWP_STABLE_WRITES = (1 << 10),	/* no overwrite PG_writeback pages */
+	SWP_SYNCHRONOUS_IO = (1<<11),	/* synchronous IO is efficient */
 					/* add others here before... */
-	SWP_SCANNING	= (1 << 11),	/* refcount in scan_swap_map */
+	SWP_SCANNING	= (1 << 12),	/* refcount in scan_swap_map */
 };
 
 #define SWAP_CLUSTER_MAX 32UL
diff --git a/mm/swapfile.c b/mm/swapfile.c
index bf91dc9e7a79..1305591cde4d 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -3168,6 +3168,9 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
 	if (bdi_cap_stable_pages_required(inode_to_bdi(inode)))
 		p->flags |= SWP_STABLE_WRITES;
 
+	if (bdi_cap_synchronous_io(inode_to_bdi(inode)))
+		p->flags |= SWP_SYNCHRONOUS_IO;
+
 	if (p->bdev && blk_queue_nonrot(bdev_get_queue(p->bdev))) {
 		int cpu;
 		unsigned long ci, nr_cluster;
-- 
2.7.4

next prev parent reply	other threads:[~2017-09-12  2:37 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-12  2:37 [PATCH 1/5] zram: set BDI_CAP_STABLE_WRITES once Minchan Kim
2017-09-12  2:37 ` Minchan Kim
2017-09-12  2:37 ` [PATCH 2/5] bdi: introduce BDI_CAP_SYNCHRONOUS_IO Minchan Kim
2017-09-12  2:37   ` Minchan Kim
2017-09-12  2:37 ` Minchan Kim [this message]
2017-09-12  2:37   ` [PATCH 3/5] mm:swap: introduce SWP_SYNCHRONOUS_IO Minchan Kim
2017-09-12  4:48   ` Sergey Senozhatsky
2017-09-12  4:48     ` Sergey Senozhatsky
2017-09-12  2:37 ` [PATCH 4/5] mm:swap: respect page_cluster for readahead Minchan Kim
2017-09-12  2:37   ` Minchan Kim
2017-09-12  5:23   ` Huang, Ying
2017-09-12  5:23     ` Huang, Ying
2017-09-12  6:25     ` Minchan Kim
2017-09-12  6:25       ` Minchan Kim
2017-09-12  6:44       ` Huang, Ying
2017-09-12  6:44         ` Huang, Ying
2017-09-12  6:52         ` Minchan Kim
2017-09-12  6:52           ` Minchan Kim
2017-09-12  7:29           ` Huang, Ying
2017-09-12  7:29             ` Huang, Ying
2017-09-12  7:56             ` Minchan Kim
2017-09-12  7:56               ` Minchan Kim
2017-09-12  8:07               ` Huang, Ying
2017-09-12  8:07                 ` Huang, Ying
2017-09-12  8:22                 ` Minchan Kim
2017-09-12  8:22                   ` Minchan Kim
2017-09-12  8:32                   ` Huang, Ying
2017-09-12  8:32                     ` Huang, Ying
2017-09-12 23:34                     ` Minchan Kim
2017-09-12 23:34                       ` Minchan Kim
2017-09-13  0:55                       ` Huang, Ying
2017-09-13  0:55                         ` Huang, Ying
2017-09-12  2:37 ` [PATCH 5/5] mm:swap: skip swapcache for swapin of synchronous device Minchan Kim
2017-09-12  2:37   ` Minchan Kim
2017-09-12  6:04   ` Sergey Senozhatsky
2017-09-12  6:04     ` Sergey Senozhatsky
2017-09-12  6:31     ` Minchan Kim
2017-09-12  6:31       ` Minchan Kim
2017-09-12 20:22   ` kbuild test robot
2017-09-12 20:22     ` kbuild test robot
2017-09-13  0:16     ` Minchan Kim
2017-09-13  0:16       ` Minchan Kim

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:8a807292037 dfblob:0f54b491e11 dfblob:bf91dc9e7a7
dfblob:1305591cde4 dfblob:8a807292037 dfblob:0f54b491e11
dfblob:bf91dc9e7a7 dfblob:1305591cde4 )
 OR (
bs:"[PATCH 3/5] mm:swap: introduce SWP_SYNCHRONOUS_IO" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505183833-4739-3-git-send-email-minchan@kernel.org \
    --to=minchan@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=idryomov@gmail.com \
    --cc=kernel-team@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.