From: "Longchamp, Valentin" <Valentin.Longchamp@keymile.com>
To: "christophe.leroy@c-s.fr" <christophe.leroy@c-s.fr>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"leoli@freescale.com" <leoli@freescale.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] net/ethernet/freescale: fix warning for ucc_geth
Date: Thu, 14 Sep 2017 14:17:42 +0000 [thread overview]
Message-ID: <1505398677.19702.6.camel@keymile.com> (raw)
In-Reply-To: <f5c5c526-99d4-ff3d-1e2a-23d71bcafa4b@c-s.fr>
SGkgQ2hyaXN0b3BoZSwNCg0KT24gVGh1LCAyMDE3LTA5LTE0IGF0IDE1OjI0ICswMjAwLCBDaHJp
c3RvcGhlIExFUk9ZIHdyb3RlOg0KPiBIaSwNCj4gDQo+IExlIDE0LzA5LzIwMTcgw6AgMTQ6MDUs
IFZhbGVudGluIExvbmdjaGFtcCBhIMOpY3JpdCA6DQo+ID4gU2ltcGxlIHByaW50ayBmb3JtYXQg
d2FybmluZyBmb3IgdGhlIHRoZSB1Y2MgcmVnaXN0ZXJzIGFkZHJlc3MuDQo+IA0KPiBEaWQgeW91
IHRlc3QgeW91ciBwYXRjaCB3aXRoIG1wYzgzeHhfZGVmY29uZmlnID8NCg0KTm8gSSBvbmx5IHRl
c3RlZCBvbiBhIDg1eHggd2hlcmUgSSBoYWQgYW5vdGhlciAoc2ltaWxhciwgYmVjYXVzZSB0aGUN
CnBoeXNpY2FsIGFkZHJlc3NlcyBhcmUgdTY0IGFuZCBub3QgdTMyKSB3YXJuaW5nLg0KDQpNeSBx
dWljayBmaXggaW5kZWVkIGRpZCBub3QgdGFrZSB0aGUgZGlmZmVyZW50IHR5cGVkZWZzIGZvcg0K
cGh5c19hZGRyX3QuDQoNCkkgdHJ5IHRvIGNvbWUgd2l0aCBhIHYyIHRoYXQgY292ZXJzIHRoaXMu
DQoNClRoYW5rcyBmb3IgdGhlIGZlZWRiYWNrLg0KDQpWYWxlbnRpbg0KPiANCj4gSSBnZXQgYSBu
ZXcgd2FybmluZyB3aXRoIHlvdXIgcGF0Y2g6DQo+IA0KPiAgICBDQyAgICAgIGRyaXZlcnMvbmV0
L2V0aGVybmV0L2ZyZWVzY2FsZS91Y2NfZ2V0aC5vDQo+IEluIGZpbGUgaW5jbHVkZWQgZnJvbSAu
L2luY2x1ZGUvbGludXgvcHJpbnRrLmg6NjowLA0KPiAgICAgICAgICAgICAgICAgICBmcm9tIC4v
aW5jbHVkZS9saW51eC9rZXJuZWwuaDoxMywNCj4gICAgICAgICAgICAgICAgICAgZnJvbSBkcml2
ZXJzL25ldC9ldGhlcm5ldC9mcmVlc2NhbGUvdWNjX2dldGguYzoxODoNCj4gZHJpdmVycy9uZXQv
ZXRoZXJuZXQvZnJlZXNjYWxlL3VjY19nZXRoLmM6IEluIGZ1bmN0aW9uDQo+IOKAmHVjY19nZXRo
X3Byb2Jl4oCZOg0KPiAuL2luY2x1ZGUvbGludXgva2Vybl9sZXZlbHMuaDo0OjE4OiB3YXJuaW5n
OiBmb3JtYXQg4oCYJWxseOKAmSBleHBlY3RzIA0KPiBhcmd1bWVudCBvZiB0eXBlIOKAmGxvbmcg
bG9uZyB1bnNpZ25lZCBpbnTigJksIGJ1dCBhcmd1bWVudCAzIGhhcyB0eXBlIA0KPiDigJhyZXNv
dXJjZV9zaXplX3Qge2FrYSB1bnNpZ25lZCBpbnR94oCZIFstV2Zvcm1hdD1dDQo+ICAgI2RlZmlu
ZSBLRVJOX1NPSCAiXDAwMSIgIC8qIEFTQ0lJIFN0YXJ0IE9mIEhlYWRlciAqLw0KPiAgICAgICAg
ICAgICAgICAgICAgXg0KPiAuL2luY2x1ZGUvbGludXgva2Vybl9sZXZlbHMuaDoxMzoxOTogbm90
ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvDQo+IOKAmEtFUk5fU09I4oCZDQo+ICAgI2RlZmluZSBL
RVJOX0lORk8gS0VSTl9TT0ggIjYiIC8qIGluZm9ybWF0aW9uYWwgKi8NCj4gICAgICAgICAgICAg
ICAgICAgICBeDQo+IC4vaW5jbHVkZS9saW51eC9wcmludGsuaDozMDg6OTogbm90ZTogaW4gZXhw
YW5zaW9uIG9mIG1hY3JvDQo+IOKAmEtFUk5fSU5GT+KAmQ0KPiAgICBwcmludGsoS0VSTl9JTkZP
IHByX2ZtdChmbXQpLCAjI19fVkFfQVJHU19fKQ0KPiAgICAgICAgICAgXg0KPiBkcml2ZXJzL25l
dC9ldGhlcm5ldC9mcmVlc2NhbGUvdWNjX2dldGguYzozODYwOjM6IG5vdGU6IGluIGV4cGFuc2lv
bg0KPiBvZiANCj4gbWFjcm8g4oCYcHJfaW5mb+KAmQ0KPiAgICAgcHJfaW5mbygiVUNDJTFkIGF0
IDB4JThsbHggKGlycSA9ICVkKVxuIiwNCj4gICAgIF4NCj4gDQo+IENocmlzdG9waGUNCj4gDQo+
ID4gDQo+ID4gU2lnbmVkLW9mZi1ieTogVmFsZW50aW4gTG9uZ2NoYW1wIDx2YWxlbnRpbi5sb25n
Y2hhbXBAa2V5bWlsZS5jb20+DQo+ID4gLS0tDQo+ID4gICBkcml2ZXJzL25ldC9ldGhlcm5ldC9m
cmVlc2NhbGUvdWNjX2dldGguYyB8IDIgKy0NCj4gPiAgIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2Vy
dGlvbigrKSwgMSBkZWxldGlvbigtKQ0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25l
dC9ldGhlcm5ldC9mcmVlc2NhbGUvdWNjX2dldGguYw0KPiA+IGIvZHJpdmVycy9uZXQvZXRoZXJu
ZXQvZnJlZXNjYWxlL3VjY19nZXRoLmMNCj4gPiBpbmRleCBmNzdiYTlmYTI1N2IuLjU2YjhmZGIz
NWMzYiAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL25ldC9ldGhlcm5ldC9mcmVlc2NhbGUvdWNj
X2dldGguYw0KPiA+ICsrKyBiL2RyaXZlcnMvbmV0L2V0aGVybmV0L2ZyZWVzY2FsZS91Y2NfZ2V0
aC5jDQo+ID4gQEAgLTM4NTcsNyArMzg1Nyw3IEBAIHN0YXRpYyBpbnQgdWNjX2dldGhfcHJvYmUo
c3RydWN0DQo+ID4gcGxhdGZvcm1fZGV2aWNlKiBvZmRldikNCj4gPiAgIAl9DQo+ID4gICANCj4g
PiAgIAlpZiAobmV0aWZfbXNnX3Byb2JlKCZkZWJ1ZykpDQo+ID4gLQkJcHJfaW5mbygiVUNDJTFk
IGF0IDB4JTh4IChpcnEgPSAlZClcbiIsDQo+ID4gKwkJcHJfaW5mbygiVUNDJTFkIGF0IDB4JThs
bHggKGlycSA9ICVkKVxuIiwNCj4gPiAgIAkJCXVnX2luZm8tPnVmX2luZm8udWNjX251bSArIDEs
IHVnX2luZm8tDQo+ID4gPnVmX2luZm8ucmVncywNCj4gPiAgIAkJCXVnX2luZm8tPnVmX2luZm8u
aXJxKTsNCj4gPiAgIA0KPiA+IA==
WARNING: multiple messages have this Message-ID (diff)
From: "Longchamp, Valentin" <Valentin.Longchamp@keymile.com>
To: "christophe.leroy@c-s.fr" <christophe.leroy@c-s.fr>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"leoli@freescale.com" <leoli@freescale.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] net/ethernet/freescale: fix warning for ucc_geth
Date: Thu, 14 Sep 2017 14:17:42 +0000 [thread overview]
Message-ID: <1505398677.19702.6.camel@keymile.com> (raw)
In-Reply-To: <f5c5c526-99d4-ff3d-1e2a-23d71bcafa4b@c-s.fr>
Hi Christophe,
On Thu, 2017-09-14 at 15:24 +0200, Christophe LEROY wrote:
> Hi,
>
> Le 14/09/2017 à 14:05, Valentin Longchamp a écrit :
> > Simple printk format warning for the the ucc registers address.
>
> Did you test your patch with mpc83xx_defconfig ?
No I only tested on a 85xx where I had another (similar, because the
physical addresses are u64 and not u32) warning.
My quick fix indeed did not take the different typedefs for
phys_addr_t.
I try to come with a v2 that covers this.
Thanks for the feedback.
Valentin
>
> I get a new warning with your patch:
>
> CC drivers/net/ethernet/freescale/ucc_geth.o
> In file included from ./include/linux/printk.h:6:0,
> from ./include/linux/kernel.h:13,
> from drivers/net/ethernet/freescale/ucc_geth.c:18:
> drivers/net/ethernet/freescale/ucc_geth.c: In function
> ‘ucc_geth_probe’:
> ./include/linux/kern_levels.h:4:18: warning: format ‘%llx’ expects
> argument of type ‘long long unsigned int’, but argument 3 has type
> ‘resource_size_t {aka unsigned int}’ [-Wformat=]
> #define KERN_SOH "\001" /* ASCII Start Of Header */
> ^
> ./include/linux/kern_levels.h:13:19: note: in expansion of macro
> ‘KERN_SOH’
> #define KERN_INFO KERN_SOH "6" /* informational */
> ^
> ./include/linux/printk.h:308:9: note: in expansion of macro
> ‘KERN_INFO’
> printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> ^
> drivers/net/ethernet/freescale/ucc_geth.c:3860:3: note: in expansion
> of
> macro ‘pr_info’
> pr_info("UCC%1d at 0x%8llx (irq = %d)\n",
> ^
>
> Christophe
>
> >
> > Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
> > ---
> > drivers/net/ethernet/freescale/ucc_geth.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/freescale/ucc_geth.c
> > b/drivers/net/ethernet/freescale/ucc_geth.c
> > index f77ba9fa257b..56b8fdb35c3b 100644
> > --- a/drivers/net/ethernet/freescale/ucc_geth.c
> > +++ b/drivers/net/ethernet/freescale/ucc_geth.c
> > @@ -3857,7 +3857,7 @@ static int ucc_geth_probe(struct
> > platform_device* ofdev)
> > }
> >
> > if (netif_msg_probe(&debug))
> > - pr_info("UCC%1d at 0x%8x (irq = %d)\n",
> > + pr_info("UCC%1d at 0x%8llx (irq = %d)\n",
> > ug_info->uf_info.ucc_num + 1, ug_info-
> > >uf_info.regs,
> > ug_info->uf_info.irq);
> >
> >
next prev parent reply other threads:[~2017-09-14 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 12:05 [PATCH] net/ethernet/freescale: fix warning for ucc_geth Valentin Longchamp
2017-09-14 13:24 ` Christophe LEROY
2017-09-14 14:17 ` Longchamp, Valentin [this message]
2017-09-14 14:17 ` Longchamp, Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505398677.19702.6.camel@keymile.com \
--to=valentin.longchamp@keymile.com \
--cc=christophe.leroy@c-s.fr \
--cc=leoli@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.