diff for duplicates of <1505485996.2852.4.camel@wdc.com> diff --git a/a/1.txt b/N1/1.txt index 19bbd8d..39a901e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,16 +1,21 @@ -T24gRnJpLCAyMDE3LTA5LTE1IGF0IDE5OjA2ICswOTAwLCBEYW1pZW4gTGUgTW9hbCB3cm90ZToN -Cj4gX19ibGtfbXFfZGVidWdmc19ycV9zaG93KCkgYW5kIGJsa19tcV9kZWJ1Z2ZzX3JxX3Nob3co -KSBhcmUgZXhwb3J0ZWQNCj4gc3ltYm9scyBidXQgYXIgZW9ubHkgZGVjbGFyZWQgaW4gdGhlIGJs -b2NrIGludGVybmFsIGZpbGUNCiAgICAgICAgICAgICAgXl5eXl5eXl4NCiAgICAgICAgICAgICAg -YXJlIG9ubHk/DQo+IGJsb2NrL2Jsay1tcS1kZWJ1Z2ZzLmguIHdoaWNoIGlzIG5vdCBjbGVhbmx5 -IGFjY2Vzc2libGUgdG8gZmlsZXMgb3V0c2lkZQ0KPiBvZiB0aGUgYmxvY2sgZGlyZWN0b3J5Lg0K -PiBNb3ZlIHRoZSBkZWNsYXJhdGlvbiBvZiB0aGVzZSBmdW5jdGlvbnMgdG8gdGhlIG5ldyBmaWxl -DQo+IGluY2x1ZGUvbGludXgvYmxrLW1xLWRlYnVnZnMuaCBmaWxlIHRvIG1ha2UgdGhlIGRlY2xh -cmF0aW9ucyBjbGVhbmx5DQo+IGF2YWlsYWJsZSB0byBvdGhlciBtb2R1bGVzLg0KPiANCj4gV2hp -bGUgYXQgaXQsIGFsc28gbW92ZSB0aGUgZGVmaW5pdGlvbiBvZiB0aGUgYmxrX21xX2RlYnVnZnNf -YXR0cg0KPiBzdHJ1Y3R1cmUgdG8gYWxsb3cgc2NoZWR1bGVyIG1vZHVsZXMgb3V0c2lkZSBvZiB0 -aGUgYmxvY2sgZGlyZWN0b3J5IHRvDQo+IGRlZmluZSBkZWJ1Z2ZzIGF0dHJpYnV0ZXMuDQoNClRo -ZSB0aXRsZSBvZiB0aGlzIHBhdGNoIGlzICJGaXggZGVjbGFyYXRpb24gb2YgLi4uIi4gU2hvdWxk -IHRoZSB0aXRsZSBwZXJoYXBzDQpoYXZlIGJlZW4gIk1vdmUgZGVjbGFyYXRpb25zIG9mIC4uLiI/ -DQoNCkFueXdheToNCg0KUmV2aWV3ZWQtYnk6IEJhcnQgVmFuIEFzc2NoZSA8YmFydC52YW5hc3Nj -aGVAd2RjLmNvbT4NCg0K +On Fri, 2017-09-15 at 19:06 +0900, Damien Le Moal wrote: +> __blk_mq_debugfs_rq_show() and blk_mq_debugfs_rq_show() are exported +> symbols but ar eonly declared in the block internal file + ^^^^^^^^ + are only? +> block/blk-mq-debugfs.h. which is not cleanly accessible to files outside +> of the block directory. +> Move the declaration of these functions to the new file +> include/linux/blk-mq-debugfs.h file to make the declarations cleanly +> available to other modules. +> +> While at it, also move the definition of the blk_mq_debugfs_attr +> structure to allow scheduler modules outside of the block directory to +> define debugfs attributes. + +The title of this patch is "Fix declaration of ...". Should the title perhaps +have been "Move declarations of ..."? + +Anyway: + +Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com> diff --git a/a/content_digest b/N1/content_digest index 02ddcd1..732e7e7 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -11,21 +11,26 @@ "Cc\0hch@lst.de <hch@lst.de>\0" "\00:1\0" "b\0" - "T24gRnJpLCAyMDE3LTA5LTE1IGF0IDE5OjA2ICswOTAwLCBEYW1pZW4gTGUgTW9hbCB3cm90ZToN\n" - "Cj4gX19ibGtfbXFfZGVidWdmc19ycV9zaG93KCkgYW5kIGJsa19tcV9kZWJ1Z2ZzX3JxX3Nob3co\n" - "KSBhcmUgZXhwb3J0ZWQNCj4gc3ltYm9scyBidXQgYXIgZW9ubHkgZGVjbGFyZWQgaW4gdGhlIGJs\n" - "b2NrIGludGVybmFsIGZpbGUNCiAgICAgICAgICAgICAgXl5eXl5eXl4NCiAgICAgICAgICAgICAg\n" - "YXJlIG9ubHk/DQo+IGJsb2NrL2Jsay1tcS1kZWJ1Z2ZzLmguIHdoaWNoIGlzIG5vdCBjbGVhbmx5\n" - "IGFjY2Vzc2libGUgdG8gZmlsZXMgb3V0c2lkZQ0KPiBvZiB0aGUgYmxvY2sgZGlyZWN0b3J5Lg0K\n" - "PiBNb3ZlIHRoZSBkZWNsYXJhdGlvbiBvZiB0aGVzZSBmdW5jdGlvbnMgdG8gdGhlIG5ldyBmaWxl\n" - "DQo+IGluY2x1ZGUvbGludXgvYmxrLW1xLWRlYnVnZnMuaCBmaWxlIHRvIG1ha2UgdGhlIGRlY2xh\n" - "cmF0aW9ucyBjbGVhbmx5DQo+IGF2YWlsYWJsZSB0byBvdGhlciBtb2R1bGVzLg0KPiANCj4gV2hp\n" - "bGUgYXQgaXQsIGFsc28gbW92ZSB0aGUgZGVmaW5pdGlvbiBvZiB0aGUgYmxrX21xX2RlYnVnZnNf\n" - "YXR0cg0KPiBzdHJ1Y3R1cmUgdG8gYWxsb3cgc2NoZWR1bGVyIG1vZHVsZXMgb3V0c2lkZSBvZiB0\n" - "aGUgYmxvY2sgZGlyZWN0b3J5IHRvDQo+IGRlZmluZSBkZWJ1Z2ZzIGF0dHJpYnV0ZXMuDQoNClRo\n" - "ZSB0aXRsZSBvZiB0aGlzIHBhdGNoIGlzICJGaXggZGVjbGFyYXRpb24gb2YgLi4uIi4gU2hvdWxk\n" - "IHRoZSB0aXRsZSBwZXJoYXBzDQpoYXZlIGJlZW4gIk1vdmUgZGVjbGFyYXRpb25zIG9mIC4uLiI/\n" - "DQoNCkFueXdheToNCg0KUmV2aWV3ZWQtYnk6IEJhcnQgVmFuIEFzc2NoZSA8YmFydC52YW5hc3Nj\n" - aGVAd2RjLmNvbT4NCg0K + "On Fri, 2017-09-15 at 19:06 +0900, Damien Le Moal wrote:\n" + "> __blk_mq_debugfs_rq_show() and blk_mq_debugfs_rq_show() are exported\n" + "> symbols but ar eonly declared in the block internal file\n" + " ^^^^^^^^\n" + " are only?\n" + "> block/blk-mq-debugfs.h. which is not cleanly accessible to files outside\n" + "> of the block directory.\n" + "> Move the declaration of these functions to the new file\n" + "> include/linux/blk-mq-debugfs.h file to make the declarations cleanly\n" + "> available to other modules.\n" + "> \n" + "> While at it, also move the definition of the blk_mq_debugfs_attr\n" + "> structure to allow scheduler modules outside of the block directory to\n" + "> define debugfs attributes.\n" + "\n" + "The title of this patch is \"Fix declaration of ...\". Should the title perhaps\n" + "have been \"Move declarations of ...\"?\n" + "\n" + "Anyway:\n" + "\n" + Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com> -a50657a052ccfcd9980b851830e5cc25ddf77bc30de33259a2eddac046a5dba0 +bb359c100d7ef86c34cfa248f36f37aebf9c9c768e4d5bc34e68cdd5356762cf
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.