From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "hch@lst.de" <hch@lst.de>
Subject: Re: [PATCH V3 01/12] block: Fix declaration of blk-mq debugfs functions
Date: Fri, 15 Sep 2017 14:33:17 +0000 [thread overview]
Message-ID: <1505485996.2852.4.camel@wdc.com> (raw)
In-Reply-To: <20170915100645.17999-2-damien.lemoal@wdc.com>
T24gRnJpLCAyMDE3LTA5LTE1IGF0IDE5OjA2ICswOTAwLCBEYW1pZW4gTGUgTW9hbCB3cm90ZToN
Cj4gX19ibGtfbXFfZGVidWdmc19ycV9zaG93KCkgYW5kIGJsa19tcV9kZWJ1Z2ZzX3JxX3Nob3co
KSBhcmUgZXhwb3J0ZWQNCj4gc3ltYm9scyBidXQgYXIgZW9ubHkgZGVjbGFyZWQgaW4gdGhlIGJs
b2NrIGludGVybmFsIGZpbGUNCiAgICAgICAgICAgICAgXl5eXl5eXl4NCiAgICAgICAgICAgICAg
YXJlIG9ubHk/DQo+IGJsb2NrL2Jsay1tcS1kZWJ1Z2ZzLmguIHdoaWNoIGlzIG5vdCBjbGVhbmx5
IGFjY2Vzc2libGUgdG8gZmlsZXMgb3V0c2lkZQ0KPiBvZiB0aGUgYmxvY2sgZGlyZWN0b3J5Lg0K
PiBNb3ZlIHRoZSBkZWNsYXJhdGlvbiBvZiB0aGVzZSBmdW5jdGlvbnMgdG8gdGhlIG5ldyBmaWxl
DQo+IGluY2x1ZGUvbGludXgvYmxrLW1xLWRlYnVnZnMuaCBmaWxlIHRvIG1ha2UgdGhlIGRlY2xh
cmF0aW9ucyBjbGVhbmx5DQo+IGF2YWlsYWJsZSB0byBvdGhlciBtb2R1bGVzLg0KPiANCj4gV2hp
bGUgYXQgaXQsIGFsc28gbW92ZSB0aGUgZGVmaW5pdGlvbiBvZiB0aGUgYmxrX21xX2RlYnVnZnNf
YXR0cg0KPiBzdHJ1Y3R1cmUgdG8gYWxsb3cgc2NoZWR1bGVyIG1vZHVsZXMgb3V0c2lkZSBvZiB0
aGUgYmxvY2sgZGlyZWN0b3J5IHRvDQo+IGRlZmluZSBkZWJ1Z2ZzIGF0dHJpYnV0ZXMuDQoNClRo
ZSB0aXRsZSBvZiB0aGlzIHBhdGNoIGlzICJGaXggZGVjbGFyYXRpb24gb2YgLi4uIi4gU2hvdWxk
IHRoZSB0aXRsZSBwZXJoYXBzDQpoYXZlIGJlZW4gIk1vdmUgZGVjbGFyYXRpb25zIG9mIC4uLiI/
DQoNCkFueXdheToNCg0KUmV2aWV3ZWQtYnk6IEJhcnQgVmFuIEFzc2NoZSA8YmFydC52YW5hc3Nj
aGVAd2RjLmNvbT4NCg0K
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "hch@lst.de" <hch@lst.de>
Subject: Re: [PATCH V3 01/12] block: Fix declaration of blk-mq debugfs functions
Date: Fri, 15 Sep 2017 14:33:17 +0000 [thread overview]
Message-ID: <1505485996.2852.4.camel@wdc.com> (raw)
In-Reply-To: <20170915100645.17999-2-damien.lemoal@wdc.com>
On Fri, 2017-09-15 at 19:06 +0900, Damien Le Moal wrote:
> __blk_mq_debugfs_rq_show() and blk_mq_debugfs_rq_show() are exported
> symbols but ar eonly declared in the block internal file
^^^^^^^^
are only?
> block/blk-mq-debugfs.h. which is not cleanly accessible to files outside
> of the block directory.
> Move the declaration of these functions to the new file
> include/linux/blk-mq-debugfs.h file to make the declarations cleanly
> available to other modules.
>
> While at it, also move the definition of the blk_mq_debugfs_attr
> structure to allow scheduler modules outside of the block directory to
> define debugfs attributes.
The title of this patch is "Fix declaration of ...". Should the title perhaps
have been "Move declarations of ..."?
Anyway:
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
next prev parent reply other threads:[~2017-09-15 14:33 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 10:06 [PATCH V3 00/12] scsi-mq support for ZBC disks Damien Le Moal
2017-09-15 10:06 ` [PATCH V3 01/12] block: Fix declaration of blk-mq debugfs functions Damien Le Moal
2017-09-15 14:33 ` Bart Van Assche [this message]
2017-09-15 14:33 ` Bart Van Assche
2017-09-15 17:45 ` Christoph Hellwig
2017-09-15 22:36 ` Damien Le Moal
2017-09-15 10:06 ` [PATCH V3 02/12] block: Fix declaration of blk-mq scheduler functions Damien Le Moal
2017-09-15 14:35 ` Bart Van Assche
2017-09-15 14:35 ` Bart Van Assche
2017-09-15 17:46 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 03/12] block: Add zoned block device information to request queue Damien Le Moal
2017-09-15 14:38 ` Bart Van Assche
2017-09-15 14:38 ` Bart Van Assche
2017-09-15 17:48 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 04/12] scsi: sd_zbc: Move ZBC declarations to scsi_proto.h Damien Le Moal
2017-09-15 17:48 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 05/12] scsi: sd_zbc: Fix comments and indentation Damien Le Moal
2017-09-15 10:44 ` Hannes Reinecke
2017-09-15 22:48 ` Damien Le Moal
2017-09-15 10:06 ` [PATCH V3 06/12] scsi: sd_zbc: Rearrange code Damien Le Moal
2017-09-15 10:45 ` Hannes Reinecke
2017-09-15 14:51 ` Bart Van Assche
2017-09-15 14:51 ` Bart Van Assche
2017-09-15 17:51 ` hch
2017-09-15 21:02 ` Bart Van Assche
2017-09-15 21:02 ` Bart Van Assche
2017-09-15 22:35 ` Damien Le Moal
2017-09-16 2:40 ` Bart Van Assche
2017-09-16 2:40 ` Bart Van Assche
2017-09-15 17:49 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 07/12] scsi: sd_zbc: Use well defined macros Damien Le Moal
2017-09-15 10:45 ` Hannes Reinecke
2017-09-15 16:27 ` Bart Van Assche
2017-09-15 16:27 ` Bart Van Assche
2017-09-15 17:51 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 08/12] scsi: sd_zbc: Fix sd_zbc_read_zoned_characteristics() Damien Le Moal
2017-09-15 10:46 ` Hannes Reinecke
2017-09-15 17:52 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 09/12] scsi: sd_zbc: Initialize device queue zoned structure Damien Le Moal
2017-09-15 10:49 ` Hannes Reinecke
2017-09-15 10:06 ` [PATCH V3 10/12] scsi: sd_zbc: Limit zone write locking to sequential zones Damien Le Moal
2017-09-15 10:52 ` Hannes Reinecke
2017-09-15 16:23 ` Bart Van Assche
2017-09-15 16:23 ` Bart Van Assche
2017-09-15 10:06 ` [PATCH V3 11/12] scsi: sd_zbc: Disable zone write locking with scsi-mq Damien Le Moal
2017-09-15 10:52 ` Hannes Reinecke
2017-09-15 10:06 ` [PATCH V3 12/12] block: Introduce zoned I/O scheduler Damien Le Moal
2017-09-15 10:55 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505485996.2852.4.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.