From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "hch@lst.de" <hch@lst.de>, Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH V3 06/12] scsi: sd_zbc: Rearrange code
Date: Sat, 16 Sep 2017 02:40:15 +0000 [thread overview]
Message-ID: <1505529516.3863.3.camel@wdc.com> (raw)
In-Reply-To: <4f51ccc7-1239-9505-564c-ec2c97cc626a@wdc.com>
T24gU2F0LCAyMDE3LTA5LTE2IGF0IDA3OjM1ICswOTAwLCBEYW1pZW4gTGUgTW9hbCB3cm90ZToN
Cj4gcncxNiBpcyBtYW5kYXRvcnkgZm9yIFpCQyBkcml2ZXMuIFNvIGl0IGhhcyB0byBiZSBzZXQg
dG8gdHJ1ZS4gSWYgdGhlDQo+IEhCQSBkb2VzIG5vdCBzdXBwb3J0IHJ3MTYgKHdoeSB3b3VsZCB0
aGF0IGhhcHBlbiA/KSwgdGhlbiB0aGUgZGlzaw0KPiBzaG91bGQgbm90IGJlIHVzZWQuDQoNCkl0
J3MgZ29vZCB0aGF0IGFsbCBIQkFzIHN1cHBvcnQgcncxNi4gQnV0IGl0J3Mgbm9udHJpdmlhbCB0
byBhbmFseXplIHdoZXRoZXINCm9yIG5vdCB1c2VfMVswNl1fZm9yX3J3IGFyZSBzZXQgYmVmb3Jl
IHRoZXNlIGFyZSB1c2VkIHNvIG1heWJlIHdlIHNob3VsZCB0aGluaw0KYWJvdXQgaG93IHdlIGNh
biByZXN0cnVjdHVyZSB0aGUgU0NTSSBjb2RlIHN1Y2ggdGhhdCBpdCBiZWNvbWVzIGVhc2llciB0
byB2ZXJpZnkNCnRoYXQgdXNlXzFbMDZdX2Zvcl9ydyBhcmUgc2V0IGJlZm9yZSB0aGVzZSBhcmUg
dXNlZC4NCg0KQmFydC4=
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "hch@lst.de" <hch@lst.de>, Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH V3 06/12] scsi: sd_zbc: Rearrange code
Date: Sat, 16 Sep 2017 02:40:15 +0000 [thread overview]
Message-ID: <1505529516.3863.3.camel@wdc.com> (raw)
In-Reply-To: <4f51ccc7-1239-9505-564c-ec2c97cc626a@wdc.com>
On Sat, 2017-09-16 at 07:35 +0900, Damien Le Moal wrote:
> rw16 is mandatory for ZBC drives. So it has to be set to true. If the
> HBA does not support rw16 (why would that happen ?), then the disk
> should not be used.
It's good that all HBAs support rw16. But it's nontrivial to analyze whether
or not use_1[06]_for_rw are set before these are used so maybe we should think
about how we can restructure the SCSI code such that it becomes easier to verify
that use_1[06]_for_rw are set before these are used.
Bart.
next prev parent reply other threads:[~2017-09-16 2:40 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 10:06 [PATCH V3 00/12] scsi-mq support for ZBC disks Damien Le Moal
2017-09-15 10:06 ` [PATCH V3 01/12] block: Fix declaration of blk-mq debugfs functions Damien Le Moal
2017-09-15 14:33 ` Bart Van Assche
2017-09-15 14:33 ` Bart Van Assche
2017-09-15 17:45 ` Christoph Hellwig
2017-09-15 22:36 ` Damien Le Moal
2017-09-15 10:06 ` [PATCH V3 02/12] block: Fix declaration of blk-mq scheduler functions Damien Le Moal
2017-09-15 14:35 ` Bart Van Assche
2017-09-15 14:35 ` Bart Van Assche
2017-09-15 17:46 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 03/12] block: Add zoned block device information to request queue Damien Le Moal
2017-09-15 14:38 ` Bart Van Assche
2017-09-15 14:38 ` Bart Van Assche
2017-09-15 17:48 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 04/12] scsi: sd_zbc: Move ZBC declarations to scsi_proto.h Damien Le Moal
2017-09-15 17:48 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 05/12] scsi: sd_zbc: Fix comments and indentation Damien Le Moal
2017-09-15 10:44 ` Hannes Reinecke
2017-09-15 22:48 ` Damien Le Moal
2017-09-15 10:06 ` [PATCH V3 06/12] scsi: sd_zbc: Rearrange code Damien Le Moal
2017-09-15 10:45 ` Hannes Reinecke
2017-09-15 14:51 ` Bart Van Assche
2017-09-15 14:51 ` Bart Van Assche
2017-09-15 17:51 ` hch
2017-09-15 21:02 ` Bart Van Assche
2017-09-15 21:02 ` Bart Van Assche
2017-09-15 22:35 ` Damien Le Moal
2017-09-16 2:40 ` Bart Van Assche [this message]
2017-09-16 2:40 ` Bart Van Assche
2017-09-15 17:49 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 07/12] scsi: sd_zbc: Use well defined macros Damien Le Moal
2017-09-15 10:45 ` Hannes Reinecke
2017-09-15 16:27 ` Bart Van Assche
2017-09-15 16:27 ` Bart Van Assche
2017-09-15 17:51 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 08/12] scsi: sd_zbc: Fix sd_zbc_read_zoned_characteristics() Damien Le Moal
2017-09-15 10:46 ` Hannes Reinecke
2017-09-15 17:52 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 09/12] scsi: sd_zbc: Initialize device queue zoned structure Damien Le Moal
2017-09-15 10:49 ` Hannes Reinecke
2017-09-15 10:06 ` [PATCH V3 10/12] scsi: sd_zbc: Limit zone write locking to sequential zones Damien Le Moal
2017-09-15 10:52 ` Hannes Reinecke
2017-09-15 16:23 ` Bart Van Assche
2017-09-15 16:23 ` Bart Van Assche
2017-09-15 10:06 ` [PATCH V3 11/12] scsi: sd_zbc: Disable zone write locking with scsi-mq Damien Le Moal
2017-09-15 10:52 ` Hannes Reinecke
2017-09-15 10:06 ` [PATCH V3 12/12] block: Introduce zoned I/O scheduler Damien Le Moal
2017-09-15 10:55 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505529516.3863.3.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.