From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "hch@lst.de" <hch@lst.de>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH V3 06/12] scsi: sd_zbc: Rearrange code
Date: Fri, 15 Sep 2017 21:02:22 +0000 [thread overview]
Message-ID: <1505509340.2417.18.camel@wdc.com> (raw)
In-Reply-To: <20170915175117.GG8578@lst.de>
T24gRnJpLCAyMDE3LTA5LTE1IGF0IDE5OjUxICswMjAwLCBoY2hAbHN0LmRlIHdyb3RlOg0KPiBP
biBGcmksIFNlcCAxNSwgMjAxNyBhdCAwMjo1MTowM1BNICswMDAwLCBCYXJ0IFZhbiBBc3NjaGUg
d3JvdGU6DQo+ID4gT24gRnJpLCAyMDE3LTA5LTE1IGF0IDE5OjA2ICswOTAwLCBEYW1pZW4gTGUg
TW9hbCB3cm90ZToNCj4gPiA+IFJlYXJyYW5nZSBzZF96YmNfc2V0dXAoKSB0byBpbmNsdWRlIHVz
ZV8xNl9mb3JfcncgYW5kIHVzZV8xMF9mb3JfcncNCj4gPiA+IGFzc2lnbm1lbnRzIGFuZCBtb3Zl
IHRoZSBjYWxjdWxhdGlvbiBvZiBzZGtwLT56b25lX3NoaWZ0IHRvZ2V0aGVyDQo+ID4gPiB3aXRo
IHRoZSBhc3NpZ25tZW50IG9mIHRoZSB2ZXJpZmllZCB6b25lX2Jsb2NrcyB2YWx1ZSBpbg0KPiA+
ID4gc2RfemJjX2NoZWNrX3pvbmVfc2l6ZSgpLg0KPiA+IA0KPiA+IEJvdGggZnVuY3Rpb25zIGFy
ZSBjYWxsZWQgZnJvbSBpbnNpZGUgYmxvY2tfZGV2aWNlX29wZXJhdGlvbnMucmV2YWxpZGF0ZV9k
aXNrLg0KPiA+IElzbid0IHRoYXQgdG9vIGxhdGUgdG8gc2V0IHVzZV8xWzA2XV9mb3Jfcnc/IFNo
b3VsZG4ndCBib3RoIGJlIHNldCBqdXN0IGFmdGVyDQo+ID4gdGhlIHNsYXZlX2FsbG9jIGNhbGxi
YWNrIGhhcyBiZWVuIGNhbGxlZD8NCj4gDQo+IEhtbS4gIHNkX3JlYWRfY2FwYWNpdHkgYWxyZWFk
eSBpcyBjYWxsZWQgZnJvbSB0aGUgc2FtZSBwYXRoIGFuZCBzZWVtcw0KPiB0byB3b3JrLi4NCg0K
SGVsbG8gQ2hyaXN0b3BoLA0KDQpNeSBjb25jZXJuIGlzIHRoYXQgaWYgYm90aCBhIFNDU0kgTExE
IGFuZCB0aGUgWkJDIGNvZGUgc2V0IHVzZV8xWzA2XV9mb3JfcncNCnRoYXQgdGhlc2Ugc2V0dGlu
Z3MgbWF5IGNvbmZsaWN0LiBTaG91bGQgdGhlIFpCQyBjb2RlIGUuZy4gcmVmdXNlIHRoYXQgdGhl
IHNkDQpkcml2ZXIgaXMgYXR0YWNoZWQgdG8gYSBaQkMgZGlzayBjb250cm9sbGVkIGJ5IGEgU0NT
SSBMTEQgdGhhdCBzdXBwb3J0cw0KdXNlXzEwX2Zvcl9ydyBidXQgbm90IHVzZV8xNl9mb3Jfcnc/
DQoNClRoYW5rcywNCg0KQmFydC4=
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "hch@lst.de" <hch@lst.de>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH V3 06/12] scsi: sd_zbc: Rearrange code
Date: Fri, 15 Sep 2017 21:02:22 +0000 [thread overview]
Message-ID: <1505509340.2417.18.camel@wdc.com> (raw)
In-Reply-To: <20170915175117.GG8578@lst.de>
On Fri, 2017-09-15 at 19:51 +0200, hch@lst.de wrote:
> On Fri, Sep 15, 2017 at 02:51:03PM +0000, Bart Van Assche wrote:
> > On Fri, 2017-09-15 at 19:06 +0900, Damien Le Moal wrote:
> > > Rearrange sd_zbc_setup() to include use_16_for_rw and use_10_for_rw
> > > assignments and move the calculation of sdkp->zone_shift together
> > > with the assignment of the verified zone_blocks value in
> > > sd_zbc_check_zone_size().
> >
> > Both functions are called from inside block_device_operations.revalidate_disk.
> > Isn't that too late to set use_1[06]_for_rw? Shouldn't both be set just after
> > the slave_alloc callback has been called?
>
> Hmm. sd_read_capacity already is called from the same path and seems
> to work..
Hello Christoph,
My concern is that if both a SCSI LLD and the ZBC code set use_1[06]_for_rw
that these settings may conflict. Should the ZBC code e.g. refuse that the sd
driver is attached to a ZBC disk controlled by a SCSI LLD that supports
use_10_for_rw but not use_16_for_rw?
Thanks,
Bart.
next prev parent reply other threads:[~2017-09-15 21:02 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 10:06 [PATCH V3 00/12] scsi-mq support for ZBC disks Damien Le Moal
2017-09-15 10:06 ` [PATCH V3 01/12] block: Fix declaration of blk-mq debugfs functions Damien Le Moal
2017-09-15 14:33 ` Bart Van Assche
2017-09-15 14:33 ` Bart Van Assche
2017-09-15 17:45 ` Christoph Hellwig
2017-09-15 22:36 ` Damien Le Moal
2017-09-15 10:06 ` [PATCH V3 02/12] block: Fix declaration of blk-mq scheduler functions Damien Le Moal
2017-09-15 14:35 ` Bart Van Assche
2017-09-15 14:35 ` Bart Van Assche
2017-09-15 17:46 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 03/12] block: Add zoned block device information to request queue Damien Le Moal
2017-09-15 14:38 ` Bart Van Assche
2017-09-15 14:38 ` Bart Van Assche
2017-09-15 17:48 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 04/12] scsi: sd_zbc: Move ZBC declarations to scsi_proto.h Damien Le Moal
2017-09-15 17:48 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 05/12] scsi: sd_zbc: Fix comments and indentation Damien Le Moal
2017-09-15 10:44 ` Hannes Reinecke
2017-09-15 22:48 ` Damien Le Moal
2017-09-15 10:06 ` [PATCH V3 06/12] scsi: sd_zbc: Rearrange code Damien Le Moal
2017-09-15 10:45 ` Hannes Reinecke
2017-09-15 14:51 ` Bart Van Assche
2017-09-15 14:51 ` Bart Van Assche
2017-09-15 17:51 ` hch
2017-09-15 21:02 ` Bart Van Assche [this message]
2017-09-15 21:02 ` Bart Van Assche
2017-09-15 22:35 ` Damien Le Moal
2017-09-16 2:40 ` Bart Van Assche
2017-09-16 2:40 ` Bart Van Assche
2017-09-15 17:49 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 07/12] scsi: sd_zbc: Use well defined macros Damien Le Moal
2017-09-15 10:45 ` Hannes Reinecke
2017-09-15 16:27 ` Bart Van Assche
2017-09-15 16:27 ` Bart Van Assche
2017-09-15 17:51 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 08/12] scsi: sd_zbc: Fix sd_zbc_read_zoned_characteristics() Damien Le Moal
2017-09-15 10:46 ` Hannes Reinecke
2017-09-15 17:52 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 09/12] scsi: sd_zbc: Initialize device queue zoned structure Damien Le Moal
2017-09-15 10:49 ` Hannes Reinecke
2017-09-15 10:06 ` [PATCH V3 10/12] scsi: sd_zbc: Limit zone write locking to sequential zones Damien Le Moal
2017-09-15 10:52 ` Hannes Reinecke
2017-09-15 16:23 ` Bart Van Assche
2017-09-15 16:23 ` Bart Van Assche
2017-09-15 10:06 ` [PATCH V3 11/12] scsi: sd_zbc: Disable zone write locking with scsi-mq Damien Le Moal
2017-09-15 10:52 ` Hannes Reinecke
2017-09-15 10:06 ` [PATCH V3 12/12] block: Introduce zoned I/O scheduler Damien Le Moal
2017-09-15 10:55 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505509340.2417.18.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.