From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "hch@lst.de" <hch@lst.de>
Subject: Re: [PATCH V3 10/12] scsi: sd_zbc: Limit zone write locking to sequential zones
Date: Fri, 15 Sep 2017 16:23:49 +0000 [thread overview]
Message-ID: <1505492627.3420.5.camel@wdc.com> (raw)
In-Reply-To: <20170915100645.17999-11-damien.lemoal@wdc.com>
T24gRnJpLCAyMDE3LTA5LTE1IGF0IDE5OjA2ICswOTAwLCBEYW1pZW4gTGUgTW9hbCB3cm90ZToN
Cj4gKwkgKiBUaGVyZSBpcyBubyB3cml0ZSBjb25zdHJhaW50cyBvbiBjb252ZW50aW9uYWwgem9u
ZXMuIFNvIGFueSB3cml0ZQ0KICAgICAgICAgICBeXl5eXl5eXl5eXg0KU2hvdWxkIHRoaXMgaGF2
ZSBiZWVuICJUaGVyZSBhcmUgbm8iPw0KDQo+IC0JaWYgKHNka3AtPnpvbmVzX3dsb2NrICYmDQo+
IC0JICAgIHRlc3RfYW5kX3NldF9iaXQoem5vLCBzZGtwLT56b25lc193bG9jaykpDQo+ICsJaWYg
KHEtPnpvbmVkLnNlcV96b25lcyAmJiB0ZXN0X2JpdCh6bm8sIHEtPnpvbmVkLnNlcV96b25lcykp
DQo+ICsJCXJldHVybiBCTEtQUkVQX09LOw0KPiArCWlmIChzZGtwLT56b25lc193bG9jayAmJiB0
ZXN0X2FuZF9zZXRfYml0KHpubywgc2RrcC0+em9uZXNfd2xvY2spKQ0KPiAgCQlyZXR1cm4gQkxL
UFJFUF9ERUZFUjsNCg0KUGxlYXNlIGludHJvZHVjZSBoZWxwZXIgZnVuY3Rpb25zIGluIGluY2x1
ZGUvbGludXgvYmxrZGV2Lmggb3IgaW4gYSBuZXcNCmhlYWRlciBmaWxlIGZvciB2ZXJpZnlpbmcg
d2hldGhlciBvciBub3QgYSB6b25lIGlzIGEgc2VxdWVudGlhbCB6b25lIGFuZCBhbHNvDQpmb3Ig
bG9ja2luZyBhIHpvbmUgZm9yIHdyaXRlcy4gSSBleHBlY3QgdGhhdCB0aGF0IHdpbGwgbWFrZSB0
aGUgYWJvdmUgY29kZQ0Kc2lnbmlmaWNhbnRseSBlYXNpZXIgdG8gcmVhZC4NCg0KVGhhbmtzLA0K
DQpCYXJ0Lg==
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "hch@lst.de" <hch@lst.de>
Subject: Re: [PATCH V3 10/12] scsi: sd_zbc: Limit zone write locking to sequential zones
Date: Fri, 15 Sep 2017 16:23:49 +0000 [thread overview]
Message-ID: <1505492627.3420.5.camel@wdc.com> (raw)
In-Reply-To: <20170915100645.17999-11-damien.lemoal@wdc.com>
On Fri, 2017-09-15 at 19:06 +0900, Damien Le Moal wrote:
> + * There is no write constraints on conventional zones. So any write
^^^^^^^^^^^
Should this have been "There are no"?
> - if (sdkp->zones_wlock &&
> - test_and_set_bit(zno, sdkp->zones_wlock))
> + if (q->zoned.seq_zones && test_bit(zno, q->zoned.seq_zones))
> + return BLKPREP_OK;
> + if (sdkp->zones_wlock && test_and_set_bit(zno, sdkp->zones_wlock))
> return BLKPREP_DEFER;
Please introduce helper functions in include/linux/blkdev.h or in a new
header file for verifying whether or not a zone is a sequential zone and also
for locking a zone for writes. I expect that that will make the above code
significantly easier to read.
Thanks,
Bart.
next prev parent reply other threads:[~2017-09-15 16:23 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 10:06 [PATCH V3 00/12] scsi-mq support for ZBC disks Damien Le Moal
2017-09-15 10:06 ` [PATCH V3 01/12] block: Fix declaration of blk-mq debugfs functions Damien Le Moal
2017-09-15 14:33 ` Bart Van Assche
2017-09-15 14:33 ` Bart Van Assche
2017-09-15 17:45 ` Christoph Hellwig
2017-09-15 22:36 ` Damien Le Moal
2017-09-15 10:06 ` [PATCH V3 02/12] block: Fix declaration of blk-mq scheduler functions Damien Le Moal
2017-09-15 14:35 ` Bart Van Assche
2017-09-15 14:35 ` Bart Van Assche
2017-09-15 17:46 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 03/12] block: Add zoned block device information to request queue Damien Le Moal
2017-09-15 14:38 ` Bart Van Assche
2017-09-15 14:38 ` Bart Van Assche
2017-09-15 17:48 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 04/12] scsi: sd_zbc: Move ZBC declarations to scsi_proto.h Damien Le Moal
2017-09-15 17:48 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 05/12] scsi: sd_zbc: Fix comments and indentation Damien Le Moal
2017-09-15 10:44 ` Hannes Reinecke
2017-09-15 22:48 ` Damien Le Moal
2017-09-15 10:06 ` [PATCH V3 06/12] scsi: sd_zbc: Rearrange code Damien Le Moal
2017-09-15 10:45 ` Hannes Reinecke
2017-09-15 14:51 ` Bart Van Assche
2017-09-15 14:51 ` Bart Van Assche
2017-09-15 17:51 ` hch
2017-09-15 21:02 ` Bart Van Assche
2017-09-15 21:02 ` Bart Van Assche
2017-09-15 22:35 ` Damien Le Moal
2017-09-16 2:40 ` Bart Van Assche
2017-09-16 2:40 ` Bart Van Assche
2017-09-15 17:49 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 07/12] scsi: sd_zbc: Use well defined macros Damien Le Moal
2017-09-15 10:45 ` Hannes Reinecke
2017-09-15 16:27 ` Bart Van Assche
2017-09-15 16:27 ` Bart Van Assche
2017-09-15 17:51 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 08/12] scsi: sd_zbc: Fix sd_zbc_read_zoned_characteristics() Damien Le Moal
2017-09-15 10:46 ` Hannes Reinecke
2017-09-15 17:52 ` Christoph Hellwig
2017-09-15 10:06 ` [PATCH V3 09/12] scsi: sd_zbc: Initialize device queue zoned structure Damien Le Moal
2017-09-15 10:49 ` Hannes Reinecke
2017-09-15 10:06 ` [PATCH V3 10/12] scsi: sd_zbc: Limit zone write locking to sequential zones Damien Le Moal
2017-09-15 10:52 ` Hannes Reinecke
2017-09-15 16:23 ` Bart Van Assche [this message]
2017-09-15 16:23 ` Bart Van Assche
2017-09-15 10:06 ` [PATCH V3 11/12] scsi: sd_zbc: Disable zone write locking with scsi-mq Damien Le Moal
2017-09-15 10:52 ` Hannes Reinecke
2017-09-15 10:06 ` [PATCH V3 12/12] block: Introduce zoned I/O scheduler Damien Le Moal
2017-09-15 10:55 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505492627.3420.5.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.