From: rosenp@gmail.com
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, zajec5@gmail.com, nbd@nbd.name
Subject: Re: [PATCH] bgmac: Remove all offloading features, including GRO.
Date: Fri, 15 Sep 2017 16:55:28 -0700 [thread overview]
Message-ID: <1505519728.8507.0.camel@gmail.com> (raw)
In-Reply-To: <20170915.161403.2131524326226213839.davem@davemloft.net>
you're absolutely correct. will send an updated version shortly.
On Fri, 2017-09-15 at 16:14 -0700, David Miller wrote:
> From: Rosen Penev <rosenp@gmail.com>
> Date: Fri, 15 Sep 2017 15:22:18 -0700
>
> > On a linksys E1200v1 (actually a crossflashed E1000v2), the
> offloading features give no measurable benefit to speed or latency.
> Furthermore, disabling GRO actually improves iperf performance by a
> whoppimg 3mbps. Results:
> ...
> > - net_dev->features = NETIF_F_SG | NETIF_F_IP_CSUM |
> NETIF_F_IPV6_CSUM;
> > + net_dev->features &= NETIF_F_GRO;
> > net_dev->hw_features = net_dev->features;
>
> This doesn't disable GRO.
next prev parent reply other threads:[~2017-09-15 23:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 22:22 [PATCH] bgmac: Remove all offloading features, including GRO Rosen Penev
2017-09-15 22:54 ` Florian Fainelli
2017-09-16 0:03 ` Eric Dumazet
2017-09-16 0:10 ` rosenp
2017-09-16 0:18 ` Eric Dumazet
2017-09-16 0:24 ` rosenp
2017-09-16 0:25 ` Denys Fedoryshchenko
2017-09-16 3:56 ` David Miller
2017-09-15 23:14 ` David Miller
2017-09-15 23:55 ` rosenp [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-09-16 0:23 Rosen Penev
2017-09-16 0:34 ` Eric Dumazet
2017-09-16 0:38 ` rosenp
2017-09-16 6:04 ` Florian Fainelli
2017-09-20 21:27 ` rosenp
2017-09-20 21:32 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505519728.8507.0.camel@gmail.com \
--to=rosenp@gmail.com \
--cc=davem@davemloft.net \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.