From: rosenp@gmail.com
To: Eric Dumazet <eric.dumazet@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, zajec5@gmail.com, nbd@nbd.name
Subject: Re: [PATCH] bgmac: Remove all offloading features, including GRO.
Date: Fri, 15 Sep 2017 17:10:38 -0700 [thread overview]
Message-ID: <1505520638.8507.2.camel@gmail.com> (raw)
In-Reply-To: <1505520210.29839.7.camel@edumazet-glaptop3.roam.corp.google.com>
Ok fair enough. Will only disable GRO in the driver.
Tests were done using "ethtool -K eth0 gro off" and on.
On Fri, 2017-09-15 at 17:03 -0700, Eric Dumazet wrote:
> On Fri, 2017-09-15 at 15:54 -0700, Florian Fainelli wrote:
> > On September 15, 2017 3:22:18 PM PDT, Rosen Penev <rosenp@gmail.com
> > >
> > wrote:
> > > On a linksys E1200v1 (actually a crossflashed E1000v2), the
> >
> > offloading
> > > features give no measurable benefit to speed or latency.
> > > Furthermore,
> > > disabling GRO actually improves iperf performance by a whoppimg
> >
> > 3mbps.
> >
> > Do you have a way to generate gigabit tests and see what results
> > you
> > are getting? We probably are not going to see a 30% improvement
> > just
> > by extrapolation.
> >
>
> +1
>
> It seems silly to remove NETIF_F_SG | NETIF_F_IP_CSUM |
> NETIF_F_IPV6_CSUM from dev->features, yet leave the dead-code in the
> driver to handle these features.
>
> And of course GRO was not removed, meaning the bench results were non
> conclusive.
>
>
>
next prev parent reply other threads:[~2017-09-16 0:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 22:22 [PATCH] bgmac: Remove all offloading features, including GRO Rosen Penev
2017-09-15 22:54 ` Florian Fainelli
2017-09-16 0:03 ` Eric Dumazet
2017-09-16 0:10 ` rosenp [this message]
2017-09-16 0:18 ` Eric Dumazet
2017-09-16 0:24 ` rosenp
2017-09-16 0:25 ` Denys Fedoryshchenko
2017-09-16 3:56 ` David Miller
2017-09-15 23:14 ` David Miller
2017-09-15 23:55 ` rosenp
-- strict thread matches above, loose matches on Subject: below --
2017-09-16 0:23 Rosen Penev
2017-09-16 0:34 ` Eric Dumazet
2017-09-16 0:38 ` rosenp
2017-09-16 6:04 ` Florian Fainelli
2017-09-20 21:27 ` rosenp
2017-09-20 21:32 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505520638.8507.2.camel@gmail.com \
--to=rosenp@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.