All of lore.kernel.org
 help / color / mirror / Atom feed
* [xen-unstable test] 113562: regressions - FAIL
@ 2017-09-18  8:36 osstest service owner
  2017-09-18  9:37 ` Wei Liu
  0 siblings, 1 reply; 14+ messages in thread
From: osstest service owner @ 2017-09-18  8:36 UTC (permalink / raw)
  To: xen-devel, osstest-admin

flight 113562 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/113562/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-credit2  15 guest-saverestore        fail REGR. vs. 113387
 test-amd64-i386-xl-qemut-win7-amd64 18 guest-start/win.repeat fail in 113543 REGR. vs. 113387

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail in 113524 pass in 113543
 test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore.2 fail in 113524 pass in 113562
 test-armhf-armhf-libvirt-raw  7 xen-boot         fail in 113524 pass in 113562
 test-armhf-armhf-xl-multivcpu  6 xen-install     fail in 113543 pass in 113562
 test-armhf-armhf-xl-xsm       6 xen-install      fail in 113543 pass in 113562
 test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-localmigrate/x10 fail pass in 113524
 test-amd64-amd64-xl          18 guest-localmigrate/x10     fail pass in 113543
 test-amd64-i386-xl-qemut-win7-amd64 16 guest-localmigrate/x10 fail pass in 113543

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop      fail blocked in 113387
 test-armhf-armhf-xl-rtds 16 guest-start/debian.repeat fail in 113524 blocked in 113387
 test-amd64-amd64-xl-qemut-win7-amd64 16 guest-localmigrate/x10 fail in 113524 like 113387
 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop  fail in 113524 like 113387
 test-amd64-amd64-xl-qemut-win7-amd64 18 guest-start/win.repeat fail in 113543 blocked in 113387
 test-armhf-armhf-libvirt     14 saverestore-support-check    fail  like 113387
 test-armhf-armhf-libvirt-xsm 14 saverestore-support-check    fail  like 113387
 test-amd64-amd64-xl-rtds     10 debian-install               fail  like 113387
 test-armhf-armhf-libvirt-raw 13 saverestore-support-check    fail  like 113387
 test-amd64-amd64-xl-qemut-ws16-amd64 10 windows-install        fail never pass
 test-amd64-amd64-xl-qemuu-ws16-amd64 10 windows-install        fail never pass
 test-amd64-i386-libvirt-xsm  13 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     13 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 13 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      13 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 12 migrate-support-check        fail   never pass
 test-amd64-i386-xl-qemuu-ws16-amd64 13 guest-saverestore       fail never pass
 test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2  fail never pass
 test-armhf-armhf-libvirt     13 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          13 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          14 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 13 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 14 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-xsm 13 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 13 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 14 saverestore-support-check    fail  never pass
 test-amd64-i386-xl-qemut-ws16-amd64 13 guest-saverestore       fail never pass
 test-amd64-i386-libvirt-qcow2 12 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit2  13 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  14 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-xsm      13 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-xsm      14 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  13 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  14 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     13 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     14 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 12 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      12 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      13 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-qemut-win10-i386 10 windows-install         fail never pass
 test-amd64-i386-xl-qemuu-win10-i386 10 windows-install         fail never pass
 test-amd64-amd64-xl-qemut-win10-i386 10 windows-install        fail never pass
 test-amd64-amd64-xl-qemuu-win10-i386 10 windows-install        fail never pass

version targeted for testing:
 xen                  abd91b2a2bcd05618a71f7e5fe571dd10a5727bc
baseline version:
 xen                  16b1414de91b5a82a0996c67f6db3af7d7e32873

Last test of basis   113387  2017-09-12 23:20:09 Z    5 days
Failing since        113430  2017-09-14 01:24:48 Z    4 days    7 attempts
Testing same since   113511  2017-09-16 13:59:07 Z    1 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bhupinder Thakur <bhupinder.thakur@linaro.org>
  Boris Ostrovsky <boris.ostrovsky@oracle.com>
  Dario Faggioli <dario.faggioli@citrix.com>
  Haozhong Zhang <haozhong.zhang@intel.com>
  Ian Jackson <ian.jackson@eu.citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <julien.grall@arm.com>
  Oleksandr Grytsov <oleksandr_grytsov@epam.com>
  Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
  Petre Pircalabu <ppircalabu@bitdefender.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Wei Liu <wei.liu2@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-armhf-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 build-amd64-rumprun                                          pass    
 build-i386-rumprun                                           pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          fail    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64-xsm                pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64-xsm                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm                pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm                 pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-armhf-armhf-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-armhf-armhf-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvh-amd                                  pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-rumprun-amd64                               pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          pass    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-i386-rumprun-i386                                 pass    
 test-amd64-amd64-xl-qemut-win10-i386                         fail    
 test-amd64-i386-xl-qemut-win10-i386                          fail    
 test-amd64-amd64-xl-qemuu-win10-i386                         fail    
 test-amd64-i386-xl-qemuu-win10-i386                          fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvh-intel                                pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-amd64-pvgrub                                pass    
 test-amd64-amd64-i386-pvgrub                                 pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-i386-libvirt-qcow2                                pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-xl-raw                                       pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 691 lines long.)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [xen-unstable test] 113562: regressions - FAIL
  2017-09-18  8:36 [xen-unstable test] 113562: regressions - FAIL osstest service owner
@ 2017-09-18  9:37 ` Wei Liu
  2017-09-18  9:45   ` Roger Pau Monné
  0 siblings, 1 reply; 14+ messages in thread
From: Wei Liu @ 2017-09-18  9:37 UTC (permalink / raw)
  To: osstest service owner; +Cc: George Dunlap, Dario Faggioli, xen-devel, Wei Liu

On Mon, Sep 18, 2017 at 08:36:03AM +0000, osstest service owner wrote:
> flight 113562 xen-unstable real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/113562/
> 
> Regressions :-(
> 
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  test-amd64-amd64-xl-credit2  15 guest-saverestore        fail REGR. vs. 113387

There appears to be a bug:

http://logs.test-lab.xenproject.org/osstest/logs/113562/test-amd64-amd64-xl-credit2/serial-godello0.log

Sep 18 01:14:28.803062 (XEN) Xen BUG at spinlock.c:47
Sep 18 01:14:29.835144 (XEN) ----[ Xen-4.10-unstable  x86_64  debug=y   Not tainted ]----
Sep 18 01:14:29.843085 (XEN) CPU:    0
Sep 18 01:14:29.843103 (XEN) RIP:    e008:[<ffff82d08023bbbd>] spinlock.c#check_lock+0x3c/0x40
Sep 18 01:14:29.851140 (XEN) RFLAGS: 0000000000010046   CONTEXT: hypervisor (d0v2)
Sep 18 01:14:29.851171 (XEN) rax: 0000000000000000   rbx: ffff83025d7d7868   rcx: 0000000000000000
Sep 18 01:14:29.859129 (XEN) rdx: 0000000000000001   rsi: ffff83025d7d6000   rdi: ffff83025d7d786e
Sep 18 01:14:29.867088 (XEN) rbp: ffff83009546fd70   rsp: ffff83009546fd70   r8:  0000000000000000
Sep 18 01:14:29.875092 (XEN) r9:  00000000000000b4   r10: 0000000000000016   r11: 00000000000f4240
Sep 18 01:14:29.883081 (XEN) r12: ffff83025d7d6000   r13: ffff83025d7d7868   r14: ffff83024f3e5000
Sep 18 01:14:29.891071 (XEN) r15: ffff83009546ff18   cr0: 000000008005003b   cr4: 00000000001526e0
Sep 18 01:14:29.899080 (XEN) cr3: 000000024caa7000   cr2: ffff88001a046360
Sep 18 01:14:29.907134 (XEN) ds: 002b   es: 002b   fs: 0000   gs: 0000   ss: e010   cs: e008
Sep 18 01:14:29.915063 (XEN) Xen code around <ffff82d08023bbbd> (spinlock.c#check_lock+0x3c/0x40):
Sep 18 01:14:29.923060 (XEN)  98 83 f1 01 39 c8 75 02 <0f> 0b 5d c3 55 48 89 e5 f0 ff 05 00 fd 20 00 5d
Sep 18 01:14:29.931056 (XEN) Xen stack trace from rsp=ffff83009546fd70:
Sep 18 01:14:29.931076 (XEN)    ffff83009546fd88 ffff82d08023bc68 ffff83024eb83fb0 ffff83009546fdb8
Sep 18 01:14:29.939069 (XEN)    ffff82d0802474db 0000000000000046 ffff83024eb82e40 ffff83024eb83fb0
Sep 18 01:14:29.947067 (XEN)    0000000000000292 ffff83009546fdf8 ffff82d080247c87 ffff83024e964a80
Sep 18 01:14:29.955087 (XEN)    ffff83024eb82e40 ffff83025d7b14d0 0000000000000292 ffff83024f3e5000
Sep 18 01:14:29.963129 (XEN)    ffff83009546ff18 ffff83009546fe28 ffff82d08022eed7 0100100100100100
Sep 18 01:14:29.971093 (XEN)    ffff83024f3e5000 00000000ffffffff ffff83024f3e5aa8 ffff83009546fe38
Sep 18 01:14:29.979102 (XEN)    ffff82d08022ef39 ffff83009546fe68 ffff82d080238886 ffff83009573a000
Sep 18 01:14:29.987081 (XEN)    00000000ffffffff ffff83024f3e5aa8 ffff83009573a000 ffff83009546fe98
Sep 18 01:14:29.995067 (XEN)    ffff82d080207d53 ffff82d0805a7340 0000000000000000 0000000000000000
Sep 18 01:14:30.003074 (XEN)    ffff83009546ffff ffff83009546fec8 ffff82d080229cf0 ffff82d08057ad80
Sep 18 01:14:30.011070 (XEN)    ffff82d08057ad80 ffff82d08057ad80 ffffffffffffffff ffff83009546fef8
Sep 18 01:14:30.019075 (XEN)    ffff82d08023b34d ffff8300951fa000 ffff8300951fe000 ffff8302579ce000
Sep 18 01:14:30.019097 (XEN)    ffff83009546ffff ffff83009546ff08 ffff82d08023b3a2 ffff83009546fda0
Sep 18 01:14:30.027071 (XEN)    ffff82d08035f881 ffff88001a989a80 ffff88001a989a80 0000000000000000
Sep 18 01:14:30.035096 (XEN)    0000000000000002 ffffc9000027feb0 0000000000000002 0000000000000246
Sep 18 01:14:30.043101 (XEN)    0000000000000000 0000000000000000 0000000000000000 0000000000000000
Sep 18 01:14:30.051061 (XEN)    ffffffff810013aa ffffffff81e465a0 deadbeefdeadf00d deadbeefdeadf00d
Sep 18 01:14:30.059100 (XEN)    0002010000000000 ffffffff810013aa 000000000000e033 0000000000000246
Sep 18 01:14:30.067096 (XEN)    ffffc9000027fe98 000000000000e02b 000000000009dfa3 003d685c00000001
Sep 18 01:14:30.075097 (XEN)    003d6ca30009dfa3 000000000009dfb0 003d6c8000000000 ffff8300951fa000
Sep 18 01:14:30.083114 (XEN) Xen call trace:
Sep 18 01:14:30.083132 (XEN)    [<ffff82d08023bbbd>] spinlock.c#check_lock+0x3c/0x40
Sep 18 01:14:30.091094 (XEN)    [<ffff82d08023bc68>] _spin_lock+0x11/0x4f
Sep 18 01:14:30.099100 (XEN)    [<ffff82d0802474db>] xmem_pool_free+0x2b/0x2b1
Sep 18 01:14:30.099120 (XEN)    [<ffff82d080247c87>] xfree+0x1d1/0x21e
Sep 18 01:14:30.107088 (XEN)    [<ffff82d08022eed7>] sched_credit2.c#csched2_free_domdata+0x46/0x92
Sep 18 01:14:30.115072 (XEN)    [<ffff82d08022ef39>] sched_credit2.c#csched2_dom_destroy+0x16/0x18
Sep 18 01:14:30.123132 (XEN)    [<ffff82d080238886>] sched_destroy_domain+0x65/0x9f
Sep 18 01:14:30.131063 (XEN)    [<ffff82d080207d53>] domain.c#complete_domain_destroy+0x87/0x194
Sep 18 01:14:30.139085 (XEN)    [<ffff82d080229cf0>] rcupdate.c#rcu_process_callbacks+0x141/0x1a2
Sep 18 01:14:30.139107 (XEN)    [<ffff82d08023b34d>] softirq.c#__do_softirq+0x7f/0x8a
Sep 18 01:14:30.147069 (XEN)    [<ffff82d08023b3a2>] do_softirq+0x13/0x15
Sep 18 01:14:30.155082 (XEN)    [<ffff82d08035f881>] x86_64/entry.S#process_softirqs+0x21/0x30
Sep 18 01:14:30.163053 (XEN) 
Sep 18 01:14:30.163067 (XEN) 
Sep 18 01:14:30.163080 (XEN) ****************************************
Sep 18 01:14:30.171080 (XEN) Panic on CPU 0:
Sep 18 01:14:30.171095 (XEN) Xen BUG at spinlock.c:47
Sep 18 01:14:30.171110 (XEN) ****************************************
Sep 18 01:14:30.179133 (XEN) 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [xen-unstable test] 113562: regressions - FAIL
  2017-09-18  9:37 ` Wei Liu
@ 2017-09-18  9:45   ` Roger Pau Monné
  2017-09-18 10:15     ` George Dunlap
  0 siblings, 1 reply; 14+ messages in thread
From: Roger Pau Monné @ 2017-09-18  9:45 UTC (permalink / raw)
  To: Wei Liu; +Cc: George Dunlap, Dario Faggioli, xen-devel, osstest service owner

On Mon, Sep 18, 2017 at 10:37:58AM +0100, Wei Liu wrote:
> On Mon, Sep 18, 2017 at 08:36:03AM +0000, osstest service owner wrote:
> > flight 113562 xen-unstable real [real]
> > http://logs.test-lab.xenproject.org/osstest/logs/113562/
> > 
> > Regressions :-(
> > 
> > Tests which did not succeed and are blocking,
> > including tests which could not be run:
> >  test-amd64-amd64-xl-credit2  15 guest-saverestore        fail REGR. vs. 113387
> 
> There appears to be a bug:
> 
> http://logs.test-lab.xenproject.org/osstest/logs/113562/test-amd64-amd64-xl-credit2/serial-godello0.log
> 
> Sep 18 01:14:28.803062 (XEN) Xen BUG at spinlock.c:47

Seem to be caused because budget_lock is sometimes locked with irqsave
while others not.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [xen-unstable test] 113562: regressions - FAIL
  2017-09-18  9:45   ` Roger Pau Monné
@ 2017-09-18 10:15     ` George Dunlap
  2017-09-18 10:26       ` Wei Liu
                         ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: George Dunlap @ 2017-09-18 10:15 UTC (permalink / raw)
  To: Roger Pau Monné, Wei Liu
  Cc: George Dunlap, Dario Faggioli, xen-devel, osstest service owner

On 09/18/2017 10:45 AM, Roger Pau Monné wrote:
> On Mon, Sep 18, 2017 at 10:37:58AM +0100, Wei Liu wrote:
>> On Mon, Sep 18, 2017 at 08:36:03AM +0000, osstest service owner wrote:
>>> flight 113562 xen-unstable real [real]
>>> http://logs.test-lab.xenproject.org/osstest/logs/113562/
>>>
>>> Regressions :-(
>>>
>>> Tests which did not succeed and are blocking,
>>> including tests which could not be run:
>>>  test-amd64-amd64-xl-credit2  15 guest-saverestore        fail REGR. vs. 113387
>>
>> There appears to be a bug:
>>
>> http://logs.test-lab.xenproject.org/osstest/logs/113562/test-amd64-amd64-xl-credit2/serial-godello0.log
>>
>> Sep 18 01:14:28.803062 (XEN) Xen BUG at spinlock.c:47
> 
> Seem to be caused because budget_lock is sometimes locked with irqsave
> while others not.

Just wondering where you're getting the budget lock from?  The call
stack in that link makes it look like it's the RCU clean-up triggering a
domain destroy.  (Haven't looked deeper into the specific line numbers.)

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [xen-unstable test] 113562: regressions - FAIL
  2017-09-18 10:15     ` George Dunlap
@ 2017-09-18 10:26       ` Wei Liu
  2017-09-18 10:32         ` George Dunlap
  2017-09-18 10:29       ` George Dunlap
  2017-09-18 10:46       ` Roger Pau Monné
  2 siblings, 1 reply; 14+ messages in thread
From: Wei Liu @ 2017-09-18 10:26 UTC (permalink / raw)
  To: George Dunlap
  Cc: xen-devel, Wei Liu, George Dunlap, Dario Faggioli,
	osstest service owner, Roger Pau Monné

On Mon, Sep 18, 2017 at 11:15:03AM +0100, George Dunlap wrote:
> On 09/18/2017 10:45 AM, Roger Pau Monné wrote:
> > On Mon, Sep 18, 2017 at 10:37:58AM +0100, Wei Liu wrote:
> >> On Mon, Sep 18, 2017 at 08:36:03AM +0000, osstest service owner wrote:
> >>> flight 113562 xen-unstable real [real]
> >>> http://logs.test-lab.xenproject.org/osstest/logs/113562/
> >>>
> >>> Regressions :-(
> >>>
> >>> Tests which did not succeed and are blocking,
> >>> including tests which could not be run:
> >>>  test-amd64-amd64-xl-credit2  15 guest-saverestore        fail REGR. vs. 113387
> >>
> >> There appears to be a bug:
> >>
> >> http://logs.test-lab.xenproject.org/osstest/logs/113562/test-amd64-amd64-xl-credit2/serial-godello0.log
> >>
> >> Sep 18 01:14:28.803062 (XEN) Xen BUG at spinlock.c:47
> > 
> > Seem to be caused because budget_lock is sometimes locked with irqsave
> > while others not.
> 
> Just wondering where you're getting the budget lock from?  The call
> stack in that link makes it look like it's the RCU clean-up triggering a
> domain destroy.  (Haven't looked deeper into the specific line numbers.)
> 

Looking at the backtrace I am not sure yet if budget_lock is the
culprit.

But, Xen does have a requirement to distinguish IRQ-safe lock and
IRQ-unsafe lock. The budget_lock violates that rule.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [xen-unstable test] 113562: regressions - FAIL
  2017-09-18 10:15     ` George Dunlap
  2017-09-18 10:26       ` Wei Liu
@ 2017-09-18 10:29       ` George Dunlap
  2017-09-18 17:36         ` Dario Faggioli
  2017-09-18 10:46       ` Roger Pau Monné
  2 siblings, 1 reply; 14+ messages in thread
From: George Dunlap @ 2017-09-18 10:29 UTC (permalink / raw)
  To: Roger Pau Monné, Wei Liu
  Cc: George Dunlap, Dario Faggioli, xen-devel, osstest service owner

On 09/18/2017 11:15 AM, George Dunlap wrote:
> On 09/18/2017 10:45 AM, Roger Pau Monné wrote:
>> On Mon, Sep 18, 2017 at 10:37:58AM +0100, Wei Liu wrote:
>>> On Mon, Sep 18, 2017 at 08:36:03AM +0000, osstest service owner wrote:
>>>> flight 113562 xen-unstable real [real]
>>>> http://logs.test-lab.xenproject.org/osstest/logs/113562/
>>>>
>>>> Regressions :-(
>>>>
>>>> Tests which did not succeed and are blocking,
>>>> including tests which could not be run:
>>>>  test-amd64-amd64-xl-credit2  15 guest-saverestore        fail REGR. vs. 113387
>>>
>>> There appears to be a bug:
>>>
>>> http://logs.test-lab.xenproject.org/osstest/logs/113562/test-amd64-amd64-xl-credit2/serial-godello0.log
>>>
>>> Sep 18 01:14:28.803062 (XEN) Xen BUG at spinlock.c:47
>>
>> Seem to be caused because budget_lock is sometimes locked with irqsave
>> while others not.
> 
> Just wondering where you're getting the budget lock from?  The call
> stack in that link makes it look like it's the RCU clean-up triggering a
> domain destroy.  (Haven't looked deeper into the specific line numbers.)

In fact in this case it appears to be the xfree(sdom->repl_timer) in
csched2_free_domdata() being inside the critical section (which disables
irqs); there's actually an xfree() right in that function outside the
critical section.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [xen-unstable test] 113562: regressions - FAIL
  2017-09-18 10:26       ` Wei Liu
@ 2017-09-18 10:32         ` George Dunlap
  0 siblings, 0 replies; 14+ messages in thread
From: George Dunlap @ 2017-09-18 10:32 UTC (permalink / raw)
  To: Wei Liu
  Cc: George Dunlap, Dario Faggioli, xen-devel, osstest service owner,
	Roger Pau Monné

On 09/18/2017 11:26 AM, Wei Liu wrote:
> On Mon, Sep 18, 2017 at 11:15:03AM +0100, George Dunlap wrote:
>> On 09/18/2017 10:45 AM, Roger Pau Monné wrote:
>>> On Mon, Sep 18, 2017 at 10:37:58AM +0100, Wei Liu wrote:
>>>> On Mon, Sep 18, 2017 at 08:36:03AM +0000, osstest service owner wrote:
>>>>> flight 113562 xen-unstable real [real]
>>>>> http://logs.test-lab.xenproject.org/osstest/logs/113562/
>>>>>
>>>>> Regressions :-(
>>>>>
>>>>> Tests which did not succeed and are blocking,
>>>>> including tests which could not be run:
>>>>>  test-amd64-amd64-xl-credit2  15 guest-saverestore        fail REGR. vs. 113387
>>>>
>>>> There appears to be a bug:
>>>>
>>>> http://logs.test-lab.xenproject.org/osstest/logs/113562/test-amd64-amd64-xl-credit2/serial-godello0.log
>>>>
>>>> Sep 18 01:14:28.803062 (XEN) Xen BUG at spinlock.c:47
>>>
>>> Seem to be caused because budget_lock is sometimes locked with irqsave
>>> while others not.
>>
>> Just wondering where you're getting the budget lock from?  The call
>> stack in that link makes it look like it's the RCU clean-up triggering a
>> domain destroy.  (Haven't looked deeper into the specific line numbers.)
>>
> 
> Looking at the backtrace I am not sure yet if budget_lock is the
> culprit.
> 
> But, Xen does have a requirement to distinguish IRQ-safe lock and
> IRQ-unsafe lock. The budget_lock violates that rule.

It looks that way at first glance, but actually it doesn't. :-)

All of the calls where the budget lock is grabbed without "_irqsave",
there is an ASSERT() previously that the per-scheduler private lock has
already been grabbed -- which, if true, means that irqs are already
disabled.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [xen-unstable test] 113562: regressions - FAIL
  2017-09-18 10:15     ` George Dunlap
  2017-09-18 10:26       ` Wei Liu
  2017-09-18 10:29       ` George Dunlap
@ 2017-09-18 10:46       ` Roger Pau Monné
  2017-09-18 11:05         ` George Dunlap
  2 siblings, 1 reply; 14+ messages in thread
From: Roger Pau Monné @ 2017-09-18 10:46 UTC (permalink / raw)
  To: George Dunlap
  Cc: George Dunlap, Dario Faggioli, xen-devel, Wei Liu,
	osstest service owner

On Mon, Sep 18, 2017 at 11:15:03AM +0100, George Dunlap wrote:
> On 09/18/2017 10:45 AM, Roger Pau Monné wrote:
> > On Mon, Sep 18, 2017 at 10:37:58AM +0100, Wei Liu wrote:
> >> On Mon, Sep 18, 2017 at 08:36:03AM +0000, osstest service owner wrote:
> >>> flight 113562 xen-unstable real [real]
> >>> http://logs.test-lab.xenproject.org/osstest/logs/113562/
> >>>
> >>> Regressions :-(
> >>>
> >>> Tests which did not succeed and are blocking,
> >>> including tests which could not be run:
> >>>  test-amd64-amd64-xl-credit2  15 guest-saverestore        fail REGR. vs. 113387
> >>
> >> There appears to be a bug:
> >>
> >> http://logs.test-lab.xenproject.org/osstest/logs/113562/test-amd64-amd64-xl-credit2/serial-godello0.log
> >>
> >> Sep 18 01:14:28.803062 (XEN) Xen BUG at spinlock.c:47
> > 
> > Seem to be caused because budget_lock is sometimes locked with irqsave
> > while others not.
> 
> Just wondering where you're getting the budget lock from?  The call
> stack in that link makes it look like it's the RCU clean-up triggering a
> domain destroy.  (Haven't looked deeper into the specific line numbers.)

Just skimmed over the commit and jumped into conclusions too fast. As
you mention later the issue is calling xfree with interrupts disabled
in csched2_free_domdata.

I would rather prefer budget_lock to be always locked with the
irqsave/restore variant to make what you mention above more obvious,
but that's just a question of taste.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [xen-unstable test] 113562: regressions - FAIL
  2017-09-18 10:46       ` Roger Pau Monné
@ 2017-09-18 11:05         ` George Dunlap
  2017-09-18 11:11           ` Juergen Gross
  2017-09-18 11:19           ` Jan Beulich
  0 siblings, 2 replies; 14+ messages in thread
From: George Dunlap @ 2017-09-18 11:05 UTC (permalink / raw)
  To: Roger Pau Monné
  Cc: xen-devel, Wei Liu, George Dunlap, Dario Faggioli,
	osstest service owner, Jan Beulich

On 09/18/2017 11:46 AM, Roger Pau Monné wrote:
> On Mon, Sep 18, 2017 at 11:15:03AM +0100, George Dunlap wrote:
>> On 09/18/2017 10:45 AM, Roger Pau Monné wrote:
>>> On Mon, Sep 18, 2017 at 10:37:58AM +0100, Wei Liu wrote:
>>>> On Mon, Sep 18, 2017 at 08:36:03AM +0000, osstest service owner wrote:
>>>>> flight 113562 xen-unstable real [real]
>>>>> http://logs.test-lab.xenproject.org/osstest/logs/113562/
>>>>>
>>>>> Regressions :-(
>>>>>
>>>>> Tests which did not succeed and are blocking,
>>>>> including tests which could not be run:
>>>>>  test-amd64-amd64-xl-credit2  15 guest-saverestore        fail REGR. vs. 113387
>>>>
>>>> There appears to be a bug:
>>>>
>>>> http://logs.test-lab.xenproject.org/osstest/logs/113562/test-amd64-amd64-xl-credit2/serial-godello0.log
>>>>
>>>> Sep 18 01:14:28.803062 (XEN) Xen BUG at spinlock.c:47
>>>
>>> Seem to be caused because budget_lock is sometimes locked with irqsave
>>> while others not.
>>
>> Just wondering where you're getting the budget lock from?  The call
>> stack in that link makes it look like it's the RCU clean-up triggering a
>> domain destroy.  (Haven't looked deeper into the specific line numbers.)
> 
> Just skimmed over the commit and jumped into conclusions too fast. As
> you mention later the issue is calling xfree with interrupts disabled
> in csched2_free_domdata.
> 
> I would rather prefer budget_lock to be always locked with the
> irqsave/restore variant to make what you mention above more obvious,
> but that's just a question of taste.

I *think* at some point in the past we had a discussion about this and
someone (perhaps Jan?) said if we always know the irqs are disabled we
shouldn't call the _irqsave() version, to save cpu cycles.

Personally I think the ASSERT()s are clear enough to people familiar
with the scheduling code.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [xen-unstable test] 113562: regressions - FAIL
  2017-09-18 11:05         ` George Dunlap
@ 2017-09-18 11:11           ` Juergen Gross
  2017-09-18 13:47             ` George Dunlap
  2017-09-18 14:16             ` Roger Pau Monné
  2017-09-18 11:19           ` Jan Beulich
  1 sibling, 2 replies; 14+ messages in thread
From: Juergen Gross @ 2017-09-18 11:11 UTC (permalink / raw)
  To: George Dunlap, Roger Pau Monné
  Cc: xen-devel, Wei Liu, George Dunlap, Dario Faggioli,
	osstest service owner, Jan Beulich

On 18/09/17 13:05, George Dunlap wrote:
> On 09/18/2017 11:46 AM, Roger Pau Monné wrote:
>> On Mon, Sep 18, 2017 at 11:15:03AM +0100, George Dunlap wrote:
>>> On 09/18/2017 10:45 AM, Roger Pau Monné wrote:
>>>> On Mon, Sep 18, 2017 at 10:37:58AM +0100, Wei Liu wrote:
>>>>> On Mon, Sep 18, 2017 at 08:36:03AM +0000, osstest service owner wrote:
>>>>>> flight 113562 xen-unstable real [real]
>>>>>> http://logs.test-lab.xenproject.org/osstest/logs/113562/
>>>>>>
>>>>>> Regressions :-(
>>>>>>
>>>>>> Tests which did not succeed and are blocking,
>>>>>> including tests which could not be run:
>>>>>>  test-amd64-amd64-xl-credit2  15 guest-saverestore        fail REGR. vs. 113387
>>>>>
>>>>> There appears to be a bug:
>>>>>
>>>>> http://logs.test-lab.xenproject.org/osstest/logs/113562/test-amd64-amd64-xl-credit2/serial-godello0.log
>>>>>
>>>>> Sep 18 01:14:28.803062 (XEN) Xen BUG at spinlock.c:47
>>>>
>>>> Seem to be caused because budget_lock is sometimes locked with irqsave
>>>> while others not.
>>>
>>> Just wondering where you're getting the budget lock from?  The call
>>> stack in that link makes it look like it's the RCU clean-up triggering a
>>> domain destroy.  (Haven't looked deeper into the specific line numbers.)
>>
>> Just skimmed over the commit and jumped into conclusions too fast. As
>> you mention later the issue is calling xfree with interrupts disabled
>> in csched2_free_domdata.
>>
>> I would rather prefer budget_lock to be always locked with the
>> irqsave/restore variant to make what you mention above more obvious,
>> but that's just a question of taste.
> 
> I *think* at some point in the past we had a discussion about this and
> someone (perhaps Jan?) said if we always know the irqs are disabled we
> shouldn't call the _irqsave() version, to save cpu cycles.
> 
> Personally I think the ASSERT()s are clear enough to people familiar
> with the scheduling code.

Why don't we add _irqoff variants of the locks containing the ASSERTion
that interrupts are really off? This would save the additional
instructions of the irqsave/restore variants and make it very clear that
no violation of the lock interface is happening.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [xen-unstable test] 113562: regressions - FAIL
  2017-09-18 11:05         ` George Dunlap
  2017-09-18 11:11           ` Juergen Gross
@ 2017-09-18 11:19           ` Jan Beulich
  1 sibling, 0 replies; 14+ messages in thread
From: Jan Beulich @ 2017-09-18 11:19 UTC (permalink / raw)
  To: George Dunlap
  Cc: xen-devel, Wei Liu, George Dunlap, Dario Faggioli,
	osstest service owner, Roger Pau Monné

>>> On 18.09.17 at 13:05, <george.dunlap@citrix.com> wrote:
> On 09/18/2017 11:46 AM, Roger Pau Monné wrote:
>> On Mon, Sep 18, 2017 at 11:15:03AM +0100, George Dunlap wrote:
>>> On 09/18/2017 10:45 AM, Roger Pau Monné wrote:
>>>> On Mon, Sep 18, 2017 at 10:37:58AM +0100, Wei Liu wrote:
>>>>> On Mon, Sep 18, 2017 at 08:36:03AM +0000, osstest service owner wrote:
>>>>>> flight 113562 xen-unstable real [real]
>>>>>> http://logs.test-lab.xenproject.org/osstest/logs/113562/ 
>>>>>>
>>>>>> Regressions :-(
>>>>>>
>>>>>> Tests which did not succeed and are blocking,
>>>>>> including tests which could not be run:
>>>>>>  test-amd64-amd64-xl-credit2  15 guest-saverestore        fail REGR. vs. 
> 113387
>>>>>
>>>>> There appears to be a bug:
>>>>>
>>>>> 
> http://logs.test-lab.xenproject.org/osstest/logs/113562/test-amd64-amd64-xl-c 
> redit2/serial-godello0.log
>>>>>
>>>>> Sep 18 01:14:28.803062 (XEN) Xen BUG at spinlock.c:47
>>>>
>>>> Seem to be caused because budget_lock is sometimes locked with irqsave
>>>> while others not.
>>>
>>> Just wondering where you're getting the budget lock from?  The call
>>> stack in that link makes it look like it's the RCU clean-up triggering a
>>> domain destroy.  (Haven't looked deeper into the specific line numbers.)
>> 
>> Just skimmed over the commit and jumped into conclusions too fast. As
>> you mention later the issue is calling xfree with interrupts disabled
>> in csched2_free_domdata.
>> 
>> I would rather prefer budget_lock to be always locked with the
>> irqsave/restore variant to make what you mention above more obvious,
>> but that's just a question of taste.
> 
> I *think* at some point in the past we had a discussion about this and
> someone (perhaps Jan?) said if we always know the irqs are disabled we
> shouldn't call the _irqsave() version, to save cpu cycles.

Regardless if it was me back then, I certainly share that position.

> Personally I think the ASSERT()s are clear enough to people familiar
> with the scheduling code.

I agree.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [xen-unstable test] 113562: regressions - FAIL
  2017-09-18 11:11           ` Juergen Gross
@ 2017-09-18 13:47             ` George Dunlap
  2017-09-18 14:16             ` Roger Pau Monné
  1 sibling, 0 replies; 14+ messages in thread
From: George Dunlap @ 2017-09-18 13:47 UTC (permalink / raw)
  To: Juergen Gross, Roger Pau Monné
  Cc: xen-devel, Wei Liu, George Dunlap, Dario Faggioli,
	osstest service owner, Jan Beulich

On 09/18/2017 12:11 PM, Juergen Gross wrote:
> On 18/09/17 13:05, George Dunlap wrote:
>> On 09/18/2017 11:46 AM, Roger Pau Monné wrote:
>>> On Mon, Sep 18, 2017 at 11:15:03AM +0100, George Dunlap wrote:
>>>> On 09/18/2017 10:45 AM, Roger Pau Monné wrote:
>>>>> On Mon, Sep 18, 2017 at 10:37:58AM +0100, Wei Liu wrote:
>>>>>> On Mon, Sep 18, 2017 at 08:36:03AM +0000, osstest service owner wrote:
>>>>>>> flight 113562 xen-unstable real [real]
>>>>>>> http://logs.test-lab.xenproject.org/osstest/logs/113562/
>>>>>>>
>>>>>>> Regressions :-(
>>>>>>>
>>>>>>> Tests which did not succeed and are blocking,
>>>>>>> including tests which could not be run:
>>>>>>>  test-amd64-amd64-xl-credit2  15 guest-saverestore        fail REGR. vs. 113387
>>>>>>
>>>>>> There appears to be a bug:
>>>>>>
>>>>>> http://logs.test-lab.xenproject.org/osstest/logs/113562/test-amd64-amd64-xl-credit2/serial-godello0.log
>>>>>>
>>>>>> Sep 18 01:14:28.803062 (XEN) Xen BUG at spinlock.c:47
>>>>>
>>>>> Seem to be caused because budget_lock is sometimes locked with irqsave
>>>>> while others not.
>>>>
>>>> Just wondering where you're getting the budget lock from?  The call
>>>> stack in that link makes it look like it's the RCU clean-up triggering a
>>>> domain destroy.  (Haven't looked deeper into the specific line numbers.)
>>>
>>> Just skimmed over the commit and jumped into conclusions too fast. As
>>> you mention later the issue is calling xfree with interrupts disabled
>>> in csched2_free_domdata.
>>>
>>> I would rather prefer budget_lock to be always locked with the
>>> irqsave/restore variant to make what you mention above more obvious,
>>> but that's just a question of taste.
>>
>> I *think* at some point in the past we had a discussion about this and
>> someone (perhaps Jan?) said if we always know the irqs are disabled we
>> shouldn't call the _irqsave() version, to save cpu cycles.
>>
>> Personally I think the ASSERT()s are clear enough to people familiar
>> with the scheduling code.
> 
> Why don't we add _irqoff variants of the locks containing the ASSERTion
> that interrupts are really off? This would save the additional
> instructions of the irqsave/restore variants and make it very clear that
> no violation of the lock interface is happening.

I'd be OK with such a patch -- but obviously at this point it would have
to wait for 4.11. :-)

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [xen-unstable test] 113562: regressions - FAIL
  2017-09-18 11:11           ` Juergen Gross
  2017-09-18 13:47             ` George Dunlap
@ 2017-09-18 14:16             ` Roger Pau Monné
  1 sibling, 0 replies; 14+ messages in thread
From: Roger Pau Monné @ 2017-09-18 14:16 UTC (permalink / raw)
  To: Juergen Gross
  Cc: xen-devel, Wei Liu, George Dunlap, Dario Faggioli, George Dunlap,
	osstest service owner, Jan Beulich

On Mon, Sep 18, 2017 at 01:11:07PM +0200, Juergen Gross wrote:
> On 18/09/17 13:05, George Dunlap wrote:
> > On 09/18/2017 11:46 AM, Roger Pau Monné wrote:
> >> On Mon, Sep 18, 2017 at 11:15:03AM +0100, George Dunlap wrote:
> >>> On 09/18/2017 10:45 AM, Roger Pau Monné wrote:
> >>>> On Mon, Sep 18, 2017 at 10:37:58AM +0100, Wei Liu wrote:
> >>>>> On Mon, Sep 18, 2017 at 08:36:03AM +0000, osstest service owner wrote:
> >>>>>> flight 113562 xen-unstable real [real]
> >>>>>> http://logs.test-lab.xenproject.org/osstest/logs/113562/
> >>>>>>
> >>>>>> Regressions :-(
> >>>>>>
> >>>>>> Tests which did not succeed and are blocking,
> >>>>>> including tests which could not be run:
> >>>>>>  test-amd64-amd64-xl-credit2  15 guest-saverestore        fail REGR. vs. 113387
> >>>>>
> >>>>> There appears to be a bug:
> >>>>>
> >>>>> http://logs.test-lab.xenproject.org/osstest/logs/113562/test-amd64-amd64-xl-credit2/serial-godello0.log
> >>>>>
> >>>>> Sep 18 01:14:28.803062 (XEN) Xen BUG at spinlock.c:47
> >>>>
> >>>> Seem to be caused because budget_lock is sometimes locked with irqsave
> >>>> while others not.
> >>>
> >>> Just wondering where you're getting the budget lock from?  The call
> >>> stack in that link makes it look like it's the RCU clean-up triggering a
> >>> domain destroy.  (Haven't looked deeper into the specific line numbers.)
> >>
> >> Just skimmed over the commit and jumped into conclusions too fast. As
> >> you mention later the issue is calling xfree with interrupts disabled
> >> in csched2_free_domdata.
> >>
> >> I would rather prefer budget_lock to be always locked with the
> >> irqsave/restore variant to make what you mention above more obvious,
> >> but that's just a question of taste.
> > 
> > I *think* at some point in the past we had a discussion about this and
> > someone (perhaps Jan?) said if we always know the irqs are disabled we
> > shouldn't call the _irqsave() version, to save cpu cycles.
> > 
> > Personally I think the ASSERT()s are clear enough to people familiar
> > with the scheduling code.
> 
> Why don't we add _irqoff variants of the locks containing the ASSERTion
> that interrupts are really off? This would save the additional
> instructions of the irqsave/restore variants and make it very clear that
> no violation of the lock interface is happening.

+1

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [xen-unstable test] 113562: regressions - FAIL
  2017-09-18 10:29       ` George Dunlap
@ 2017-09-18 17:36         ` Dario Faggioli
  0 siblings, 0 replies; 14+ messages in thread
From: Dario Faggioli @ 2017-09-18 17:36 UTC (permalink / raw)
  To: George Dunlap, Roger Pau Monné, Wei Liu
  Cc: George Dunlap, xen-devel, osstest service owner


[-- Attachment #1.1: Type: text/plain, Size: 1672 bytes --]

On Mon, 2017-09-18 at 11:29 +0100, George Dunlap wrote:
> > > On Mon, Sep 18, 2017 at 10:37:58AM +0100, Wei Liu wrote:
> > > > On Mon, Sep 18, 2017 at 08:36:03AM +0000, osstest service owner
> > > > wrote:
> > > > > flight 113562 xen-unstable real [real]
> > > > > http://logs.test-lab.xenproject.org/osstest/logs/113562/
> > > > > 
> > > > > Regressions :-(
> > > > > 
> > > > > Tests which did not succeed and are blocking,
> > > > > including tests which could not be run:
> > > > >  test-amd64-amd64-xl-credit2  15 guest-
> > > > > saverestore        fail REGR. vs. 113387
> > > > 
> > > > There appears to be a bug:
> > > > 
> > > > http://logs.test-lab.xenproject.org/osstest/logs/113562/test-am
> > > > d64-amd64-xl-credit2/serial-godello0.log
> > > > 
> > > > Sep 18 01:14:28.803062 (XEN) Xen BUG at spinlock.c:47
> > > 
> In fact in this case it appears to be the xfree(sdom->repl_timer) in
> csched2_free_domdata() being inside the critical section (which
> disables
> irqs); there's actually an xfree() right in that function outside the
> critical section.
> 
So, during the afternoon, there was an glitch here, in the local
network/NAS of my home office.

It took me a bit to fix it, and that delayed the work on the (trivial)
patch to fix this problem.

It's solved now, and I will work on and send the patch later (after
dinner).

Sorry again,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2017-09-18 17:36 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-18  8:36 [xen-unstable test] 113562: regressions - FAIL osstest service owner
2017-09-18  9:37 ` Wei Liu
2017-09-18  9:45   ` Roger Pau Monné
2017-09-18 10:15     ` George Dunlap
2017-09-18 10:26       ` Wei Liu
2017-09-18 10:32         ` George Dunlap
2017-09-18 10:29       ` George Dunlap
2017-09-18 17:36         ` Dario Faggioli
2017-09-18 10:46       ` Roger Pau Monné
2017-09-18 11:05         ` George Dunlap
2017-09-18 11:11           ` Juergen Gross
2017-09-18 13:47             ` George Dunlap
2017-09-18 14:16             ` Roger Pau Monné
2017-09-18 11:19           ` Jan Beulich

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.