From: Martin Wilck <mwilck@suse.com>
To: Hannes Reinecke <hare@suse.de>,
Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: dm-devel@redhat.com, Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH] libmultipath: sanitize fd handling
Date: Wed, 20 Sep 2017 22:24:41 +0200 [thread overview]
Message-ID: <1505939081.11310.3.camel@suse.com> (raw)
In-Reply-To: <1505907169.4256.7.camel@suse.com>
On Wed, 2017-09-20 at 13:32 +0200, Martin Wilck wrote:
> On Fri, 2017-09-15 at 08:15 +0200, Hannes Reinecke wrote:
> >
> > Signed-off-by: Hannes Reinecke <hare@suse.com>
> > ---
> > libmultipath/checkers.c | 4 ++--
> > libmultipath/print.c | 2 +-
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
>
> There's one more wrong fd reference in
> libmultipath/checkers/cciss_tur.c:76. And a nitpick: The comment in
> checkers.h:14 should be fixed as well.
>
> Apart from that: nice (although not strictly necessary, as multipathd
> currently runs with fd 0 connected to /dev/null under normal
> conditions).
>
I overlooked the memset usage in my review. Hannes himself brought that
to my attention. Will send fixup patch in a minute.
Martin
--
Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
prev parent reply other threads:[~2017-09-20 20:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 6:15 [PATCH] libmultipath: sanitize fd handling Hannes Reinecke
2017-09-20 11:32 ` Martin Wilck
2017-09-20 20:24 ` Martin Wilck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505939081.11310.3.camel@suse.com \
--to=mwilck@suse.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.