From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: "Wang, Zhi A" <zhi.a.wang@intel.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
Joe Perches <joe@perches.com>
Cc: "Gao, Fred" <fred.gao@intel.com>, David Airlie <airlied@linux.ie>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jani Nikula <jani.nikula@linux.intel.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
Colin King <colin.king@canonical.com>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>
Subject: Re: [PATCH][drm-next] drm/i915/gvt: ensure -ve return value is handled correctly
Date: Mon, 25 Sep 2017 09:32:24 +0000 [thread overview]
Message-ID: <1506331944.5593.10.camel@linux.intel.com> (raw)
In-Reply-To: <F3B0350DF4CB6849A642218320DE483D7D643090@SHSMSX101.ccr.corp.intel.com>
On Fri, 2017-09-22 at 17:50 +0000, Wang, Zhi A wrote:
> Thanks for the reply. Learned a lot. :)
>
> GEM_BUG_ON is new to me since it wasn't there at the beginning of
> GVT-g upstream. It showed up later. So I left a lot of WARN_ON in the
> code and some of them should be GEM_BUG_ON now.
>
> Now I can figure out those differences. We can discuss with our QA to
> see if they would like to enable I915_GEM_DEBUG and then we can move
> to GEM_BUG_ON also, or maybe we can have a dedicated GVT_BUG_ON. :)
> Thank you so much. Have a great weekend.
GVT_BUG_ON is probably the way to go :)
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
WARNING: multiple messages have this Message-ID (diff)
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: "Wang, Zhi A" <zhi.a.wang@intel.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
Joe Perches <joe@perches.com>
Cc: "Gao, Fred" <fred.gao@intel.com>, David Airlie <airlied@linux.ie>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jani Nikula <jani.nikula@linux.intel.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
Colin King <colin.king@canonical.com>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>
Subject: Re: [PATCH][drm-next] drm/i915/gvt: ensure -ve return value is handled correctly
Date: Mon, 25 Sep 2017 12:32:24 +0300 [thread overview]
Message-ID: <1506331944.5593.10.camel@linux.intel.com> (raw)
In-Reply-To: <F3B0350DF4CB6849A642218320DE483D7D643090@SHSMSX101.ccr.corp.intel.com>
On Fri, 2017-09-22 at 17:50 +0000, Wang, Zhi A wrote:
> Thanks for the reply. Learned a lot. :)
>
> GEM_BUG_ON is new to me since it wasn't there at the beginning of
> GVT-g upstream. It showed up later. So I left a lot of WARN_ON in the
> code and some of them should be GEM_BUG_ON now.
>
> Now I can figure out those differences. We can discuss with our QA to
> see if they would like to enable I915_GEM_DEBUG and then we can move
> to GEM_BUG_ON also, or maybe we can have a dedicated GVT_BUG_ON. :)
> Thank you so much. Have a great weekend.
GVT_BUG_ON is probably the way to go :)
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
next prev parent reply other threads:[~2017-09-25 9:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 15:55 [PATCH][drm-next] drm/i915/gvt: ensure -ve return value is handled correctly Colin King
2017-09-19 15:55 ` Colin King
2017-09-19 15:55 ` Colin King
2017-09-19 20:05 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-09-19 21:46 ` [PATCH][drm-next] " Zhenyu Wang
2017-09-19 21:46 ` Zhenyu Wang
2017-09-19 21:46 ` Zhenyu Wang
2017-09-20 2:35 ` Joe Perches
2017-09-20 2:35 ` Joe Perches
2017-09-20 2:35 ` Joe Perches
2017-09-20 22:44 ` Zhenyu Wang
2017-09-20 22:44 ` Zhenyu Wang
2017-09-20 22:44 ` Zhenyu Wang
2017-09-21 14:31 ` Joonas Lahtinen
2017-09-21 14:31 ` Joonas Lahtinen
2017-09-21 14:31 ` Joonas Lahtinen
2017-09-21 16:17 ` Wang, Zhi A
2017-09-21 16:17 ` Wang, Zhi A
2017-09-21 16:17 ` Wang, Zhi A
2017-09-22 11:11 ` Joonas Lahtinen
2017-09-22 11:11 ` Joonas Lahtinen
2017-09-22 11:11 ` Joonas Lahtinen
2017-09-22 17:50 ` Wang, Zhi A
2017-09-22 17:50 ` Wang, Zhi A
2017-09-22 17:50 ` Wang, Zhi A
2017-09-25 9:32 ` Joonas Lahtinen [this message]
2017-09-25 9:32 ` Joonas Lahtinen
2017-09-19 23:24 ` ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506331944.5593.10.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=airlied@linux.ie \
--cc=colin.king@canonical.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fred.gao@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.