All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH RESEND] wireless: iwlwifi: fix minor code style issues
@ 2017-09-25 11:37 Christoph Böhmwalder
  2017-09-25 11:47   ` Coelho, Luciano
  0 siblings, 1 reply; 4+ messages in thread
From: Christoph Böhmwalder @ 2017-09-25 11:37 UTC (permalink / raw)
  To: johannes.berg, emmanuel.grumbach, luciano.coelho, kvalo,
	linux-wireless, netdev, linux-kernel, trivial
  Cc: Christoph Böhmwalder


[-- Attachment #1.1: Type: text/plain, Size: 1716 bytes --]

Fixes three trivial issues as reported by checkpatch.pl, namely two
switch/case indentation issues and one alignment issue in a multiline
comment.

Signed-off-by: Christoph Böhmwalder <christoph@boehmwalder.at>
---
 drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
index 99676d6c4713..ccdb247d68c5 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
@@ -832,7 +832,7 @@ static int iwl_parse_tlv_firmware(struct iwl_drv *drv,
 			capa->standard_phy_calibration_size =
 					le32_to_cpup((__le32 *)tlv_data);
 			break;
-		 case IWL_UCODE_TLV_SEC_RT:
+		case IWL_UCODE_TLV_SEC_RT:
 			iwl_store_ucode_sec(pieces, tlv_data, IWL_UCODE_REGULAR,
 					    tlv_len);
 			drv->fw.type = IWL_FW_MVM;
@@ -864,7 +864,7 @@ static int iwl_parse_tlv_firmware(struct iwl_drv *drv,
 						FW_PHY_CFG_RX_CHAIN) >>
 						FW_PHY_CFG_RX_CHAIN_POS;
 			break;
-		 case IWL_UCODE_TLV_SECURE_SEC_RT:
+		case IWL_UCODE_TLV_SECURE_SEC_RT:
 			iwl_store_ucode_sec(pieces, tlv_data, IWL_UCODE_REGULAR,
 					    tlv_len);
 			drv->fw.type = IWL_FW_MVM;
@@ -1335,7 +1335,8 @@ static void iwl_req_fw_callback(const struct
firmware *ucode_raw, void *context)
  	/* Runtime instructions and 2 copies of data:
 	 * 1) unmodified from disk
-	 * 2) backup cache for save/restore during power-downs */
+	 * 2) backup cache for save/restore during power-downs
+	 */
 	for (i = 0; i < IWL_UCODE_TYPE_MAX; i++)
 		if (iwl_alloc_ucode(drv, pieces, i))
 			goto out_free_fw;
-- 
2.13.5



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH RESEND] wireless: iwlwifi: fix minor code style issues
  2017-09-25 11:37 [PATCH RESEND] wireless: iwlwifi: fix minor code style issues Christoph Böhmwalder
@ 2017-09-25 11:47   ` Coelho, Luciano
  0 siblings, 0 replies; 4+ messages in thread
From: Coelho, Luciano @ 2017-09-25 11:47 UTC (permalink / raw)
  To: linux-kernel@vger.kernel.org, trivial@kernel.org,
	christoph@boehmwalder.at, Berg, Johannes, kvalo@codeaurora.org,
	netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
	Grumbach, Emmanuel

T24gTW9uLCAyMDE3LTA5LTI1IGF0IDEzOjM3ICswMjAwLCBDaHJpc3RvcGggQsO2aG13YWxkZXIg
d3JvdGU6DQo+IEZpeGVzIHRocmVlIHRyaXZpYWwgaXNzdWVzIGFzIHJlcG9ydGVkIGJ5IGNoZWNr
cGF0Y2gucGwsIG5hbWVseSB0d28NCnN3aXRjaC9jYXNlIGluZGVudGF0aW9uIGlzc3VlcyBhbmQg
b25lIGFsaWdubWVudCBpc3N1ZSBpbiBhIG11bHRpbGluZQ0KY29tbWVudC4NCg0KU2lnbmVkLW9m
Zi1ieTogQ2hyaXN0b3BoIELDtmhtd2FsZGVyIDxjaHJpc3RvcGhAYm9laG13YWxkZXIuYXQ+DQot
LS0NCg0KV2h5IGFyZSB5b3UgYWxyZWFkeSByZXNlbmRpbmcgdGhpcz8gWW91IHNlbnQgdGhlIGZp
cnN0IGVtYWlsIDIgZGF5cyBhZ28sDQp5b3UgY2FuJ3QgZXhwZWN0IHRoYXQgYSBub24tY3JpdGlj
YWwgcGF0Y2ggYmUgbWVyZ2VkIGluIHN1Y2ggYSBzaG9ydA0KdGltZSAoZXNwZWNpYWxseSBkdXJp
bmcgdGhlIHdlZWtlbmQpLg0KDQotLQ0KQ2hlZXJzLA0KTHVjYQ==

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH RESEND] wireless: iwlwifi: fix minor code style issues
@ 2017-09-25 11:47   ` Coelho, Luciano
  0 siblings, 0 replies; 4+ messages in thread
From: Coelho, Luciano @ 2017-09-25 11:47 UTC (permalink / raw)
  To: linux-kernel@vger.kernel.org, trivial@kernel.org,
	christoph@boehmwalder.at, Berg, Johannes, kvalo@codeaurora.org,
	netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
	Grumbach, Emmanuel

On Mon, 2017-09-25 at 13:37 +0200, Christoph Böhmwalder wrote:
> Fixes three trivial issues as reported by checkpatch.pl, namely two
switch/case indentation issues and one alignment issue in a multiline
comment.

Signed-off-by: Christoph Böhmwalder <christoph@boehmwalder.at>
---

Why are you already resending this? You sent the first email 2 days ago,
you can't expect that a non-critical patch be merged in such a short
time (especially during the weekend).

--
Cheers,
Luca

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH RESEND] wireless: iwlwifi: fix minor code style issues
  2017-09-25 11:47   ` Coelho, Luciano
  (?)
@ 2017-09-25 11:51   ` Christoph Böhmwalder
  -1 siblings, 0 replies; 4+ messages in thread
From: Christoph Böhmwalder @ 2017-09-25 11:51 UTC (permalink / raw)
  To: Coelho, Luciano, linux-kernel@vger.kernel.org, trivial@kernel.org,
	Berg, Johannes, kvalo@codeaurora.org, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org, Grumbach, Emmanuel


[-- Attachment #1.1: Type: text/plain, Size: 306 bytes --]

> Why are you already resending this?

Sorry, I guess I was too impatient. I also messed up the spelling in a
"To:" line and forgot trivial@kernel.org the first time I sent it, so I
figured I'd just fix it in a resend.

I'll make sure to wait a little longer next time.

--
Regards,
Christoph


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-09-25 11:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-25 11:37 [PATCH RESEND] wireless: iwlwifi: fix minor code style issues Christoph Böhmwalder
2017-09-25 11:47 ` Coelho, Luciano
2017-09-25 11:47   ` Coelho, Luciano
2017-09-25 11:51   ` Christoph Böhmwalder

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.