From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "ming.lei@redhat.com" <ming.lei@redhat.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"jthumshirn@suse.de" <jthumshirn@suse.de>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"hch@lst.de" <hch@lst.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
"hare@suse.com" <hare@suse.com>,
"shli@kernel.org" <shli@kernel.org>
Subject: Re: [PATCH v4 1/7] md: Make md resync and reshape threads freezable
Date: Tue, 26 Sep 2017 14:40:36 +0000 [thread overview]
Message-ID: <1506436834.3787.22.camel@wdc.com> (raw)
In-Reply-To: <20170926081309.GA518@ming.t460p>
T24gVHVlLCAyMDE3LTA5LTI2IGF0IDE2OjEzICswODAwLCBNaW5nIExlaSB3cm90ZToNCj4gSSBh
bSBwcmV0dHkgc3VyZSB0aGF0IHN1c3BlbmQvcmVzdW1lIGNhbiBzdXJ2aXZlIHdoZW4gcmVzeW5j
IGluIHByb2dyZXNzDQo+IHdpdGggbXkgcGF0Y2hzZXQgYXBwbGllZCBvbiBSQUlEMSwgd2l0aG91
dCBhbnkgTUQgY2hhbmdlLg0KDQpUaGUgYWJvdmUgc2hvd3MgdGhhdCB5b3UgZG8gbm90IHVuZGVy
c3RhbmQgaG93IHN1c3BlbmQgYW5kIHJlc3VtZSB3b3Jrcy4NCkluIHRoZSBkb2N1bWVudHMgaW4g
dGhlIGRpcmVjdG9yeSBEb2N1bWVudGF0aW9uL3Bvd2VyIGl0IGlzIGV4cGxhaW5lZCBjbGVhcmx5
DQp0aGF0IEkvTyBtdXN0IGJlIHN0b3BwZWQgYmVmb3JlIHRoZSBoaWJlcm5hdGlvbiBpbWFnZSBp
cyBnZW5lcmF0aW9uIHRvIGF2b2lkDQpoYXJkIHRvIHJlcGFpciBmaWxlc3lzdGVtIGNvcnJ1cHRp
b24uIEFsdGhvdWdoIG1kIGlzIG5vdCBhIGZpbGVzeXN0ZW0gSSB0aGluaw0KdGhpcyBhbHNvIGFw
cGxpZXMgdG8gbWQgc2luY2UgbWQga2VlcHMgc29tZSBzdGF0ZSBpbmZvcm1hdGlvbiBpbiBSQU0g
YW5kIHNvbWUNCnN0YXRlIGluZm9ybWF0aW9uIG9uIGRpc2suIEl0IGlzIGVzc2VudGlhbCB0aGF0
IGFsbCB0aGF0IHN0YXRlIGluZm9ybWF0aW9uIGlzDQppbiBjb25zaXN0ZW50Lg0KDQo+IElmIHlv
dXIgcGF0Y2hzZXQgZGVwZW5kcyBvbiB0aGlzIE1EIGNoYW5nZSwgc29tZXRoaW5nIHNob3VsZCBi
ZSB3cm9uZw0KPiBpbiB0aGUgZm9sbG93aW5nIHBhdGNoZXMuIE5vdyBJIG5lZWQgdG8gdGFrZSBh
IGNsb3NlIGxvb2suDQoNClRoZSBsYXRlciBwYXRjaGVzIHRoYXQgbWFrZSBTQ1NJIHF1aWVzY2Ug
YW5kIHJlc3VtZSBzYWZlIGRvIG5vdCBkZXBlbmQgb24NCnRoaXMgY2hhbmdlLg0KDQpCYXJ0Lg==
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "ming.lei@redhat.com" <ming.lei@redhat.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"jthumshirn@suse.de" <jthumshirn@suse.de>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"hch@lst.de" <hch@lst.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
"hare@suse.com" <hare@suse.com>,
"shli@kernel.org" <shli@kernel.org>
Subject: Re: [PATCH v4 1/7] md: Make md resync and reshape threads freezable
Date: Tue, 26 Sep 2017 14:40:36 +0000 [thread overview]
Message-ID: <1506436834.3787.22.camel@wdc.com> (raw)
In-Reply-To: <20170926081309.GA518@ming.t460p>
On Tue, 2017-09-26 at 16:13 +0800, Ming Lei wrote:
> I am pretty sure that suspend/resume can survive when resync in progress
> with my patchset applied on RAID1, without any MD change.
The above shows that you do not understand how suspend and resume works.
In the documents in the directory Documentation/power it is explained clearly
that I/O must be stopped before the hibernation image is generation to avoid
hard to repair filesystem corruption. Although md is not a filesystem I think
this also applies to md since md keeps some state information in RAM and some
state information on disk. It is essential that all that state information is
in consistent.
> If your patchset depends on this MD change, something should be wrong
> in the following patches. Now I need to take a close look.
The later patches that make SCSI quiesce and resume safe do not depend on
this change.
Bart.
next prev parent reply other threads:[~2017-09-26 14:40 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 20:29 [PATCH v4 0/7] Make suspend and resume safe for md-on-SCSI Bart Van Assche
2017-09-25 20:29 ` [PATCH v4 1/7] md: Make md resync and reshape threads freezable Bart Van Assche
2017-09-25 23:04 ` Ming Lei
2017-09-25 23:09 ` Bart Van Assche
2017-09-25 23:09 ` Bart Van Assche
2017-09-26 4:01 ` Ming Lei
2017-09-26 8:13 ` Ming Lei
2017-09-26 14:40 ` Bart Van Assche [this message]
2017-09-26 14:40 ` Bart Van Assche
2017-09-26 15:02 ` Ming Lei
2017-09-26 6:06 ` Hannes Reinecke
2017-09-26 11:17 ` Ming Lei
2017-09-26 14:42 ` Bart Van Assche
2017-09-26 14:42 ` Bart Van Assche
2017-09-26 14:59 ` Ming Lei
2017-09-27 3:12 ` Bart Van Assche
2017-09-27 3:12 ` Bart Van Assche
2017-09-27 11:00 ` Ming Lei
2017-10-02 15:39 ` Bart Van Assche
2017-10-02 15:39 ` Bart Van Assche
2017-10-02 13:26 ` Christoph Hellwig
2017-09-25 20:29 ` [PATCH v4 2/7] block: Make q_usage_counter also track legacy requests Bart Van Assche
2017-09-26 6:05 ` Hannes Reinecke
2017-09-26 8:34 ` Ming Lei
2017-10-02 13:29 ` Christoph Hellwig
2017-09-25 20:29 ` [PATCH v4 3/7] block: Convert RQF_PREEMPT into REQ_PREEMPT Bart Van Assche
2017-10-02 13:42 ` Christoph Hellwig
2017-10-02 13:43 ` Christoph Hellwig
2017-09-25 20:29 ` [PATCH v4 4/7] block: Add the QUEUE_FLAG_PREEMPT_ONLY request queue flag Bart Van Assche
2017-10-02 13:47 ` Christoph Hellwig
2017-10-02 15:56 ` Bart Van Assche
2017-10-02 16:14 ` hch
2017-09-25 20:29 ` [PATCH v4 5/7] scsi: Reduce suspend latency Bart Van Assche
2017-09-26 22:23 ` Ming Lei
2017-09-27 3:43 ` Bart Van Assche
2017-09-27 5:37 ` Ming Lei
2017-09-25 20:29 ` [PATCH v4 6/7] scsi: Set QUEUE_FLAG_PREEMPT_ONLY while quiesced Bart Van Assche
2017-10-02 13:53 ` Christoph Hellwig
2017-09-25 20:29 ` [PATCH v4 7/7] block: Make SCSI device suspend and resume work reliably Bart Van Assche
2017-09-25 22:59 ` Ming Lei
2017-09-25 23:13 ` Bart Van Assche
2017-09-26 8:32 ` Ming Lei
2017-09-26 14:44 ` Bart Van Assche
2017-09-26 9:15 ` [PATCH v4 0/7] Make suspend and resume safe for md-on-SCSI Ming Lei
2017-09-26 14:29 ` Bart Van Assche
2017-09-26 14:54 ` Ming Lei
2017-09-26 20:17 ` Bart Van Assche
2017-09-26 22:47 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506436834.3787.22.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=oleksandr@natalenko.name \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.