From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: "Wei Hu (Xavier)" <xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
lijun_nudt-9Onoh4P/yGk@public.gmane.org,
oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
charles.chenxin-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
liuyixian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
xushaobo2-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
zhangxiping3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
shaobohsu-9Onoh4P/yGk@public.gmane.org
Subject: Re: [PATCH V2 for-next 3/8] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp
Date: Fri, 29 Sep 2017 11:54:01 -0400 [thread overview]
Message-ID: <1506700441.2919.25.camel@redhat.com> (raw)
In-Reply-To: <1506697814-98432-4-git-send-email-xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On Fri, 2017-09-29 at 23:10 +0800, Wei Hu (Xavier) wrote:
> When lp_qp_work is NULL, it should be returned ENOMEM. This patch
> mainly adds the error checking branch, modifies the return value of
> the function named hns_roce_v1_set_mac that calling
> hns_roce_v1_recreate_lp_qp.
>
> Ihis patch fixes the smatch error as below:
^^^^
Typo, but I can fix it, no need to respin.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Doug Ledford <dledford@redhat.com>
To: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
Cc: linux-rdma@vger.kernel.org, lijun_nudt@163.com,
oulijun@huawei.com, charles.chenxin@huawei.com,
liuyixian@huawei.com, xushaobo2@huawei.com,
zhangxiping3@huawei.com, linuxarm@huawei.com,
linux-kernel@vger.kernel.org, shaobohsu@163.com
Subject: Re: [PATCH V2 for-next 3/8] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp
Date: Fri, 29 Sep 2017 11:54:01 -0400 [thread overview]
Message-ID: <1506700441.2919.25.camel@redhat.com> (raw)
In-Reply-To: <1506697814-98432-4-git-send-email-xavier.huwei@huawei.com>
On Fri, 2017-09-29 at 23:10 +0800, Wei Hu (Xavier) wrote:
> When lp_qp_work is NULL, it should be returned ENOMEM. This patch
> mainly adds the error checking branch, modifies the return value of
> the function named hns_roce_v1_set_mac that calling
> hns_roce_v1_recreate_lp_qp.
>
> Ihis patch fixes the smatch error as below:
^^^^
Typo, but I can fix it, no need to respin.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
next prev parent reply other threads:[~2017-09-29 15:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 15:10 [PATCH V2 for-next 0/8] Bug fixes & Code improvements in hip06 and hip08 RoCE driver Wei Hu (Xavier)
2017-09-29 15:10 ` Wei Hu (Xavier)
2017-09-29 15:10 ` [PATCH V2 for-next 1/8] RDMA/hns: Modify the value with rd&dest_rd of qp_attr Wei Hu (Xavier)
2017-09-29 15:10 ` Wei Hu (Xavier)
[not found] ` <1506697814-98432-1-git-send-email-xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-09-29 15:10 ` [PATCH V2 for-next 2/8] RDMA/hns: Factor out the code for checking sdb status into a new function Wei Hu (Xavier)
2017-09-29 15:10 ` Wei Hu (Xavier)
2017-09-29 15:10 ` [PATCH V2 for-next 6/8] RDMA/hns: Add return statement when checking error in hns_roce_v1_mr_free_work_fn Wei Hu (Xavier)
2017-09-29 15:10 ` Wei Hu (Xavier)
2017-09-29 15:10 ` [PATCH V2 for-next 3/8] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp Wei Hu (Xavier)
2017-09-29 15:10 ` Wei Hu (Xavier)
[not found] ` <1506697814-98432-4-git-send-email-xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-09-29 15:54 ` Doug Ledford [this message]
2017-09-29 15:54 ` Doug Ledford
2017-09-29 15:10 ` [PATCH V2 for-next 4/8] RDMA/hns: Set mask for destination qp field of qp context assignment Wei Hu (Xavier)
2017-09-29 15:10 ` Wei Hu (Xavier)
2017-09-29 16:05 ` Doug Ledford
2017-09-29 15:10 ` [PATCH V2 for-next 5/8] RDMA/hns: Set rdma_ah_attr type for querying qp Wei Hu (Xavier)
2017-09-29 15:10 ` Wei Hu (Xavier)
2017-09-29 15:10 ` [PATCH V2 for-next 7/8] RDMA/hns: Remove unnecessarily calling unregister_inetaddr_notifier function Wei Hu (Xavier)
2017-09-29 15:10 ` Wei Hu (Xavier)
2017-09-29 15:10 ` [PATCH V2 for-next 8/8] RDMA/hns: Replace usleep_range with udelay when checking command status Wei Hu (Xavier)
2017-09-29 15:10 ` Wei Hu (Xavier)
2017-09-29 16:22 ` [PATCH V2 for-next 0/8] Bug fixes & Code improvements in hip06 and hip08 RoCE driver Doug Ledford
[not found] ` <1506702175.2919.28.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-09-30 2:11 ` Wei Hu (Xavier)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506700441.2919.25.camel@redhat.com \
--to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=charles.chenxin-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=lijun_nudt-9Onoh4P/yGk@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=liuyixian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=shaobohsu-9Onoh4P/yGk@public.gmane.org \
--cc=xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=xushaobo2-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=zhangxiping3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.