diff for duplicates of <1506901362.5691.247.camel@linux.vnet.ibm.com> diff --git a/a/1.txt b/N1/1.txt index 5822921..f1db9e8 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -28,8 +28,8 @@ On Mon, 2017-10-02 at 09:34 +1100, Dave Chinner wrote: > ATM). Recently I received a patch to replace i_version with mtime/atime. - Now, even more recently, I received a patch that claims that -i_version is just a performance improvement. For file systems that +?Now, even more recently, I received a patch that claims that +i_version is just a performance improvement. ?For file systems that don't support i_version, assume that the file has changed. For file systems that don't support i_version, instead of assuming @@ -51,15 +51,20 @@ With Linus' suggested changes, I think this will work nicely. The security.ima xattr is normally written out in ima_check_last_writer(), not in ima_collect_measurement(). - ima_collect_measurement() calculates the file hash for storing in the +?ima_collect_measurement() calculates the file hash for storing in the measurement list (IMA-measurement), verifying the hash/signature (IMA- appraisal) already stored in the xattr, and auditing (IMA-audit). The only time that ima_collect_measurement() writes the file xattr is -in "fix" mode. Writing the xattr will need to be deferred until after +in "fix" mode. ?Writing the xattr will need to be deferred until after the iint->mutex is released. There should be no open writers in ima_check_last_writer(), so the file shouldn't be changing. Mimi + +-- +To unsubscribe from this list: send the line "unsubscribe linux-security-module" in +the body of a message to majordomo at vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index f1fa747..546abdf 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -9,20 +9,10 @@ "ref\01506859691.5691.211.camel@linux.vnet.ibm.com\0" "ref\0CA+55aFwG65-1DZGLkxWzXiPHECjVvY+WHa0ihRq6MbJ4yrX-Sg@mail.gmail.com\0" "ref\020171001223402.GG15067@dastard\0" - "From\0Mimi Zohar <zohar@linux.vnet.ibm.com>\0" - "Subject\0Re: [RFC PATCH 3/3] fs: detect that the i_rwsem has already been taken exclusively\0" + "From\0zohar@linux.vnet.ibm.com (Mimi Zohar)\0" + "Subject\0[RFC PATCH 3/3] fs: detect that the i_rwsem has already been taken exclusively\0" "Date\0Sun, 01 Oct 2017 19:42:42 -0400\0" - "To\0Dave Chinner <david@fromorbit.com>" - " Linus Torvalds <torvalds@linux-foundation.org>\0" - "Cc\0Eric W. Biederman <ebiederm@xmission.com>" - LSM List <linux-security-module@vger.kernel.org> - linux-fsdevel <linux-fsdevel@vger.kernel.org> - Christoph Hellwig <hch@infradead.org> - Theodore Ts'o <tytso@mit.edu> - Jan Kara <jack@suse.cz> - Linux Kernel Mailing List <linux-kernel@vger.kernel.org> - linux-integrity@vger.kernel.org - " Sascha Hauer <s.hauer@pengutronix.de>\0" + "To\0linux-security-module@vger.kernel.org\0" "\00:1\0" "b\0" "On Mon, 2017-10-02 at 09:34 +1100, Dave Chinner wrote:\n" @@ -55,8 +45,8 @@ "> ATM).\n" "\n" "Recently I received a patch to replace i_version with mtime/atime.\n" - " Now, even more recently, I received a patch that claims that\n" - "i_version is just a performance improvement. For file systems that\n" + "?Now, even more recently, I received a patch that claims that\n" + "i_version is just a performance improvement. ?For file systems that\n" "don't support i_version, assume that the file has changed.\n" "\n" "For file systems that don't support i_version, instead of assuming\n" @@ -78,17 +68,22 @@ "\n" "The security.ima xattr is normally written out in\n" "ima_check_last_writer(), not in ima_collect_measurement().\n" - " ima_collect_measurement() calculates the file hash for storing in the\n" + "?ima_collect_measurement() calculates the file hash for storing in the\n" "measurement list (IMA-measurement), verifying the hash/signature (IMA-\n" "appraisal) already stored in the xattr, and auditing (IMA-audit).\n" "\n" "The only time that ima_collect_measurement() writes the file xattr is\n" - "in \"fix\" mode. Writing the xattr will need to be deferred until after\n" + "in \"fix\" mode. ?Writing the xattr will need to be deferred until after\n" "the iint->mutex is released.\n" "\n" "There should be no open writers in ima_check_last_writer(), so the\n" "file shouldn't be changing.\n" "\n" - Mimi + "Mimi\n" + "\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-security-module\" in\n" + "the body of a message to majordomo at vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -470021638877d114570d69d4b86fa1b5310d9c32de8720dfcbd054aedc76395a +1108d3dbe87e72f9d8adaa86172ce15d5b0f5e11dcae35db750675e1a4d559fb
diff --git a/a/1.txt b/N2/1.txt index 5822921..de69eb9 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -28,8 +28,8 @@ On Mon, 2017-10-02 at 09:34 +1100, Dave Chinner wrote: > ATM). Recently I received a patch to replace i_version with mtime/atime. - Now, even more recently, I received a patch that claims that -i_version is just a performance improvement. For file systems that + Now, even more recently, I received a patch that claims that +i_version is just a performance improvement. For file systems that don't support i_version, assume that the file has changed. For file systems that don't support i_version, instead of assuming @@ -51,12 +51,12 @@ With Linus' suggested changes, I think this will work nicely. The security.ima xattr is normally written out in ima_check_last_writer(), not in ima_collect_measurement(). - ima_collect_measurement() calculates the file hash for storing in the + ima_collect_measurement() calculates the file hash for storing in the measurement list (IMA-measurement), verifying the hash/signature (IMA- appraisal) already stored in the xattr, and auditing (IMA-audit). The only time that ima_collect_measurement() writes the file xattr is -in "fix" mode. Writing the xattr will need to be deferred until after +in "fix" mode. Writing the xattr will need to be deferred until after the iint->mutex is released. There should be no open writers in ima_check_last_writer(), so the diff --git a/a/content_digest b/N2/content_digest index f1fa747..fdd2b11 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -55,8 +55,8 @@ "> ATM).\n" "\n" "Recently I received a patch to replace i_version with mtime/atime.\n" - " Now, even more recently, I received a patch that claims that\n" - "i_version is just a performance improvement. For file systems that\n" + "\302\240Now, even more recently, I received a patch that claims that\n" + "i_version is just a performance improvement. \302\240For file systems that\n" "don't support i_version, assume that the file has changed.\n" "\n" "For file systems that don't support i_version, instead of assuming\n" @@ -78,12 +78,12 @@ "\n" "The security.ima xattr is normally written out in\n" "ima_check_last_writer(), not in ima_collect_measurement().\n" - " ima_collect_measurement() calculates the file hash for storing in the\n" + "\302\240ima_collect_measurement() calculates the file hash for storing in the\n" "measurement list (IMA-measurement), verifying the hash/signature (IMA-\n" "appraisal) already stored in the xattr, and auditing (IMA-audit).\n" "\n" "The only time that ima_collect_measurement() writes the file xattr is\n" - "in \"fix\" mode. Writing the xattr will need to be deferred until after\n" + "in \"fix\" mode. \302\240Writing the xattr will need to be deferred until after\n" "the iint->mutex is released.\n" "\n" "There should be no open writers in ima_check_last_writer(), so the\n" @@ -91,4 +91,4 @@ "\n" Mimi -470021638877d114570d69d4b86fa1b5310d9c32de8720dfcbd054aedc76395a +91a5ef7457d88f6b0be68c38a6154a8ec078bd6de299f1f6678790f2306dbb1b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.