[PATCH] bitbake.conf: Add sdl-config to HOSTTOOLS

[PATCH] bitbake.conf: Add sdl-config to HOSTTOOLS

[Ricardo Ribalda Delgado]

Without this patch bitbake cannot find sdl-config

ERROR:  OE-core's config sanity checker detected a potential misconfiguration.
Either fix the cause of this error or at your own risk disable the checker (see sanity.conf).
Following is the list of potential problems / advisories:

libsdl-native is set to be ASSUME_PROVIDED but sdl-config can't be found in PATH. Please either install it, or configure qemu not to require sdl.

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 meta/conf/bitbake.conf | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 2dac3a1481eb..ebd758d1d904 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -471,6 +471,9 @@ HOSTTOOLS += " \
 # Tools needed to run testimage runtime image testing
 HOSTTOOLS += "ip ping ps scp ssh stty"
 
+# Link to sdl-config if using host SDL
+HOSTTOOLS += "${@bb.utils.contains('ASSUME_PROVIDED', 'libsdl-native', 'sdl-config', '', d)}"
+
 # Link to these if present
 HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo"
 
-- 
2.14.2

Re: [PATCH] bitbake.conf: Add sdl-config to HOSTTOOLS

[Burton, Ross]

On 3 October 2017 at 10:40, Ricardo Ribalda Delgado <
ricardo.ribalda@gmail.com> wrote:

> Without this patch bitbake cannot find sdl-config
>
> ERROR:  OE-core's config sanity checker detected a potential
> misconfiguration.
> Either fix the cause of this error or at your own risk disable the checker
> (see sanity.conf).
> Following is the list of potential problems / advisories:
>
> libsdl-native is set to be ASSUME_PROVIDED but sdl-config can't be found
> in PATH. Please either install it, or configure qemu not to require sdl.
>

First, wrong list, this should go to openembedded-core@ instead of -devel@.

qemu's configure prefers pkg-config instead of sdl-config, so why doesn't
that work for you?

Also note that we don't recommend using host libsdl via ASSUME_PROVIDED
because it's a nightmare to link when we've a sysroot full of
ABI-incompatible libraries.  For example if I try to build on Debian 9
qemu-native with the host SDL it fails at configure time:

| ERROR: User requested feature sdl
|        configure was not able to find it.
|        Install SDL devel

That's a lie, it found it but it wouldn't link:

//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`resize_term@NCURSESW_5.3.20021019'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`COLORS@NCURSESW_5.1.20000708'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`raw@NCURSES_TINFO_5.0.19991023'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`ESCDELAY@NCURSESW_5.1.20000708'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`nodelay@NCURSES_TINFO_5.0.19991023'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`initscr@NCURSESW_5.1.20000708'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`nonl@NCURSESW_5.1.20000708'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`wrefresh@NCURSESW_5.1.20000708'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`wmove@NCURSESW_5.1.20000708'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`getmouse@NCURSESW_5.1.20000708'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`curs_set@NCURSES_TINFO_5.0.19991023'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`newterm@NCURSESW_5.1.20000708'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`waddnstr@NCURSESW_5.1.20000708'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`mouseinterval@NCURSESW_5.1.20000708'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`wgetch@NCURSESW_5.1.20000708'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`LINES@NCURSES_TINFO_5.0.19991023'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`curscr@NCURSES_TINFO_5.0.19991023'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`init_pair@NCURSESW_5.1.20000708'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`start_color@NCURSESW_5.1.20000708'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`stdscr@NCURSES_TINFO_5.0.19991023'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`noraw@NCURSES_TINFO_5.0.19991023'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`wattr_on@NCURSESW_5.1.20000708'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`COLS@NCURSES_TINFO_5.0.19991023'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`noecho@NCURSESW_5.1.20000708'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`keypad@NCURSES_TINFO_5.0.19991023'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`ungetch@NCURSESW_5.1.20000708'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`mousemask@NCURSESW_5.1.20000708'
//usr/lib/x86_64-linux-gnu/libcaca.so.0: undefined reference to
`endwin@NCURSESW_5.1.20000708'

The host libcaca is linking to the sysroot libncurses, and they're not
compatible.  This is why we moved away from using
ASSUME_PROVIDED=libsdl-native in December 2015.

Ross

Re: [PATCH] bitbake.conf: Add sdl-config to HOSTTOOLS

[Ricardo Ribalda Delgado]

Hi Ross

On Tue, Oct 3, 2017 at 12:18 PM, Burton, Ross <ross.burton@intel.com> wrote:
> On 3 October 2017 at 10:40, Ricardo Ribalda Delgado
> <ricardo.ribalda@gmail.com> wrote:
>>
>> Without this patch bitbake cannot find sdl-config
>>
>> ERROR:  OE-core's config sanity checker detected a potential
>> misconfiguration.
>> Either fix the cause of this error or at your own risk disable the checker
>> (see sanity.conf).
>> Following is the list of potential problems / advisories:
>>
>> libsdl-native is set to be ASSUME_PROVIDED but sdl-config can't be found
>> in PATH. Please either install it, or configure qemu not to require sdl.
>
>
> First, wrong list, this should go to openembedded-core@ instead of -devel@.

Ups, my bad. sorry about that. I first tried to bitbake mailing list
but it bounced the mail.

>
> qemu's configure prefers pkg-config instead of sdl-config, so why doesn't
> that work for you?

Long story short.

-My configuration was using ASSUME_PROVIDED += "libsdl-native".
probably because I have not changed the local.con for a long while.
-On June I posted https://patchwork.openembedded.org/patch/141112/,
which I wrongly believed that it was merged.
-Also on June Richard posted f0d128ea0dfc2c403ff53a1ac1db3521854b63d5,
that was merged


I am now building without the assume_provided and so far it is working fine.


Maybe we should remove all ASSUME_PROVIDED "libsdl-native" references
on the code?:

ricardo@neopili:/tmp/poky$ git grep ASSUME_PROV | grep sdl
documentation/ref-manual/migration.xml:     ASSUME_PROVIDED += "libsdl-native"
meta-poky/conf/local.conf.sample:# by libsdl-native then uncomment the
ASSUME_PROVIDED line below.
meta-poky/conf/local.conf.sample:#ASSUME_PROVIDED += "libsdl-native"


Best regards!

Re: [PATCH] bitbake.conf: Add sdl-config to HOSTTOOLS

[Patrick Ohly]

On Tue, 2017-10-03 at 11:40 +0200, Ricardo Ribalda Delgado wrote:
> Without this patch bitbake cannot find sdl-config
> 
> ERROR:  OE-core's config sanity checker detected a potential
> misconfiguration.
> Either fix the cause of this error or at your own risk disable the
> checker (see sanity.conf).
> Following is the list of potential problems / advisories:
> 
> libsdl-native is set to be ASSUME_PROVIDED but sdl-config can't be
> found in PATH. Please either install it, or configure qemu not to
> require sdl.

Making sdl-config available is the wrong solution. See https://bugzilla
.yoctoproject.org/show_bug.cgi?id=11725

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.

Re: [PATCH] bitbake.conf: Add sdl-config to HOSTTOOLS

[Burton, Ross]

On 4 October 2017 at 10:32, Patrick Ohly <patrick.ohly@intel.com> wrote:

> On Tue, 2017-10-03 at 11:40 +0200, Ricardo Ribalda Delgado wrote:
> > Without this patch bitbake cannot find sdl-config
> >
> > ERROR:  OE-core's config sanity checker detected a potential
> > misconfiguration.
> > Either fix the cause of this error or at your own risk disable the
> > checker (see sanity.conf).
> > Following is the list of potential problems / advisories:
> >
> > libsdl-native is set to be ASSUME_PROVIDED but sdl-config can't be
> > found in PATH. Please either install it, or configure qemu not to
> > require sdl.
>
> Making sdl-config available is the wrong solution. See https://bugzilla
> .yoctoproject.org/show_bug.cgi?id=11725


I've just closed that bug because I removed the sdl-config check from
sanity.bbclass back in June.

Ross

[PATCH] bitbake.conf: Add sdl-config to HOSTTOOLS

[Ricardo Ribalda Delgado]

Without this patch bitbake cannot find sdl-config

ERROR:  OE-core's config sanity checker detected a potential misconfiguration.
Either fix the cause of this error or at your own risk disable the checker (see sanity.conf).
Following is the list of potential problems / advisories:

libsdl-native is set to be ASSUME_PROVIDED but sdl-config can't be found in PATH. Please either install it, or configure qemu not to require sdl.

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 meta/conf/bitbake.conf | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 2dac3a1481eb..ebd758d1d904 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -471,6 +471,9 @@ HOSTTOOLS += " \
 # Tools needed to run testimage runtime image testing
 HOSTTOOLS += "ip ping ps scp ssh stty"
 
+# Link to sdl-config if using host SDL
+HOSTTOOLS += "${@bb.utils.contains('ASSUME_PROVIDED', 'libsdl-native', 'sdl-config', '', d)}"
+
 # Link to these if present
 HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo"
 
-- 
2.14.2