From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "ming.lei@redhat.com" <ming.lei@redhat.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"jthumshirn@suse.de" <jthumshirn@suse.de>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"hch@lst.de" <hch@lst.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
"hare@suse.com" <hare@suse.com>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
"shli@kernel.org" <shli@kernel.org>
Subject: Re: [PATCH v5 2/8] md: Neither resync nor reshape while the system is frozen
Date: Wed, 4 Oct 2017 15:38:25 +0000 [thread overview]
Message-ID: <1507131503.3583.24.camel@wdc.com> (raw)
In-Reply-To: <20171004113021.GC17729@ming.t460p>
T24gV2VkLCAyMDE3LTEwLTA0IGF0IDE5OjMwICswODAwLCBNaW5nIExlaSB3cm90ZToNCj4gTGFz
dCB0aW1lLCBJIGFza2VkIHdoaWNoIGlzc3VlIGlzIGZpeGVkIGJ5IHRoaXMgcGF0Y2gsIGJ1dA0K
PiBuZXZlciBnZXQgYW5zd2VyZWQsIHNvIGFnYWluLCB3aGF0IGlzIGlzc3VlIGZpeGVkIGJ5DQo+
IHRoaXMgcGF0Y2g/DQoNClRoYXQncyBub3QgY29ycmVjdC4gSSBkaWQgYW5zd2VyIHlvdXIgcXVl
c3Rpb24uIFNlZSBlLmcuDQpodHRwczovL21hcmMuaW5mby8/bD1saW51eC1ibG9jayZtPTE1MDY5
NTg3OTMwOTYwNi4NCg0KPiBHaXZlbiB0aGUgZm9sbG93aW5nIHBhdGNoZXMgZm9yIG1ha2luZyBT
Q1NJIHF1aWVzY2Ugc2FmZQ0KPiBpcyByZXF1aXJlZCBpbiBlaXRoZXIgUE0gc3VzcGVuZC9yZXN1
bWUgb3Igb3RoZXIgcGF0aA0KPiBvZiB0cmFuc3BvcnRfc3BpIHJldmFsaWRhdGUuIFNvIG9uY2Ug
dGhlc2VzIHBhdGNoZXMgYXJlDQo+IGluLCBJIGRvbid0IHNlZSBhbnkgSS9PIGhhbmcgaW4gc3Vz
cGVuZC9yZXN1bWUgZ2l2ZW4NCj4gdGhlIFNDU0kgcXVpZXNjZSBpc3N1ZSBpcyB2ZXJ5IHNwZWNp
ZmljIG9uZSwgYW5kIG5vdA0KPiBzZWUgdGhpcyBpc3N1ZSBvbiBvdGhlciBraW5kIG9mIGRldmlj
ZS4NCg0KVGhlcmUgYXJlIG1hbnkgbW9yZSBzdG9yYWdlIGRyaXZlcnMgYW5kIGZpbGVzeXN0ZW1z
IHRoYW4gdGhlIG1kIGRyaXZlciB0aGF0DQpjYW4gc3VibWl0IEkvTyBhZnRlciB1c2VyIHNwYWNl
IHByb2Nlc3NlcyBoYXZlIGJlZW4gZnJvemVuLCBlLmcuIHRoZSBCVFJGUw0KUkFJRCBhbmQgc2Ny
dWIgZnVuY3Rpb25hbGl0aWVzLiBJdCB3aWxsIHRha2UgdGltZSB0byBmaXggYWxsIHRoZXNlIGRy
aXZlcnMNCmFuZCBhbHNvIHRvIGFkZCBmaWxlc3lzdGVtIGZyZWV6ZS90aGF3IGZ1bmN0aW9uYWxp
dHkgdG8gdGhlIHN1c3BlbmQgYW5kDQpyZXN1bWUgc2VxdWVuY2VzLiBBcyBsb25nIGFzIG5vdCBh
bGwgZHJpdmVycyBoYXZlIGJlZW4gZml4ZWQgd2Ugd2lsbCBuZWVkDQpTQ1NJIGRldmljZSBxdWll
c2NpbmcgYW5kIHJlc3VtaW5nIGFzIGEgd29ya2Fyb3VuZCB0byBhdm9pZCB0aGF0IGFueSBJL08N
Cm9jY3VycyB3aGlsZSBhIGhpYmVybmF0aW9uIGltYWdlIGlzIGJlaW5nIGNyZWF0ZWQuDQoNCkJh
cnQu
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "ming.lei@redhat.com" <ming.lei@redhat.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"jthumshirn@suse.de" <jthumshirn@suse.de>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"hch@lst.de" <hch@lst.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
"hare@suse.com" <hare@suse.com>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
"shli@kernel.org" <shli@kernel.org>
Subject: Re: [PATCH v5 2/8] md: Neither resync nor reshape while the system is frozen
Date: Wed, 4 Oct 2017 15:38:25 +0000 [thread overview]
Message-ID: <1507131503.3583.24.camel@wdc.com> (raw)
In-Reply-To: <20171004113021.GC17729@ming.t460p>
On Wed, 2017-10-04 at 19:30 +0800, Ming Lei wrote:
> Last time, I asked which issue is fixed by this patch, but
> never get answered, so again, what is issue fixed by
> this patch?
That's not correct. I did answer your question. See e.g.
https://marc.info/?l=linux-block&m=150695879309606.
> Given the following patches for making SCSI quiesce safe
> is required in either PM suspend/resume or other path
> of transport_spi revalidate. So once theses patches are
> in, I don't see any I/O hang in suspend/resume given
> the SCSI quiesce issue is very specific one, and not
> see this issue on other kind of device.
There are many more storage drivers and filesystems than the md driver that
can submit I/O after user space processes have been frozen, e.g. the BTRFS
RAID and scrub functionalities. It will take time to fix all these drivers
and also to add filesystem freeze/thaw functionality to the suspend and
resume sequences. As long as not all drivers have been fixed we will need
SCSI device quiescing and resuming as a workaround to avoid that any I/O
occurs while a hibernation image is being created.
Bart.
next prev parent reply other threads:[~2017-10-04 15:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 22:52 [PATCH v5 0/8] block, scsi, md: Improve suspend and resume Bart Van Assche
2017-10-02 22:52 ` [PATCH v5 1/8] md: Introduce md_stop_all_writes() Bart Van Assche
2017-10-04 1:07 ` Luis R. Rodriguez
2017-10-02 22:52 ` [PATCH v5 2/8] md: Neither resync nor reshape while the system is frozen Bart Van Assche
2017-10-04 1:16 ` Luis R. Rodriguez
2017-10-04 16:58 ` Bart Van Assche
2017-10-04 16:58 ` Bart Van Assche
2017-10-04 11:30 ` Ming Lei
2017-10-04 15:38 ` Bart Van Assche [this message]
2017-10-04 15:38 ` Bart Van Assche
2017-10-02 22:52 ` [PATCH v5 3/8] block: Make q_usage_counter also track legacy requests Bart Van Assche
2017-10-02 22:52 ` [PATCH v5 4/8] block: Convert RQF_PREEMPT into REQ_PREEMPT Bart Van Assche
2017-10-04 6:57 ` Christoph Hellwig
2017-10-02 22:52 ` [PATCH v5 5/8] block: Add the QUEUE_FLAG_PREEMPT_ONLY request queue flag Bart Van Assche
2017-10-04 6:58 ` Christoph Hellwig
2017-10-02 22:52 ` [PATCH v5 6/8] scsi: Reduce suspend latency Bart Van Assche
2017-10-04 7:04 ` Christoph Hellwig
2017-10-04 15:41 ` Bart Van Assche
2017-10-02 22:52 ` [PATCH v5 7/8] scsi: Set QUEUE_FLAG_PREEMPT_ONLY while quiesced Bart Van Assche
2017-10-04 7:06 ` Christoph Hellwig
2017-10-04 15:44 ` Bart Van Assche
2017-10-02 22:52 ` [PATCH v5 8/8] block: Make SCSI device suspend and resume work reliably Bart Van Assche
2017-10-04 7:06 ` Christoph Hellwig
2017-10-04 15:45 ` Bart Van Assche
2017-10-03 16:01 ` [PATCH v5 0/8] block, scsi, md: Improve suspend and resume Oleksandr Natalenko
2017-10-04 6:56 ` Christoph Hellwig
2017-10-04 7:53 ` Ming Lei
2017-10-04 7:56 ` Ming Lei
2017-10-04 15:18 ` Bart Van Assche
2017-10-04 15:31 ` Ming Lei
2017-10-04 22:36 ` Bart Van Assche
2017-10-04 15:21 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507131503.3583.24.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=ming.lei@redhat.com \
--cc=oleksandr@natalenko.name \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.