* [PATCH 1/2] selinux: fix build warning by removing the unused sid variable
@ 2017-10-04 18:32 ` Corentin Labbe
0 siblings, 0 replies; 12+ messages in thread
From: Corentin Labbe @ 2017-10-04 18:32 UTC (permalink / raw)
To: linux-security-module
This patch remove the unused variable sid
This fix the following build warning:
security/selinux/hooks.c:2921:6: warning: variable 'sid' set but not used [-Wunused-but-set-variable]
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
security/selinux/hooks.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index f5d304736852..8507a56f85e4 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -2918,13 +2918,12 @@ static int selinux_inode_init_security(struct inode *inode, struct inode *dir,
{
const struct task_security_struct *tsec = current_security();
struct superblock_security_struct *sbsec;
- u32 sid, newsid, clen;
+ u32 newsid, clen;
int rc;
char *context;
sbsec = dir->i_sb->s_security;
- sid = tsec->sid;
newsid = tsec->create_sid;
rc = selinux_determine_inode_label(current_security(),
--
2.13.6
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 1/2] selinux: fix build warning by removing the unused sid variable
@ 2017-10-04 18:32 ` Corentin Labbe
0 siblings, 0 replies; 12+ messages in thread
From: Corentin Labbe @ 2017-10-04 18:32 UTC (permalink / raw)
To: paul, sds, eparis, james.l.morris, serge
Cc: selinux, linux-security-module, linux-kernel, Corentin Labbe
This patch remove the unused variable sid
This fix the following build warning:
security/selinux/hooks.c:2921:6: warning: variable 'sid' set but not used [-Wunused-but-set-variable]
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
security/selinux/hooks.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index f5d304736852..8507a56f85e4 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -2918,13 +2918,12 @@ static int selinux_inode_init_security(struct inode *inode, struct inode *dir,
{
const struct task_security_struct *tsec = current_security();
struct superblock_security_struct *sbsec;
- u32 sid, newsid, clen;
+ u32 newsid, clen;
int rc;
char *context;
sbsec = dir->i_sb->s_security;
- sid = tsec->sid;
newsid = tsec->create_sid;
rc = selinux_determine_inode_label(current_security(),
--
2.13.6
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] selinux: fix build warning
2017-10-04 18:32 ` Corentin Labbe
@ 2017-10-04 18:32 ` Corentin Labbe
-1 siblings, 0 replies; 12+ messages in thread
From: Corentin Labbe @ 2017-10-04 18:32 UTC (permalink / raw)
To: linux-security-module
This patch make selinux_task_prlimit() static since it is not used
anywhere else.
This fix the following build warning:
security/selinux/hooks.c:3981:5: warning: no previous prototype for 'selinux_task_prlimit' [-Wmissing-prototypes]
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
security/selinux/hooks.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 8507a56f85e4..b8a022f4b4a7 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -3977,8 +3977,8 @@ static int selinux_task_getioprio(struct task_struct *p)
PROCESS__GETSCHED, NULL);
}
-int selinux_task_prlimit(const struct cred *cred, const struct cred *tcred,
- unsigned int flags)
+static int selinux_task_prlimit(const struct cred *cred, const struct cred *tcred,
+ unsigned int flags)
{
u32 av = 0;
--
2.13.6
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] selinux: fix build warning
@ 2017-10-04 18:32 ` Corentin Labbe
0 siblings, 0 replies; 12+ messages in thread
From: Corentin Labbe @ 2017-10-04 18:32 UTC (permalink / raw)
To: paul, sds, eparis, james.l.morris, serge
Cc: selinux, linux-security-module, linux-kernel, Corentin Labbe
This patch make selinux_task_prlimit() static since it is not used
anywhere else.
This fix the following build warning:
security/selinux/hooks.c:3981:5: warning: no previous prototype for 'selinux_task_prlimit' [-Wmissing-prototypes]
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
security/selinux/hooks.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 8507a56f85e4..b8a022f4b4a7 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -3977,8 +3977,8 @@ static int selinux_task_getioprio(struct task_struct *p)
PROCESS__GETSCHED, NULL);
}
-int selinux_task_prlimit(const struct cred *cred, const struct cred *tcred,
- unsigned int flags)
+static int selinux_task_prlimit(const struct cred *cred, const struct cred *tcred,
+ unsigned int flags)
{
u32 av = 0;
--
2.13.6
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 1/2] selinux: fix build warning by removing the unused sid variable
2017-10-04 18:32 ` Corentin Labbe
@ 2017-10-04 20:26 ` Stephen Smalley
-1 siblings, 0 replies; 12+ messages in thread
From: Stephen Smalley @ 2017-10-04 20:26 UTC (permalink / raw)
To: linux-security-module
On Wed, 2017-10-04 at 20:32 +0200, Corentin Labbe wrote:
> This patch remove the unused variable sid
> This fix the following build warning:
> security/selinux/hooks.c:2921:6: warning: variable 'sid' set but not
> used [-Wunused-but-set-variable]
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
> ---
> ?security/selinux/hooks.c | 3 +--
> ?1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index f5d304736852..8507a56f85e4 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -2918,13 +2918,12 @@ static int selinux_inode_init_security(struct
> inode *inode, struct inode *dir,
> ?{
> ? const struct task_security_struct *tsec =
> current_security();
> ? struct superblock_security_struct *sbsec;
> - u32 sid, newsid, clen;
> + u32 newsid, clen;
> ? int rc;
> ? char *context;
> ?
> ? sbsec = dir->i_sb->s_security;
> ?
> - sid = tsec->sid;
> ? newsid = tsec->create_sid;
> ?
> ? rc = selinux_determine_inode_label(current_security(),
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] selinux: fix build warning by removing the unused sid variable
@ 2017-10-04 20:26 ` Stephen Smalley
0 siblings, 0 replies; 12+ messages in thread
From: Stephen Smalley @ 2017-10-04 20:26 UTC (permalink / raw)
To: Corentin Labbe, paul, eparis, james.l.morris, serge
Cc: linux-security-module, linux-kernel, selinux
On Wed, 2017-10-04 at 20:32 +0200, Corentin Labbe wrote:
> This patch remove the unused variable sid
> This fix the following build warning:
> security/selinux/hooks.c:2921:6: warning: variable 'sid' set but not
> used [-Wunused-but-set-variable]
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
> ---
> security/selinux/hooks.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index f5d304736852..8507a56f85e4 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -2918,13 +2918,12 @@ static int selinux_inode_init_security(struct
> inode *inode, struct inode *dir,
> {
> const struct task_security_struct *tsec =
> current_security();
> struct superblock_security_struct *sbsec;
> - u32 sid, newsid, clen;
> + u32 newsid, clen;
> int rc;
> char *context;
>
> sbsec = dir->i_sb->s_security;
>
> - sid = tsec->sid;
> newsid = tsec->create_sid;
>
> rc = selinux_determine_inode_label(current_security(),
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/2] selinux: fix build warning
2017-10-04 18:32 ` Corentin Labbe
@ 2017-10-04 20:27 ` Stephen Smalley
-1 siblings, 0 replies; 12+ messages in thread
From: Stephen Smalley @ 2017-10-04 20:27 UTC (permalink / raw)
To: linux-security-module
On Wed, 2017-10-04 at 20:32 +0200, Corentin Labbe wrote:
> This patch make selinux_task_prlimit() static since it is not used
> anywhere else.
> This fix the following build warning:
> security/selinux/hooks.c:3981:5: warning: no previous prototype for
> 'selinux_task_prlimit' [-Wmissing-prototypes]
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
> ---
> ?security/selinux/hooks.c | 4 ++--
> ?1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 8507a56f85e4..b8a022f4b4a7 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -3977,8 +3977,8 @@ static int selinux_task_getioprio(struct
> task_struct *p)
> ? ????PROCESS__GETSCHED, NULL);
> ?}
> ?
> -int selinux_task_prlimit(const struct cred *cred, const struct cred
> *tcred,
> - ?unsigned int flags)
> +static int selinux_task_prlimit(const struct cred *cred, const
> struct cred *tcred,
> + unsigned int flags)
> ?{
> ? u32 av = 0;
> ?
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] selinux: fix build warning
@ 2017-10-04 20:27 ` Stephen Smalley
0 siblings, 0 replies; 12+ messages in thread
From: Stephen Smalley @ 2017-10-04 20:27 UTC (permalink / raw)
To: Corentin Labbe, paul, eparis, james.l.morris, serge
Cc: linux-security-module, linux-kernel, selinux
On Wed, 2017-10-04 at 20:32 +0200, Corentin Labbe wrote:
> This patch make selinux_task_prlimit() static since it is not used
> anywhere else.
> This fix the following build warning:
> security/selinux/hooks.c:3981:5: warning: no previous prototype for
> 'selinux_task_prlimit' [-Wmissing-prototypes]
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
> ---
> security/selinux/hooks.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 8507a56f85e4..b8a022f4b4a7 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -3977,8 +3977,8 @@ static int selinux_task_getioprio(struct
> task_struct *p)
> PROCESS__GETSCHED, NULL);
> }
>
> -int selinux_task_prlimit(const struct cred *cred, const struct cred
> *tcred,
> - unsigned int flags)
> +static int selinux_task_prlimit(const struct cred *cred, const
> struct cred *tcred,
> + unsigned int flags)
> {
> u32 av = 0;
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/2] selinux: fix build warning by removing the unused sid variable
2017-10-04 20:26 ` Stephen Smalley
@ 2017-10-04 20:33 ` Paul Moore
-1 siblings, 0 replies; 12+ messages in thread
From: Paul Moore @ 2017-10-04 20:33 UTC (permalink / raw)
To: linux-security-module
On Wed, Oct 4, 2017 at 4:26 PM, Stephen Smalley <sds@tycho.nsa.gov> wrote:
> On Wed, 2017-10-04 at 20:32 +0200, Corentin Labbe wrote:
>> This patch remove the unused variable sid
>> This fix the following build warning:
>> security/selinux/hooks.c:2921:6: warning: variable 'sid' set but not
>> used [-Wunused-but-set-variable]
>>
>> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
>
> Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
Looks good to me too, merged into selinux/next. Thanks.
--
paul moore
www.paul-moore.com
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] selinux: fix build warning by removing the unused sid variable
@ 2017-10-04 20:33 ` Paul Moore
0 siblings, 0 replies; 12+ messages in thread
From: Paul Moore @ 2017-10-04 20:33 UTC (permalink / raw)
To: Stephen Smalley
Cc: Corentin Labbe, Eric Paris, James Morris, serge,
linux-security-module, linux-kernel, selinux
On Wed, Oct 4, 2017 at 4:26 PM, Stephen Smalley <sds@tycho.nsa.gov> wrote:
> On Wed, 2017-10-04 at 20:32 +0200, Corentin Labbe wrote:
>> This patch remove the unused variable sid
>> This fix the following build warning:
>> security/selinux/hooks.c:2921:6: warning: variable 'sid' set but not
>> used [-Wunused-but-set-variable]
>>
>> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
>
> Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
Looks good to me too, merged into selinux/next. Thanks.
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/2] selinux: fix build warning
2017-10-04 20:27 ` Stephen Smalley
@ 2017-10-04 20:34 ` Paul Moore
-1 siblings, 0 replies; 12+ messages in thread
From: Paul Moore @ 2017-10-04 20:34 UTC (permalink / raw)
To: linux-security-module
On Wed, Oct 4, 2017 at 4:27 PM, Stephen Smalley <sds@tycho.nsa.gov> wrote:
> On Wed, 2017-10-04 at 20:32 +0200, Corentin Labbe wrote:
>> This patch make selinux_task_prlimit() static since it is not used
>> anywhere else.
>> This fix the following build warning:
>> security/selinux/hooks.c:3981:5: warning: no previous prototype for
>> 'selinux_task_prlimit' [-Wmissing-prototypes]
>>
>> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
>
> Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
Merged, thanks again.
--
paul moore
www.paul-moore.com
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] selinux: fix build warning
@ 2017-10-04 20:34 ` Paul Moore
0 siblings, 0 replies; 12+ messages in thread
From: Paul Moore @ 2017-10-04 20:34 UTC (permalink / raw)
To: Stephen Smalley
Cc: Corentin Labbe, Eric Paris, James Morris, serge,
linux-security-module, linux-kernel, selinux
On Wed, Oct 4, 2017 at 4:27 PM, Stephen Smalley <sds@tycho.nsa.gov> wrote:
> On Wed, 2017-10-04 at 20:32 +0200, Corentin Labbe wrote:
>> This patch make selinux_task_prlimit() static since it is not used
>> anywhere else.
>> This fix the following build warning:
>> security/selinux/hooks.c:3981:5: warning: no previous prototype for
>> 'selinux_task_prlimit' [-Wmissing-prototypes]
>>
>> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
>
> Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
Merged, thanks again.
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-10-04 20:34 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-04 18:32 [PATCH 1/2] selinux: fix build warning by removing the unused sid variable Corentin Labbe
2017-10-04 18:32 ` Corentin Labbe
2017-10-04 18:32 ` [PATCH 2/2] selinux: fix build warning Corentin Labbe
2017-10-04 18:32 ` Corentin Labbe
2017-10-04 20:27 ` Stephen Smalley
2017-10-04 20:27 ` Stephen Smalley
2017-10-04 20:34 ` Paul Moore
2017-10-04 20:34 ` Paul Moore
2017-10-04 20:26 ` [PATCH 1/2] selinux: fix build warning by removing the unused sid variable Stephen Smalley
2017-10-04 20:26 ` Stephen Smalley
2017-10-04 20:33 ` Paul Moore
2017-10-04 20:33 ` Paul Moore
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.