From: Johannes Berg <johannes@sipsolutions.net>
To: yintang@qti.qualcomm.com, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH V5 1/5] mac80211: Enable TDLS peer buffer STA feature
Date: Wed, 11 Oct 2017 13:07:22 +0200 [thread overview]
Message-ID: <1507720042.1998.31.camel@sipsolutions.net> (raw)
In-Reply-To: <1507623080-9311-2-git-send-email-yintang@qti.qualcomm.com> (sfid-20171010_100936_649329_136CB55B)
> +++ b/include/net/cfg80211.h
> @@ -3249,6 +3249,8 @@ struct cfg80211_ops {
> * beaconing mode (AP, IBSS, Mesh, ...).
> * @WIPHY_FLAG_HAS_STATIC_WEP: The device supports static WEP key
> installation
> * before connection.
> + * @WIPHY_FLAG_SUPPORT_TDLS_BUFFER_ST: Device support buffer STA
> when TDLS is
> + * established.
There's a typo (missing A) here.
However, I don't see a reason for this to be a WIPHY flag rather than a
mac80211 hw flag (enum ieee80211_hw_flags) since you only use it in
mac80211.
In reality, adding WIPHY flags should be really rare - only if
*cfg80211* needs to know something, but *userspace* doesn't...
If cfg80211 doesn't care, add to mac80211. If userspace cares, add to
extended nl80211 flags instead :)
johannes
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: yintang@qti.qualcomm.com, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH V5 1/5] mac80211: Enable TDLS peer buffer STA feature
Date: Wed, 11 Oct 2017 13:07:22 +0200 [thread overview]
Message-ID: <1507720042.1998.31.camel@sipsolutions.net> (raw)
In-Reply-To: <1507623080-9311-2-git-send-email-yintang@qti.qualcomm.com> (sfid-20171010_100936_649329_136CB55B)
> +++ b/include/net/cfg80211.h
> @@ -3249,6 +3249,8 @@ struct cfg80211_ops {
> * beaconing mode (AP, IBSS, Mesh, ...).
> * @WIPHY_FLAG_HAS_STATIC_WEP: The device supports static WEP key
> installation
> * before connection.
> + * @WIPHY_FLAG_SUPPORT_TDLS_BUFFER_ST: Device support buffer STA
> when TDLS is
> + * established.
There's a typo (missing A) here.
However, I don't see a reason for this to be a WIPHY flag rather than a
mac80211 hw flag (enum ieee80211_hw_flags) since you only use it in
mac80211.
In reality, adding WIPHY flags should be really rare - only if
*cfg80211* needs to know something, but *userspace* doesn't...
If cfg80211 doesn't care, add to mac80211. If userspace cares, add to
extended nl80211 flags instead :)
johannes
next prev parent reply other threads:[~2017-10-11 11:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <TDLS for ath10k patch>
2017-10-10 8:11 ` [PATCH V5 0/5] Add TDLS feature for ath10k yintang
2017-10-10 8:11 ` yintang
2017-10-10 8:11 ` [PATCH V5 1/5] mac80211: Enable TDLS peer buffer STA feature yintang
2017-10-10 8:11 ` yintang
2017-10-11 11:07 ` Johannes Berg [this message]
2017-10-11 11:07 ` Johannes Berg
2017-10-10 8:11 ` [PATCH V5 2/5] ath10k: " yintang
2017-10-10 8:11 ` yintang
2017-10-10 8:11 ` [PATCH V5 3/5] ath10k: Enable TDLS peer inactivity detection yintang
2017-10-10 8:11 ` yintang
2017-10-10 8:11 ` [PATCH V5 4/5] ath10k: Avoid to set WEP key for TDLS peer yintang
2017-10-10 8:11 ` yintang
2017-10-10 8:13 ` [PATCH V5 5/5] ath10k: Fix TDLS peer TX data failure issue on encryped AP yintang
2017-10-10 8:13 ` yintang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507720042.1998.31.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yintang@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.