* [PATCH 1/3] drm/panel: simple: fix vertical timings for Innolux AT043TN24
@ 2017-10-11 12:59 Philipp Zabel
2017-10-11 12:59 ` [PATCH 2/3] drm/panel: simple: add bus flags " Philipp Zabel
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Philipp Zabel @ 2017-10-11 12:59 UTC (permalink / raw)
To: dri-devel; +Cc: Thierry Reding, Nicolas Ferre, kernel, Marco Franchi
The vsync length should be 10 lines, as specified in the data sheet.
This gets the actual refresh rate closer to nominal 60 Hz given the
9 MHz pixel clock.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/gpu/drm/panel/panel-simple.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 474fa759e06ec..fd21ca799be8d 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1017,8 +1017,8 @@ static const struct drm_display_mode innolux_at043tn24_mode = {
.htotal = 480 + 2 + 41 + 2,
.vdisplay = 272,
.vsync_start = 272 + 2,
- .vsync_end = 272 + 2 + 11,
- .vtotal = 272 + 2 + 11 + 2,
+ .vsync_end = 272 + 2 + 10,
+ .vtotal = 272 + 2 + 10 + 2,
.vrefresh = 60,
.flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
};
--
2.11.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/3] drm/panel: simple: add bus flags for Innolux AT043TN24
2017-10-11 12:59 [PATCH 1/3] drm/panel: simple: fix vertical timings for Innolux AT043TN24 Philipp Zabel
@ 2017-10-11 12:59 ` Philipp Zabel
2017-10-11 16:13 ` Marco Franchi
2017-10-11 12:59 ` [PATCH 3/3] drm/panel: simple: add delays " Philipp Zabel
2017-10-11 16:12 ` [PATCH 1/3] drm/panel: simple: fix vertical timings " Marco Franchi
2 siblings, 1 reply; 6+ messages in thread
From: Philipp Zabel @ 2017-10-11 12:59 UTC (permalink / raw)
To: dri-devel; +Cc: Thierry Reding, Nicolas Ferre, kernel, Marco Franchi
For LCD interface controllers that support configuring polarity of
pixel clock and data enable signal, specify bus flags in the panel
descriptor.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/gpu/drm/panel/panel-simple.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index fd21ca799be8d..30944d006bf1c 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1032,6 +1032,7 @@ static const struct panel_desc innolux_at043tn24 = {
.height = 54,
},
.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE,
};
static const struct drm_display_mode innolux_at070tn92_mode = {
--
2.11.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/3] drm/panel: simple: add delays for Innolux AT043TN24
2017-10-11 12:59 [PATCH 1/3] drm/panel: simple: fix vertical timings for Innolux AT043TN24 Philipp Zabel
2017-10-11 12:59 ` [PATCH 2/3] drm/panel: simple: add bus flags " Philipp Zabel
@ 2017-10-11 12:59 ` Philipp Zabel
2017-10-11 16:13 ` Marco Franchi
2017-10-11 16:12 ` [PATCH 1/3] drm/panel: simple: fix vertical timings " Marco Franchi
2 siblings, 1 reply; 6+ messages in thread
From: Philipp Zabel @ 2017-10-11 12:59 UTC (permalink / raw)
To: dri-devel; +Cc: Thierry Reding, Nicolas Ferre, kernel, Marco Franchi
The delays between video data and backlight enable and between backlight
disable and end of video data are given as >= 160 ms in the datasheet.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/gpu/drm/panel/panel-simple.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 30944d006bf1c..0d0769874e382 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1007,6 +1007,10 @@ static const struct panel_desc hitachi_tx23d38vm0caa = {
.width = 195,
.height = 117,
},
+ .delay = {
+ .enable = 160,
+ .disable = 160,
+ },
};
static const struct drm_display_mode innolux_at043tn24_mode = {
--
2.11.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/3] drm/panel: simple: fix vertical timings for Innolux AT043TN24
2017-10-11 12:59 [PATCH 1/3] drm/panel: simple: fix vertical timings for Innolux AT043TN24 Philipp Zabel
2017-10-11 12:59 ` [PATCH 2/3] drm/panel: simple: add bus flags " Philipp Zabel
2017-10-11 12:59 ` [PATCH 3/3] drm/panel: simple: add delays " Philipp Zabel
@ 2017-10-11 16:12 ` Marco Franchi
2 siblings, 0 replies; 6+ messages in thread
From: Marco Franchi @ 2017-10-11 16:12 UTC (permalink / raw)
To: p.zabel@pengutronix.de, dri-devel@lists.freedesktop.org
Cc: thierry.reding@gmail.com, nicolas.ferre@atmel.com,
kernel@pengutronix.de
Hi Philipp,
On Qua, 2017-10-11 at 14:59 +0200, Philipp Zabel wrote:
> The vsync length should be 10 lines, as specified in the data sheet.
> This gets the actual refresh rate closer to nominal 60 Hz given the
> 9 MHz pixel clock.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Thank you for all these fixes.
Tested-by: Marco Franchi <marco.franchi@nxp.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-12 0:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-11 12:59 [PATCH 1/3] drm/panel: simple: fix vertical timings for Innolux AT043TN24 Philipp Zabel
2017-10-11 12:59 ` [PATCH 2/3] drm/panel: simple: add bus flags " Philipp Zabel
2017-10-11 16:13 ` Marco Franchi
2017-10-11 12:59 ` [PATCH 3/3] drm/panel: simple: add delays " Philipp Zabel
2017-10-11 16:13 ` Marco Franchi
2017-10-11 16:12 ` [PATCH 1/3] drm/panel: simple: fix vertical timings " Marco Franchi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.