From: Joe Perches <joe@perches.com>
To: linux-security-module@vger.kernel.org
Subject: Re: [PATCH] selinux: remove extraneous initialization of slots_used and max_chain_len
Date: Sat, 14 Oct 2017 15:22:46 +0000 [thread overview]
Message-ID: <1507994566.814.17.camel@perches.com> (raw)
In-Reply-To: <20171014145224.840-1-colin.king@canonical.com>
On Sat, 2017-10-14 at 15:52 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variables slots_used and max_chain_len are being initialized to zero
> twice. Remove the first set of initializations. Cleans up the
> clang warnings:
>
> Value stored to 'slots_used' is never read
> Value stored to 'max_chain_len' is never read
[]
> diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c
[]
> @@ -148,8 +148,6 @@ void hashtab_stat(struct hashtab *h, struct hashtab_info *info)
> u32 i, chain_len, slots_used, max_chain_len;
> struct hashtab_node *cur;
>
> - slots_used = 0;
> - max_chain_len = 0;
> for (slots_used = max_chain_len = i = 0; i < h->size; i++) {
> cur = h->htable[i];
> if (cur) {
I think it'd be nicer if the assignments in the loop
were removed instead.
slots_used = 0;
max_chain_len = 0;
for (i = 0; i < h->size; i++) {
etc...
WARNING: multiple messages have this Message-ID (diff)
From: joe@perches.com (Joe Perches)
To: linux-security-module@vger.kernel.org
Subject: [PATCH] selinux: remove extraneous initialization of slots_used and max_chain_len
Date: Sat, 14 Oct 2017 08:22:46 -0700 [thread overview]
Message-ID: <1507994566.814.17.camel@perches.com> (raw)
In-Reply-To: <20171014145224.840-1-colin.king@canonical.com>
On Sat, 2017-10-14 at 15:52 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variables slots_used and max_chain_len are being initialized to zero
> twice. Remove the first set of initializations. Cleans up the
> clang warnings:
>
> Value stored to 'slots_used' is never read
> Value stored to 'max_chain_len' is never read
[]
> diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c
[]
> @@ -148,8 +148,6 @@ void hashtab_stat(struct hashtab *h, struct hashtab_info *info)
> u32 i, chain_len, slots_used, max_chain_len;
> struct hashtab_node *cur;
>
> - slots_used = 0;
> - max_chain_len = 0;
> for (slots_used = max_chain_len = i = 0; i < h->size; i++) {
> cur = h->htable[i];
> if (cur) {
I think it'd be nicer if the assignments in the loop
were removed instead.
slots_used = 0;
max_chain_len = 0;
for (i = 0; i < h->size; i++) {
etc...
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Colin King <colin.king@canonical.com>,
Paul Moore <paul@paul-moore.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
Eric Paris <eparis@parisplace.org>,
James Morris <james.l.morris@oracle.com>,
"Serge E . Hallyn" <serge@hallyn.com>,
Markus Elfring <elfring@users.sourceforge.net>,
selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selinux: remove extraneous initialization of slots_used and max_chain_len
Date: Sat, 14 Oct 2017 08:22:46 -0700 [thread overview]
Message-ID: <1507994566.814.17.camel@perches.com> (raw)
In-Reply-To: <20171014145224.840-1-colin.king@canonical.com>
On Sat, 2017-10-14 at 15:52 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variables slots_used and max_chain_len are being initialized to zero
> twice. Remove the first set of initializations. Cleans up the
> clang warnings:
>
> Value stored to 'slots_used' is never read
> Value stored to 'max_chain_len' is never read
[]
> diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c
[]
> @@ -148,8 +148,6 @@ void hashtab_stat(struct hashtab *h, struct hashtab_info *info)
> u32 i, chain_len, slots_used, max_chain_len;
> struct hashtab_node *cur;
>
> - slots_used = 0;
> - max_chain_len = 0;
> for (slots_used = max_chain_len = i = 0; i < h->size; i++) {
> cur = h->htable[i];
> if (cur) {
I think it'd be nicer if the assignments in the loop
were removed instead.
slots_used = 0;
max_chain_len = 0;
for (i = 0; i < h->size; i++) {
etc...
next prev parent reply other threads:[~2017-10-14 15:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-14 14:52 [PATCH] selinux: remove extraneous initialization of slots_used and max_chain_len Colin King
2017-10-14 14:52 ` Colin King
2017-10-14 14:52 ` Colin King
2017-10-14 15:07 ` walter harms
2017-10-14 15:07 ` walter harms
2017-10-14 15:07 ` walter harms
2017-10-14 15:22 ` Joe Perches [this message]
2017-10-14 15:22 ` Joe Perches
2017-10-14 15:22 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507994566.814.17.camel@perches.com \
--to=joe@perches.com \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.