All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trent Piepho <tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
To: "shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"fabio.estevam-3arQi8VN3Tc@public.gmane.org"
	<fabio.estevam-3arQi8VN3Tc@public.gmane.org>,
	"kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org"
	<kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	"gerg-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org"
	<gerg-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Subject: Re: [PATCH 4/4] ARM: imx: Update spi_imx platform data to reflect current state
Date: Wed, 18 Oct 2017 17:50:30 +0000	[thread overview]
Message-ID: <1508349029.87493.8.camel@impinj.com> (raw)
In-Reply-To: <20171018021709.GD18810@dragon>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1080 bytes --]

On Wed, 2017-10-18 at 10:17 +0800, Shawn Guo wrote:
> On Fri, Oct 13, 2017 at 12:54:10PM -0700, Trent Piepho wrote:
> > 
> > If a board uses all native chip selects, then it's not necessary to
> > specify a chip select array at all, as all native is the default (this is
> > how device-tree configured SPI masters work too).  Most of the spi-imx
> > platform data users have their chip select arrays removed by this patch.
> > 
> > 
> Does this patch have any dependency on others in this series, or can it
> be sent via arm-soc tree independently?

It needs patch 1 and 3 in the series.  Currently supplying cs gpios is
mandatory for both platform data and DT based systems using spi-imx. 
The latter is a bug, as the DT binding clearly makes cs-gpios optional
and other drivers do not require it.  I figured I might as well clean
up the platform data while I fixed that bug and came across the
imx31moboard bug in that process.
N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±²˜¢žØ^n‡r¡ö¦zË\x1aëh™¨è­Ú&¢îý»\x05ËÛÔØï¦v¬Îf\x1dp)¹¹br	šê+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹\x1e®w¥¢¸?™¨è­Ú&¢)ߢ^[f

WARNING: multiple messages have this Message-ID (diff)
From: tpiepho@impinj.com (Trent Piepho)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM: imx: Update spi_imx platform data to reflect current state
Date: Wed, 18 Oct 2017 17:50:30 +0000	[thread overview]
Message-ID: <1508349029.87493.8.camel@impinj.com> (raw)
In-Reply-To: <20171018021709.GD18810@dragon>

On Wed, 2017-10-18 at 10:17 +0800, Shawn Guo wrote:
> On Fri, Oct 13, 2017 at 12:54:10PM -0700, Trent Piepho wrote:
> > 
> > If a board uses all native chip selects, then it's not necessary to
> > specify a chip select array at all, as all native is the default (this is
> > how device-tree configured SPI masters work too).  Most of the spi-imx
> > platform data users have their chip select arrays removed by this patch.
> > 
> > 
> Does this patch have any dependency on others in this series, or can it
> be sent via arm-soc tree independently?

It needs patch 1 and 3 in the series.  Currently supplying cs gpios is
mandatory for both platform data and DT based systems using spi-imx. 
The latter is a bug, as the DT binding clearly makes cs-gpios optional
and other drivers do not require it.  I figured I might as well clean
up the platform data while I fixed that bug and came across the
imx31moboard bug in that process.

  reply	other threads:[~2017-10-18 17:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-13 19:54 [PATCH 1/4] spi: imx: GPIO based chip selects should not be required Trent Piepho
2017-10-13 19:54 ` Trent Piepho
     [not found] ` <20171013195410.30767-1-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-10-13 19:54   ` [PATCH 2/4] spi: imx: Fix failure path leak on GPIO request error Trent Piepho
2017-10-13 19:54     ` Trent Piepho
     [not found]     ` <20171013195410.30767-2-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-10-19 10:27       ` Oleksij Rempel
2017-10-19 10:27         ` Oleksij Rempel
2017-10-13 19:54   ` [PATCH 3/4] spi: imx: Don't require platform data chipselect array Trent Piepho
2017-10-13 19:54     ` Trent Piepho
2017-10-18  9:02     ` Julien Thierry
2017-10-18  9:02       ` Julien Thierry
     [not found]       ` <36d381de-ee3f-26d4-59c3-b9d361758ace-5wv7dgnIgG8@public.gmane.org>
2017-10-18 17:30         ` Trent Piepho
2017-10-18 17:30           ` Trent Piepho
2017-10-30 23:47         ` Trent Piepho
2017-10-30 23:47           ` Trent Piepho
2017-10-13 19:54   ` [PATCH 4/4] ARM: imx: Update spi_imx platform data to reflect current state Trent Piepho
2017-10-13 19:54     ` Trent Piepho
     [not found]     ` <20171013195410.30767-4-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-10-15 23:34       ` Greg Ungerer
2017-10-15 23:34         ` Greg Ungerer
2017-10-18  2:17       ` Shawn Guo
2017-10-18  2:17         ` Shawn Guo
2017-10-18 17:50         ` Trent Piepho [this message]
2017-10-18 17:50           ` Trent Piepho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1508349029.87493.8.camel@impinj.com \
    --to=tpiepho-cgc2codaahdqt0dzr+alfa@public.gmane.org \
    --cc=fabio.estevam-3arQi8VN3Tc@public.gmane.org \
    --cc=gerg-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
    --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.