All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amarnath Valluri <amarnath.valluri@intel.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "BALATON Zoltan" <balaton@eik.bme.hu>,
	"Richard W . M . Jones" <rjones@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
	"Juan Quintela" <quintela@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
	"Marc-André Lureau" <marcandre.lureau@gmail.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	"Peter Xu" <peterx@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH v2 0/4] tpm: add stubs to fix compiling with --disable-tpm
Date: Tue, 24 Oct 2017 21:19:22 +0300	[thread overview]
Message-ID: <1508869162.4025.1.camel@intel.com> (raw)
In-Reply-To: <20171024122045.30072-1-f4bug@amsat.org>

On Tue, 2017-10-24 at 09:20 -0300, Philippe Mathieu-Daudé wrote:
> This fixes building with --disable-tpm as reported by Zoltan:
>   http://lists.nongnu.org/archive/html/qemu-devel/2017-10/msg05369.html
> 
> Cc'ing Peter in case this enters as a build fix instead of via trivial.
> 
> v2:
> - added Richard W.M. Jones Tested-by tag
> - remove #ifdef CONFIG_TPM in tpm.c (Stefan Berger)
> 
> Regards,
> 
> Phil.
> 
> PD: I missed Amarnath Valluri in my first series, you might want to add yourself
>     a R: tag in MAINTAINTERS.
>     
> Philippe Mathieu-Daudé (4):
>   tpm: add missing include
>   tpm: add stubs
>   tpm: remove unnecessary #ifdef CONFIG_TPM
>   vl: remove unnecessary #ifdef CONFIG_TPM
> 
>  Makefile.objs        |  2 +-
>  include/sysemu/tpm.h |  1 +
>  stubs/tpm.c          | 33 +++++++++++++++++++++++++++++++++
>  tpm.c                |  4 ----
>  vl.c                 |  2 --
>  MAINTAINERS          |  1 +
>  stubs/Makefile.objs  |  1 +
>  7 files changed, 37 insertions(+), 7 deletions(-)
>  create mode 100644 stubs/tpm.c
> 
+1, Nice cleanup in my opinion, now it looks much cleaner.

- Amarnath



WARNING: multiple messages have this Message-ID (diff)
From: Amarnath Valluri <amarnath.valluri@intel.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "BALATON Zoltan" <balaton@eik.bme.hu>,
	"Richard W . M . Jones" <rjones@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
	"Juan Quintela" <quintela@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
	"Marc-André Lureau" <marcandre.lureau@gmail.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	"Peter Xu" <peterx@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/4] tpm: add stubs to fix compiling with --disable-tpm
Date: Tue, 24 Oct 2017 21:19:22 +0300	[thread overview]
Message-ID: <1508869162.4025.1.camel@intel.com> (raw)
In-Reply-To: <20171024122045.30072-1-f4bug@amsat.org>

On Tue, 2017-10-24 at 09:20 -0300, Philippe Mathieu-Daudé wrote:
> This fixes building with --disable-tpm as reported by Zoltan:
>   http://lists.nongnu.org/archive/html/qemu-devel/2017-10/msg05369.html
> 
> Cc'ing Peter in case this enters as a build fix instead of via trivial.
> 
> v2:
> - added Richard W.M. Jones Tested-by tag
> - remove #ifdef CONFIG_TPM in tpm.c (Stefan Berger)
> 
> Regards,
> 
> Phil.
> 
> PD: I missed Amarnath Valluri in my first series, you might want to add yourself
>     a R: tag in MAINTAINTERS.
>     
> Philippe Mathieu-Daudé (4):
>   tpm: add missing include
>   tpm: add stubs
>   tpm: remove unnecessary #ifdef CONFIG_TPM
>   vl: remove unnecessary #ifdef CONFIG_TPM
> 
>  Makefile.objs        |  2 +-
>  include/sysemu/tpm.h |  1 +
>  stubs/tpm.c          | 33 +++++++++++++++++++++++++++++++++
>  tpm.c                |  4 ----
>  vl.c                 |  2 --
>  MAINTAINERS          |  1 +
>  stubs/Makefile.objs  |  1 +
>  7 files changed, 37 insertions(+), 7 deletions(-)
>  create mode 100644 stubs/tpm.c
> 
+1, Nice cleanup in my opinion, now it looks much cleaner.

- Amarnath

  parent reply	other threads:[~2017-10-24 20:49 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24 12:20 [Qemu-trivial] [PATCH v2 0/4] tpm: add stubs to fix compiling with --disable-tpm Philippe Mathieu-Daudé
2017-10-24 12:20 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-10-24 12:20 ` [Qemu-trivial] [PATCH v2 1/4] tpm: add missing include Philippe Mathieu-Daudé
2017-10-24 12:20   ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-10-24 12:20 ` [Qemu-trivial] [PATCH v2 2/4] tpm: add stubs Philippe Mathieu-Daudé
2017-10-24 12:20   ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-10-24 23:20   ` [Qemu-trivial] " Juan Quintela
2017-10-24 23:20     ` [Qemu-devel] " Juan Quintela
2017-10-26  7:06   ` [Qemu-trivial] " Valluri, Amarnath
2017-10-26  7:06     ` [Qemu-devel] " Valluri, Amarnath
2017-10-24 12:20 ` [Qemu-trivial] [PATCH v2 3/4] tpm: remove unnecessary #ifdef CONFIG_TPM Philippe Mathieu-Daudé
2017-10-24 12:20   ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-10-24 17:35   ` [Qemu-trivial] " Stefan Berger
2017-10-24 17:35     ` Stefan Berger
2017-10-24 23:20   ` [Qemu-trivial] " Juan Quintela
2017-10-24 23:20     ` [Qemu-devel] " Juan Quintela
2017-10-26  7:04   ` [Qemu-trivial] " Valluri, Amarnath
2017-10-26  7:04     ` [Qemu-devel] " Valluri, Amarnath
2017-10-24 12:20 ` [Qemu-trivial] [PATCH v2 4/4] vl: " Philippe Mathieu-Daudé
2017-10-24 12:20   ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-10-24 23:20   ` [Qemu-trivial] " Juan Quintela
2017-10-24 23:20     ` [Qemu-devel] " Juan Quintela
2017-10-26  7:03   ` [Qemu-trivial] " Valluri, Amarnath
2017-10-26  7:03     ` [Qemu-devel] " Valluri, Amarnath
2017-10-24 12:39 ` [Qemu-trivial] [PATCH v2 0/4] tpm: add stubs to fix compiling with --disable-tpm Richard W.M. Jones
2017-10-24 12:39   ` [Qemu-devel] " Richard W.M. Jones
2017-10-24 13:23   ` [Qemu-trivial] " Philippe Mathieu-Daudé
2017-10-24 13:23     ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-10-24 18:19 ` Amarnath Valluri [this message]
2017-10-24 18:19   ` Amarnath Valluri
2017-10-25 13:30   ` [Qemu-trivial] " Philippe Mathieu-Daudé
2017-10-25 13:30     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1508869162.4025.1.camel@intel.com \
    --to=amarnath.valluri@intel.com \
    --cc=balaton@eik.bme.hu \
    --cc=dgilbert@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=marcandre.lureau@gmail.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=rjones@redhat.com \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.