From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] Revert "drm/i915/selftests: Convert timers to use timer_setup()"
Date: Wed, 25 Oct 2017 16:15:57 +0300 [thread overview]
Message-ID: <1508937357.13538.21.camel@linux.intel.com> (raw)
In-Reply-To: <20171025131336.2584-1-chris@chris-wilson.co.uk>
On Wed, 2017-10-25 at 14:13 +0100, Chris Wilson wrote:
> This reverts commit 6d0dbd309687113009a276886628c7c74c848d3c.
>
> timer_setup_on_stack() does not yet exist:
>
> In file included from drivers/gpu/drm/i915/i915_sw_fence.c:517:0:
> drivers/gpu/drm/i915/selftests/lib_sw_fence.c: In function ‘timed_fence_init’:
> drivers/gpu/drm/i915/selftests/lib_sw_fence.c:63:2: error: implicit declaration of function ‘timer_setup_on_stack’; did you mean ‘hrtimer_init_on_stack’? [-Werror=implicit-function-declaration]
> timer_setup_on_stack(&tf->timer, timed_fence_wake, 0);
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-25 13:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 13:13 [PATCH] Revert "drm/i915/selftests: Convert timers to use timer_setup()" Chris Wilson
2017-10-25 13:15 ` Joonas Lahtinen [this message]
2017-10-25 13:15 ` Chris Wilson
2017-10-25 13:36 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-10-25 14:34 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508937357.13538.21.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.