* [PATCH] Revert "drm/i915/selftests: Convert timers to use timer_setup()"
@ 2017-10-25 13:13 Chris Wilson
2017-10-25 13:15 ` Joonas Lahtinen
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Chris Wilson @ 2017-10-25 13:13 UTC (permalink / raw)
To: intel-gfx
This reverts commit 6d0dbd309687113009a276886628c7c74c848d3c.
timer_setup_on_stack() does not yet exist:
In file included from drivers/gpu/drm/i915/i915_sw_fence.c:517:0:
drivers/gpu/drm/i915/selftests/lib_sw_fence.c: In function ‘timed_fence_init’:
drivers/gpu/drm/i915/selftests/lib_sw_fence.c:63:2: error: implicit declaration of function ‘timer_setup_on_stack’; did you mean ‘hrtimer_init_on_stack’? [-Werror=implicit-function-declaration]
timer_setup_on_stack(&tf->timer, timed_fence_wake, 0);
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
drivers/gpu/drm/i915/selftests/lib_sw_fence.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/selftests/lib_sw_fence.c b/drivers/gpu/drm/i915/selftests/lib_sw_fence.c
index b26f07b55d86..3790fdf44a1a 100644
--- a/drivers/gpu/drm/i915/selftests/lib_sw_fence.c
+++ b/drivers/gpu/drm/i915/selftests/lib_sw_fence.c
@@ -49,9 +49,9 @@ void onstack_fence_fini(struct i915_sw_fence *fence)
i915_sw_fence_fini(fence);
}
-static void timed_fence_wake(struct timer_list *t)
+static void timed_fence_wake(unsigned long data)
{
- struct timed_fence *tf = from_timer(tf, t, timer);
+ struct timed_fence *tf = (struct timed_fence *)data;
i915_sw_fence_commit(&tf->fence);
}
@@ -60,7 +60,7 @@ void timed_fence_init(struct timed_fence *tf, unsigned long expires)
{
onstack_fence_init(&tf->fence);
- timer_setup_on_stack(&tf->timer, timed_fence_wake, 0);
+ setup_timer_on_stack(&tf->timer, timed_fence_wake, (unsigned long)tf);
if (time_after(expires, jiffies))
mod_timer(&tf->timer, expires);
--
2.15.0.rc2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Revert "drm/i915/selftests: Convert timers to use timer_setup()"
2017-10-25 13:13 [PATCH] Revert "drm/i915/selftests: Convert timers to use timer_setup()" Chris Wilson
@ 2017-10-25 13:15 ` Joonas Lahtinen
2017-10-25 13:15 ` Chris Wilson
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Joonas Lahtinen @ 2017-10-25 13:15 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On Wed, 2017-10-25 at 14:13 +0100, Chris Wilson wrote:
> This reverts commit 6d0dbd309687113009a276886628c7c74c848d3c.
>
> timer_setup_on_stack() does not yet exist:
>
> In file included from drivers/gpu/drm/i915/i915_sw_fence.c:517:0:
> drivers/gpu/drm/i915/selftests/lib_sw_fence.c: In function ‘timed_fence_init’:
> drivers/gpu/drm/i915/selftests/lib_sw_fence.c:63:2: error: implicit declaration of function ‘timer_setup_on_stack’; did you mean ‘hrtimer_init_on_stack’? [-Werror=implicit-function-declaration]
> timer_setup_on_stack(&tf->timer, timed_fence_wake, 0);
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Revert "drm/i915/selftests: Convert timers to use timer_setup()"
2017-10-25 13:13 [PATCH] Revert "drm/i915/selftests: Convert timers to use timer_setup()" Chris Wilson
2017-10-25 13:15 ` Joonas Lahtinen
@ 2017-10-25 13:15 ` Chris Wilson
2017-10-25 13:36 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-10-25 14:34 ` ✗ Fi.CI.BAT: failure " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2017-10-25 13:15 UTC (permalink / raw)
To: intel-gfx
Quoting Chris Wilson (2017-10-25 14:13:36)
> This reverts commit 6d0dbd309687113009a276886628c7c74c848d3c.
>
> timer_setup_on_stack() does not yet exist:
>
> In file included from drivers/gpu/drm/i915/i915_sw_fence.c:517:0:
> drivers/gpu/drm/i915/selftests/lib_sw_fence.c: In function ‘timed_fence_init’:
> drivers/gpu/drm/i915/selftests/lib_sw_fence.c:63:2: error: implicit declaration of function ‘timer_setup_on_stack’; did you mean ‘hrtimer_init_on_stack’? [-Werror=implicit-function-declaration]
> timer_setup_on_stack(&tf->timer, timed_fence_wake, 0);
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Acked-by Joonas, and applied to the on going drm-tip mess...
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: warning for Revert "drm/i915/selftests: Convert timers to use timer_setup()"
2017-10-25 13:13 [PATCH] Revert "drm/i915/selftests: Convert timers to use timer_setup()" Chris Wilson
2017-10-25 13:15 ` Joonas Lahtinen
2017-10-25 13:15 ` Chris Wilson
@ 2017-10-25 13:36 ` Patchwork
2017-10-25 14:34 ` ✗ Fi.CI.BAT: failure " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-10-25 13:36 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: Revert "drm/i915/selftests: Convert timers to use timer_setup()"
URL : https://patchwork.freedesktop.org/series/32637/
State : warning
== Summary ==
Series 32637v1 Revert "drm/i915/selftests: Convert timers to use timer_setup()"
https://patchwork.freedesktop.org/api/1.0/series/32637/revisions/1/mbox/
Test gem_sync:
Subgroup basic-store-all:
pass -> DMESG-WARN (fi-bsw-n3050)
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:442s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:459s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:377s
fi-bsw-n3050 total:289 pass:242 dwarn:1 dfail:0 fail:0 skip:46 time:518s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:262s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:493s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:497s
fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:494s
fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:480s
fi-cfl-s total:289 pass:253 dwarn:4 dfail:0 fail:0 skip:32 time:554s
fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:595s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:421s
fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:247s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:579s
fi-glk-dsi total:289 pass:258 dwarn:0 dfail:0 fail:1 skip:30 time:496s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:426s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:427s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:433s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:496s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:464s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:490s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:574s
fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:479s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:581s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:544s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:453s
fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:594s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:646s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:528s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:515s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:458s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:566s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:427s
4f8347a1460a9d0688a141773fc89de8e5755ad8 drm-tip: 2017y-10m-25d-13h-07m-46s UTC integration manifest
7e19321b5015 Revert "drm/i915/selftests: Convert timers to use timer_setup()"
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6181/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* ✗ Fi.CI.BAT: failure for Revert "drm/i915/selftests: Convert timers to use timer_setup()"
2017-10-25 13:13 [PATCH] Revert "drm/i915/selftests: Convert timers to use timer_setup()" Chris Wilson
` (2 preceding siblings ...)
2017-10-25 13:36 ` ✗ Fi.CI.BAT: warning for " Patchwork
@ 2017-10-25 14:34 ` Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-10-25 14:34 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: Revert "drm/i915/selftests: Convert timers to use timer_setup()"
URL : https://patchwork.freedesktop.org/series/32637/
State : failure
== Summary ==
Series 32637 revision 1 was fully merged or fully failed: no git log
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6181/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-25 14:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-25 13:13 [PATCH] Revert "drm/i915/selftests: Convert timers to use timer_setup()" Chris Wilson
2017-10-25 13:15 ` Joonas Lahtinen
2017-10-25 13:15 ` Chris Wilson
2017-10-25 13:36 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-10-25 14:34 ` ✗ Fi.CI.BAT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.