From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Phil Reid <preid@electromag.com.au>,
nsekhar@ti.com, khilman@kernel.org, wsa@the-dreams.de,
jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
fntoth@gmail.com
Subject: Re: [PATCH v4 7/7] i2c: remove legacy integer scl/sda gpio for recovery
Date: Tue, 31 Oct 2017 12:19:48 +0200 [thread overview]
Message-ID: <1509445188.10233.110.camel@linux.intel.com> (raw)
In-Reply-To: <1509435239-64848-8-git-send-email-preid@electromag.com.au>
On Tue, 2017-10-31 at 15:33 +0800, Phil Reid wrote:
> Remove all reference to code related to using integer based ids for
> scl/sda gpio for bus recovery. All in tree drivers are now using the
> gpio descriptors to specific the required gpios.
> - * @scl_gpio: gpio number of the SCL line. Only required for GPIO
> recovery.
> - * @sda_gpio: gpio number of the SDA line. Only required for GPIO
> recovery.
> + * @scl_gpiod: gpiod of the SCL line. Only required for GPIO
> recovery.
> + * @sda_gpiod: gpiod of the SDA line. Only required for GPIO
> recovery.
Ah, missed comment here.
0day kbuild bot now warns if we add field w/o kernel doc description.
I would suggest to add the descriptions in the same patch which brings
new fields and here just remove old ones.
> /* gpio recovery */
> - int scl_gpio;
> - int sda_gpio;
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
WARNING: multiple messages have this Message-ID (diff)
From: andriy.shevchenko@linux.intel.com (Andy Shevchenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 7/7] i2c: remove legacy integer scl/sda gpio for recovery
Date: Tue, 31 Oct 2017 12:19:48 +0200 [thread overview]
Message-ID: <1509445188.10233.110.camel@linux.intel.com> (raw)
In-Reply-To: <1509435239-64848-8-git-send-email-preid@electromag.com.au>
On Tue, 2017-10-31 at 15:33 +0800, Phil Reid wrote:
> Remove all reference to code related to using integer based ids for
> scl/sda gpio for bus recovery. All in tree drivers are now using the
> gpio descriptors to specific the required gpios.
> - * @scl_gpio: gpio number of the SCL line. Only required for GPIO
> recovery.
> - * @sda_gpio: gpio number of the SDA line. Only required for GPIO
> recovery.
> + * @scl_gpiod: gpiod of the SCL line. Only required for GPIO
> recovery.
> + * @sda_gpiod: gpiod of the SDA line. Only required for GPIO
> recovery.
Ah, missed comment here.
0day kbuild bot now warns if we add field w/o kernel doc description.
I would suggest to add the descriptions in the same patch which brings
new fields and here just remove old ones.
> /* gpio recovery */
> - int scl_gpio;
> - int sda_gpio;
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-10-31 10:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 7:33 [PATCH v4 0/7] i2c: designware: add i2c gpio recovery option Phil Reid
2017-10-31 7:33 ` Phil Reid
2017-10-31 7:33 ` [PATCH v4 1/7] i2c: Switch to using gpiod interface for gpio bus recovery Phil Reid
2017-10-31 7:33 ` Phil Reid
2017-11-01 16:23 ` Jarkko Nikula
2017-11-01 16:23 ` Jarkko Nikula
2017-10-31 7:33 ` [PATCH v4 2/7] i2c: designware: move i2c_dw_plat_prepare_clk to common Phil Reid
2017-10-31 7:33 ` Phil Reid
2017-10-31 7:33 ` [PATCH v4 3/7] i2c: designware: rename i2c_dw_plat_prepare_clk to i2c_dw_prepare_clk Phil Reid
2017-10-31 7:33 ` Phil Reid
2017-10-31 10:10 ` Andy Shevchenko
2017-10-31 10:10 ` Andy Shevchenko
2017-10-31 7:33 ` [PATCH v4 4/7] i2c: designware: add i2c gpio recovery option Phil Reid
2017-10-31 7:33 ` Phil Reid
2017-11-01 16:22 ` Jarkko Nikula
2017-11-01 16:22 ` Jarkko Nikula
2017-10-31 7:33 ` [PATCH v4 5/7] i2c: imx: switch to using gpiod for bus recovery gpios Phil Reid
2017-10-31 7:33 ` Phil Reid
2017-10-31 7:33 ` [PATCH v4 6/7] i2c: davinci: " Phil Reid
2017-10-31 7:33 ` Phil Reid
2017-10-31 7:33 ` [PATCH v4 7/7] i2c: remove legacy integer scl/sda gpio for recovery Phil Reid
2017-10-31 7:33 ` Phil Reid
2017-10-31 10:19 ` Andy Shevchenko [this message]
2017-10-31 10:19 ` Andy Shevchenko
2017-10-31 10:17 ` [PATCH v4 0/7] i2c: designware: add i2c gpio recovery option Andy Shevchenko
2017-10-31 10:17 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509445188.10233.110.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=fntoth@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=nsekhar@ti.com \
--cc=preid@electromag.com.au \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.