All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Tom Saeger <tom.saeger@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] scripts: warn about invalid MAINTAINER patterns
Date: Tue, 31 Oct 2017 08:47:58 -0700	[thread overview]
Message-ID: <1509464878.31043.2.camel@perches.com> (raw)
In-Reply-To: <a35fc984e206942eec67302726f5b642c68909b9.1509401037.git.tom.saeger@oracle.com>

On Tue, 2017-10-31 at 09:46 -0500, Tom Saeger wrote:
> Add get_maintainer.pl option to warn about invalid
> "F" and "X" patterns found in MAINTAINERS file(s).

Hi Tom.

I've had a similar script for many years.

This implementation is very inefficient as it runs
git ls-files once for each file pattern.

It's much more efficient to do a global git ls-files
once and store the result and then do a local grep
for pattern matches.

cheers, Joe

  reply	other threads:[~2017-10-31 15:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-31 14:46 [RFC PATCH 0/2] scripts: warn about invalid MAINTAINER patterns Tom Saeger
2017-10-31 14:46 ` [RFC PATCH 1/2] " Tom Saeger
2017-10-31 15:47   ` Joe Perches [this message]
2017-10-31 15:50     ` Tom Saeger
2017-10-31 14:46 ` [RFC PATCH 2/2] MAINTAINERS: various pattern fixes for mv/rm/typos Tom Saeger
2017-10-31 15:55   ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1509464878.31043.2.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tom.saeger@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.