All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: seabios <seabios@seabios.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] seabios serial console vs. sgabios
Date: Fri, 03 Nov 2017 07:49:03 +0100	[thread overview]
Message-ID: <1509691743.31823.1.camel@redhat.com> (raw)
In-Reply-To: <20171102161103.GU32533@redhat.com>

On Thu, 2017-11-02 at 16:11 +0000, Daniel P. Berrange wrote:
> On Thu, Nov 02, 2017 at 05:04:20PM +0100, Gerd Hoffmann wrote:
> >   Hi,
> > 
> > One problem we have with the serial console support in seabios and
> > sgabios:  It can happen that both are activated.  We'll go fix that
> > in
> > qemu, but that'll work for new qemu versions only, not for the old
> > already released ones.
> > 
> > So I think it would be useful if seabios makes sure sgabios and
> > serial
> > console are not both active at the same time, i.e. in case we find
> > "vgaroms/sgabios.bin" being present either turn off builtin serial
> > console, or don't load sgabios (and possibly also enable builtin
> > serial
> > console).
> 
> Historically libvirt will always use '-device sgabios' if the user
> has
> requested <bios useserial='yes'/>.  So if that -device arg is given,
> I
> think QEMU must honour it, which implies QEMU must disable Seabios'
> own built-in serial console impl in that scenario.

Hmm, why?  The user asked for a serial console.  Whenever that is
provided by seabios builtin support or the sgabios rom doesn't really
matter, no?

Also, the question is what seabios should do in case both are active. 
Which I think can happen today with libvirt if you configure a virtual
machine without vga (libvirt passes -machine graphics=off which
activates builtin serial console) and with "<bios useserial='yes'/>"
(enables sgabios rom).

cheers,
  Gerd

  parent reply	other threads:[~2017-11-03  6:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-02 16:04 [Qemu-devel] seabios serial console vs. sgabios Gerd Hoffmann
2017-11-02 16:11 ` Daniel P. Berrange
2017-11-02 16:13   ` Paolo Bonzini
2017-11-03  6:49   ` Gerd Hoffmann [this message]
2017-11-03 10:10     ` Daniel P. Berrange
2017-11-03 10:43       ` Gerd Hoffmann
2017-11-06  6:09         ` Markus Armbruster
2017-11-03 20:13 ` [Qemu-devel] [SeaBIOS] " Kevin O'Connor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1509691743.31823.1.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=seabios@seabios.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.