diff for duplicates of <1509897719.5851.2.camel@primarydata.com> diff --git a/a/1.txt b/N1/1.txt index 2e446f7..d3808ff 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,19 +1,31 @@ -T24gU3VuLCAyMDE3LTExLTA1IGF0IDEzOjAwICswMzAwLCBWYXNpbHkgQXZlcmluIHdyb3RlOg0K -PiBCZSBzdXJlIHRoYXQgbmZzX2NsaWVudF9saXN0IGFuZCBuZnNfdm9sdW1lX2xpc3QgbGlzdHMg -aW5pdGlhbGl6ZWQNCj4gaW4gbmV0X2luaXQgaG9vayB3ZXJlIHJldHVybiB0byBpbml0aWFsIHN0 -YXRlIGluIG5ldF9leGl0IGhvb2suDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBWYXNpbHkgQXZlcmlu -IDx2dnNAdmlydHVvenpvLmNvbT4NCj4gLS0tDQo+ICBmcy9uZnMvY2xpZW50LmMgfCA0ICsrKysN -Cj4gIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKykNCj4gDQo+IGRpZmYgLS1naXQgYS9m -cy9uZnMvY2xpZW50LmMgYi9mcy9uZnMvY2xpZW50LmMNCj4gaW5kZXggMjI4ODBlZi4uN2MwNjkx -YyAxMDA2NDQNCj4gLS0tIGEvZnMvbmZzL2NsaWVudC5jDQo+ICsrKyBiL2ZzL25mcy9jbGllbnQu -Yw0KPiBAQCAtMjA0LDYgKzIwNCwxMCBAQCB2b2lkIG5mc19jbGVhbnVwX2NiX2lkZW50X2lkcihz -dHJ1Y3QgbmV0ICpuZXQpDQo+ICAJc3RydWN0IG5mc19uZXQgKm5uID0gbmV0X2dlbmVyaWMobmV0 -LCBuZnNfbmV0X2lkKTsNCj4gIA0KPiAgCWlkcl9kZXN0cm95KCZubi0+Y2JfaWRlbnRfaWRyKTsN -Cj4gKwlXQVJOKCFsaXN0X2VtcHR5KCZubi0+bmZzX2NsaWVudF9saXN0KSwNCj4gKwkgICAgICJu -ZXQgJXAgZXhpdDogbmZzX2NsaWVudF9saXN0IGlzIG5vdCBlbXB0eVxuIiwgbmV0KTsNCj4gKwlX -QVJOKCFsaXN0X2VtcHR5KCZubi0+bmZzX3ZvbHVtZV9saXN0KSwNCj4gKwkgICAgICJuZXQgJXAg -ZXhpdDogbmZzX3ZvbHVtZV9saXN0IGlzIG5vdCBlbXB0eVxuIiwgbmV0KTsNCj4gIH0NCj4gIA0K -DQpXaHkgZG8gd2UgbmVlZCB0aGVzZT8gSXMgdGhlcmUgYSBzcGVjaWZpYyBidWcgdGhhdCB5b3Ug -YXJlIHRyeWluZyB0bw0KdHJhY2sgZG93bj8NCg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4 -IE5GUyBjbGllbnQgbWFpbnRhaW5lciwgUHJpbWFyeURhdGENCnRyb25kLm15a2xlYnVzdEBwcmlt -YXJ5ZGF0YS5jb20NCg== +On Sun, 2017-11-05 at 13:00 +0300, Vasily Averin wrote: +> Be sure that nfs_client_list and nfs_volume_list lists initialized +> in net_init hook were return to initial state in net_exit hook. +> +> Signed-off-by: Vasily Averin <vvs@virtuozzo.com> +> --- +> fs/nfs/client.c | 4 ++++ +> 1 file changed, 4 insertions(+) +> +> diff --git a/fs/nfs/client.c b/fs/nfs/client.c +> index 22880ef..7c0691c 100644 +> --- a/fs/nfs/client.c +> +++ b/fs/nfs/client.c +> @@ -204,6 +204,10 @@ void nfs_cleanup_cb_ident_idr(struct net *net) +> struct nfs_net *nn = net_generic(net, nfs_net_id); +> +> idr_destroy(&nn->cb_ident_idr); +> + WARN(!list_empty(&nn->nfs_client_list), +> + "net %p exit: nfs_client_list is not empty\n", net); +> + WARN(!list_empty(&nn->nfs_volume_list), +> + "net %p exit: nfs_volume_list is not empty\n", net); +> } +> + +Why do we need these? Is there a specific bug that you are trying to +track down? + +-- +Trond Myklebust +Linux NFS client maintainer, PrimaryData +trond.myklebust@primarydata.com diff --git a/a/content_digest b/N1/content_digest index 234f4a5..66db181 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,31 +1,44 @@ "ref\05cbecaf0-dbb6-4140-43ed-ae94fc161941@virtuozzo.com\0" - "From\0Trond Myklebust <trondmy@primarydata.com>\0" + "ref\05cbecaf0-dbb6-4140-43ed-ae94fc161941-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org\0" + "From\0Trond Myklebust <trondmy-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>\0" "Subject\0Re: [PATCH 06/21] nfs client: exit_net cleanup check added\0" "Date\0Sun, 5 Nov 2017 16:02:01 +0000\0" - "To\0netdev@vger.kernel.org <netdev@vger.kernel.org>" - " vvs@virtuozzo.com <vvs@virtuozzo.com>\0" - "Cc\0anna.schumaker@netapp.com <anna.schumaker@netapp.com>" - " linux-nfs@vger.kernel.org <linux-nfs@vger.kernel.org>\0" + "To\0netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>" + " vvs-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org <vvs-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>\0" + "Cc\0anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org <anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>" + " linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>\0" "\00:1\0" "b\0" - "T24gU3VuLCAyMDE3LTExLTA1IGF0IDEzOjAwICswMzAwLCBWYXNpbHkgQXZlcmluIHdyb3RlOg0K\n" - "PiBCZSBzdXJlIHRoYXQgbmZzX2NsaWVudF9saXN0IGFuZCBuZnNfdm9sdW1lX2xpc3QgbGlzdHMg\n" - "aW5pdGlhbGl6ZWQNCj4gaW4gbmV0X2luaXQgaG9vayB3ZXJlIHJldHVybiB0byBpbml0aWFsIHN0\n" - "YXRlIGluIG5ldF9leGl0IGhvb2suDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBWYXNpbHkgQXZlcmlu\n" - "IDx2dnNAdmlydHVvenpvLmNvbT4NCj4gLS0tDQo+ICBmcy9uZnMvY2xpZW50LmMgfCA0ICsrKysN\n" - "Cj4gIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKykNCj4gDQo+IGRpZmYgLS1naXQgYS9m\n" - "cy9uZnMvY2xpZW50LmMgYi9mcy9uZnMvY2xpZW50LmMNCj4gaW5kZXggMjI4ODBlZi4uN2MwNjkx\n" - "YyAxMDA2NDQNCj4gLS0tIGEvZnMvbmZzL2NsaWVudC5jDQo+ICsrKyBiL2ZzL25mcy9jbGllbnQu\n" - "Yw0KPiBAQCAtMjA0LDYgKzIwNCwxMCBAQCB2b2lkIG5mc19jbGVhbnVwX2NiX2lkZW50X2lkcihz\n" - "dHJ1Y3QgbmV0ICpuZXQpDQo+ICAJc3RydWN0IG5mc19uZXQgKm5uID0gbmV0X2dlbmVyaWMobmV0\n" - "LCBuZnNfbmV0X2lkKTsNCj4gIA0KPiAgCWlkcl9kZXN0cm95KCZubi0+Y2JfaWRlbnRfaWRyKTsN\n" - "Cj4gKwlXQVJOKCFsaXN0X2VtcHR5KCZubi0+bmZzX2NsaWVudF9saXN0KSwNCj4gKwkgICAgICJu\n" - "ZXQgJXAgZXhpdDogbmZzX2NsaWVudF9saXN0IGlzIG5vdCBlbXB0eVxuIiwgbmV0KTsNCj4gKwlX\n" - "QVJOKCFsaXN0X2VtcHR5KCZubi0+bmZzX3ZvbHVtZV9saXN0KSwNCj4gKwkgICAgICJuZXQgJXAg\n" - "ZXhpdDogbmZzX3ZvbHVtZV9saXN0IGlzIG5vdCBlbXB0eVxuIiwgbmV0KTsNCj4gIH0NCj4gIA0K\n" - "DQpXaHkgZG8gd2UgbmVlZCB0aGVzZT8gSXMgdGhlcmUgYSBzcGVjaWZpYyBidWcgdGhhdCB5b3Ug\n" - "YXJlIHRyeWluZyB0bw0KdHJhY2sgZG93bj8NCg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4\n" - "IE5GUyBjbGllbnQgbWFpbnRhaW5lciwgUHJpbWFyeURhdGENCnRyb25kLm15a2xlYnVzdEBwcmlt\n" - YXJ5ZGF0YS5jb20NCg== + "On Sun, 2017-11-05 at 13:00 +0300, Vasily Averin wrote:\n" + "> Be sure that nfs_client_list and nfs_volume_list lists initialized\n" + "> in net_init hook were return to initial state in net_exit hook.\n" + "> \n" + "> Signed-off-by: Vasily Averin <vvs@virtuozzo.com>\n" + "> ---\n" + "> fs/nfs/client.c | 4 ++++\n" + "> 1 file changed, 4 insertions(+)\n" + "> \n" + "> diff --git a/fs/nfs/client.c b/fs/nfs/client.c\n" + "> index 22880ef..7c0691c 100644\n" + "> --- a/fs/nfs/client.c\n" + "> +++ b/fs/nfs/client.c\n" + "> @@ -204,6 +204,10 @@ void nfs_cleanup_cb_ident_idr(struct net *net)\n" + "> \tstruct nfs_net *nn = net_generic(net, nfs_net_id);\n" + "> \n" + "> \tidr_destroy(&nn->cb_ident_idr);\n" + "> +\tWARN(!list_empty(&nn->nfs_client_list),\n" + "> +\t \"net %p exit: nfs_client_list is not empty\\n\", net);\n" + "> +\tWARN(!list_empty(&nn->nfs_volume_list),\n" + "> +\t \"net %p exit: nfs_volume_list is not empty\\n\", net);\n" + "> }\n" + "> \n" + "\n" + "Why do we need these? Is there a specific bug that you are trying to\n" + "track down?\n" + "\n" + "-- \n" + "Trond Myklebust\n" + "Linux NFS client maintainer, PrimaryData\n" + trond.myklebust@primarydata.com -1e048d8b1e0be5222d5cf3583c5765427e7b9054b77940b2cad566d1b0c1f9fe +9bbe86efcd9065fa43a915a7132199e74b9e6fd0489e7079738c77e2415b75e2
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.