From: Trond Myklebust <trondmy@primarydata.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"vvs@virtuozzo.com" <vvs@virtuozzo.com>
Cc: "anna.schumaker@netapp.com" <anna.schumaker@netapp.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 06/21] nfs client: exit_net cleanup check added
Date: Sun, 5 Nov 2017 16:02:01 +0000 [thread overview]
Message-ID: <1509897719.5851.2.camel@primarydata.com> (raw)
In-Reply-To: <5cbecaf0-dbb6-4140-43ed-ae94fc161941@virtuozzo.com>
T24gU3VuLCAyMDE3LTExLTA1IGF0IDEzOjAwICswMzAwLCBWYXNpbHkgQXZlcmluIHdyb3RlOg0K
PiBCZSBzdXJlIHRoYXQgbmZzX2NsaWVudF9saXN0IGFuZCBuZnNfdm9sdW1lX2xpc3QgbGlzdHMg
aW5pdGlhbGl6ZWQNCj4gaW4gbmV0X2luaXQgaG9vayB3ZXJlIHJldHVybiB0byBpbml0aWFsIHN0
YXRlIGluIG5ldF9leGl0IGhvb2suDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBWYXNpbHkgQXZlcmlu
IDx2dnNAdmlydHVvenpvLmNvbT4NCj4gLS0tDQo+ICBmcy9uZnMvY2xpZW50LmMgfCA0ICsrKysN
Cj4gIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKykNCj4gDQo+IGRpZmYgLS1naXQgYS9m
cy9uZnMvY2xpZW50LmMgYi9mcy9uZnMvY2xpZW50LmMNCj4gaW5kZXggMjI4ODBlZi4uN2MwNjkx
YyAxMDA2NDQNCj4gLS0tIGEvZnMvbmZzL2NsaWVudC5jDQo+ICsrKyBiL2ZzL25mcy9jbGllbnQu
Yw0KPiBAQCAtMjA0LDYgKzIwNCwxMCBAQCB2b2lkIG5mc19jbGVhbnVwX2NiX2lkZW50X2lkcihz
dHJ1Y3QgbmV0ICpuZXQpDQo+ICAJc3RydWN0IG5mc19uZXQgKm5uID0gbmV0X2dlbmVyaWMobmV0
LCBuZnNfbmV0X2lkKTsNCj4gIA0KPiAgCWlkcl9kZXN0cm95KCZubi0+Y2JfaWRlbnRfaWRyKTsN
Cj4gKwlXQVJOKCFsaXN0X2VtcHR5KCZubi0+bmZzX2NsaWVudF9saXN0KSwNCj4gKwkgICAgICJu
ZXQgJXAgZXhpdDogbmZzX2NsaWVudF9saXN0IGlzIG5vdCBlbXB0eVxuIiwgbmV0KTsNCj4gKwlX
QVJOKCFsaXN0X2VtcHR5KCZubi0+bmZzX3ZvbHVtZV9saXN0KSwNCj4gKwkgICAgICJuZXQgJXAg
ZXhpdDogbmZzX3ZvbHVtZV9saXN0IGlzIG5vdCBlbXB0eVxuIiwgbmV0KTsNCj4gIH0NCj4gIA0K
DQpXaHkgZG8gd2UgbmVlZCB0aGVzZT8gSXMgdGhlcmUgYSBzcGVjaWZpYyBidWcgdGhhdCB5b3Ug
YXJlIHRyeWluZyB0bw0KdHJhY2sgZG93bj8NCg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4
IE5GUyBjbGllbnQgbWFpbnRhaW5lciwgUHJpbWFyeURhdGENCnRyb25kLm15a2xlYnVzdEBwcmlt
YXJ5ZGF0YS5jb20NCg==
WARNING: multiple messages have this Message-ID (diff)
From: Trond Myklebust <trondmy-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
To: "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"vvs-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org"
<vvs-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
Cc: "anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org"
<anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>,
"linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 06/21] nfs client: exit_net cleanup check added
Date: Sun, 5 Nov 2017 16:02:01 +0000 [thread overview]
Message-ID: <1509897719.5851.2.camel@primarydata.com> (raw)
In-Reply-To: <5cbecaf0-dbb6-4140-43ed-ae94fc161941-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
On Sun, 2017-11-05 at 13:00 +0300, Vasily Averin wrote:
> Be sure that nfs_client_list and nfs_volume_list lists initialized
> in net_init hook were return to initial state in net_exit hook.
>
> Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
> ---
> fs/nfs/client.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/nfs/client.c b/fs/nfs/client.c
> index 22880ef..7c0691c 100644
> --- a/fs/nfs/client.c
> +++ b/fs/nfs/client.c
> @@ -204,6 +204,10 @@ void nfs_cleanup_cb_ident_idr(struct net *net)
> struct nfs_net *nn = net_generic(net, nfs_net_id);
>
> idr_destroy(&nn->cb_ident_idr);
> + WARN(!list_empty(&nn->nfs_client_list),
> + "net %p exit: nfs_client_list is not empty\n", net);
> + WARN(!list_empty(&nn->nfs_volume_list),
> + "net %p exit: nfs_volume_list is not empty\n", net);
> }
>
Why do we need these? Is there a specific bug that you are trying to
track down?
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
next prev parent reply other threads:[~2017-11-05 16:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-05 10:00 [PATCH 06/21] nfs client: exit_net cleanup check added Vasily Averin
2017-11-05 16:02 ` Trond Myklebust [this message]
2017-11-05 16:02 ` Trond Myklebust
2017-11-05 16:48 ` Vasily Averin
2017-11-05 18:55 ` Trond Myklebust
2017-11-05 18:55 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509897719.5851.2.camel@primarydata.com \
--to=trondmy@primarydata.com \
--cc=anna.schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vvs@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.