All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "staging: lustre: llite: don't invoke direct_IO for the EOF case" has been added to the 4.4-stable tree
@ 2017-11-06  9:25 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-11-06  9:25 UTC (permalink / raw)
  To: yang.sheng, alexander.levin, bob.glossman, bobijam, gregkh,
	jsimmons, oleg.drokin
  Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    staging: lustre: llite: don't invoke direct_IO for the EOF case

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     staging-lustre-llite-don-t-invoke-direct_io-for-the-eof-case.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From foo@baz Mon Nov  6 10:22:56 CET 2017
From: Yang Sheng <yang.sheng@intel.com>
Date: Sat, 7 Oct 2017 22:37:48 +0000
Subject: staging: lustre: llite: don't invoke direct_IO for the EOF case

From: Yang Sheng <yang.sheng@intel.com>


[ Upstream commit 77759771fb95420d23876cb104ab65c022613325 ]

The function generic_file_read_iter() does not check EOF
before invoke direct_IO callback. So we have to check it
ourselves.

Signed-off-by: Yang Sheng <yang.sheng@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8969
Reviewed-on: https://review.whamcloud.com/24552
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: Bobi Jam <bobijam@hotmail.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/staging/lustre/lustre/llite/rw26.c |    4 ++++
 1 file changed, 4 insertions(+)

--- a/drivers/staging/lustre/lustre/llite/rw26.c
+++ b/drivers/staging/lustre/lustre/llite/rw26.c
@@ -376,6 +376,10 @@ static ssize_t ll_direct_IO_26(struct ki
 	if (!lli->lli_has_smd)
 		return -EBADF;
 
+	/* Check EOF by ourselves */
+	if (iov_iter_rw(iter) == READ && file_offset >= i_size_read(inode))
+		return 0;
+
 	/* FIXME: io smaller than PAGE_SIZE is broken on ia64 ??? */
 	if ((file_offset & ~CFS_PAGE_MASK) || (count & ~CFS_PAGE_MASK))
 		return -EINVAL;


Patches currently in stable-queue which might be from yang.sheng@intel.com are

queue-4.4/staging-lustre-llite-don-t-invoke-direct_io-for-the-eof-case.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-11-06  9:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-06  9:25 Patch "staging: lustre: llite: don't invoke direct_IO for the EOF case" has been added to the 4.4-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.