From: Robert Foss <robert.foss@collabora.com>
To: Rob Herring <robh@kernel.org>, Chih-Wei Huang <cwhuang@android-x86.org>
Cc: Chih-Wei Huang <cwhuang@linux.org.tw>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH hwc] Android: add CleanSpec.mk
Date: Mon, 06 Nov 2017 12:16:12 +0100 [thread overview]
Message-ID: <1509966972.2080.1.camel@collabora.com> (raw)
In-Reply-To: <CAL_JsqKc8i+qn+m_qJ5Vr8NSnbbfvsJX6ebXJJfEy6jBNfNHmA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1023 bytes --]
Hey Rob,
On Fri, 2017-11-03 at 07:35 -0500, Rob Herring wrote:
> On Thu, Nov 2, 2017 at 11:45 PM, Chih-Wei Huang <cwhuang@android-x86.
> org> wrote:
> > The file contains rules that are executed on incremental builds.
> > Since commit 4f7dc9b6 the library was moved to /vendor so
> > the old file must be removed.
> >
> > Signed-off-by: Chih-Wei Huang <cwhuang@linux.org.tw>
> > ---
> > CleanSpec.mk | 1 +
> > 1 file changed, 1 insertion(+)
> > create mode 100644 CleanSpec.mk
> >
> > diff --git a/CleanSpec.mk b/CleanSpec.mk
> > new file mode 100644
> > index 0000000..99dcecd
> > --- /dev/null
> > +++ b/CleanSpec.mk
> > @@ -0,0 +1 @@
> > +$(call add-clean-step, rm -rf
> > $(TARGET_OUT)/lib*/hw/hwcomposer.drm.so)
>
> Seems a bit silly to add forever an explicit file to clean for a
> transient problem.
>
While transient, if maintaining multuple Android versions it may still
stick around for quite some time.
That being said, I don't have much of an opinion about this.
Rob.
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-11-06 11:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 4:45 [PATCH hwc] Android: add CleanSpec.mk Chih-Wei Huang
2017-11-03 12:35 ` Rob Herring
2017-11-06 2:12 ` Chih-Wei Huang
2017-11-06 11:16 ` Robert Foss [this message]
2017-11-06 13:38 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509966972.2080.1.camel@collabora.com \
--to=robert.foss@collabora.com \
--cc=cwhuang@android-x86.org \
--cc=cwhuang@linux.org.tw \
--cc=dri-devel@lists.freedesktop.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.