From: Joe Perches <joe@perches.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/page_alloc: Avoid KERN_CONT uses in warn_alloc
Date: Tue, 07 Nov 2017 08:03:27 -0800 [thread overview]
Message-ID: <1510070607.1000.23.camel@perches.com> (raw)
In-Reply-To: <20171107154351.ebtitvjyo5v3bt26@dhcp22.suse.cz>
On Tue, 2017-11-07 at 16:43 +0100, Michal Hocko wrote:
> On Tue 07-11-17 07:34:25, Joe Perches wrote:
[]
> > I believe, but have not tested, that using a specific width
> > as an argument to %*pb[l] will constrain the number of
> > spaces before the '(null)' output in any NULL pointer use.
> >
> > So how about a #define like
> >
> > /*
> > * nodemask_pr_args is only used with a "%*pb[l]" format for a nodemask.
> > * A NULL nodemask uses 6 to emit "(null)" without leading spaces.
> > */
> > #define nodemask_pr_args(maskp) \
> > (maskp) ? MAX_NUMNODES : 6, \
> > (maskp) ? (maskp)->bits : NULL
>
> Why not -1 then?
I believe it's the field width and not the precision that
needs to be set.
But if you test it and it works, then that's fine by me.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/page_alloc: Avoid KERN_CONT uses in warn_alloc
Date: Tue, 07 Nov 2017 08:03:27 -0800 [thread overview]
Message-ID: <1510070607.1000.23.camel@perches.com> (raw)
In-Reply-To: <20171107154351.ebtitvjyo5v3bt26@dhcp22.suse.cz>
On Tue, 2017-11-07 at 16:43 +0100, Michal Hocko wrote:
> On Tue 07-11-17 07:34:25, Joe Perches wrote:
[]
> > I believe, but have not tested, that using a specific width
> > as an argument to %*pb[l] will constrain the number of
> > spaces before the '(null)' output in any NULL pointer use.
> >
> > So how about a #define like
> >
> > /*
> > * nodemask_pr_args is only used with a "%*pb[l]" format for a nodemask.
> > * A NULL nodemask uses 6 to emit "(null)" without leading spaces.
> > */
> > #define nodemask_pr_args(maskp) \
> > (maskp) ? MAX_NUMNODES : 6, \
> > (maskp) ? (maskp)->bits : NULL
>
> Why not -1 then?
I believe it's the field width and not the precision that
needs to be set.
But if you test it and it works, then that's fine by me.
next prev parent reply other threads:[~2017-11-07 16:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 18:02 [PATCH] mm/page_alloc: Avoid KERN_CONT uses in warn_alloc Joe Perches
2017-11-06 18:02 ` Joe Perches
2017-11-07 12:50 ` Michal Hocko
2017-11-07 12:50 ` Michal Hocko
2017-11-07 15:34 ` Joe Perches
2017-11-07 15:34 ` Joe Perches
2017-11-07 15:43 ` Michal Hocko
2017-11-07 15:43 ` Michal Hocko
2017-11-07 16:03 ` Joe Perches [this message]
2017-11-07 16:03 ` Joe Perches
2017-11-09 10:05 ` Michal Hocko
2017-11-09 10:05 ` Michal Hocko
2017-11-09 15:49 ` Joe Perches
2017-11-09 15:49 ` Joe Perches
2017-11-09 16:03 ` Michal Hocko
2017-11-09 16:03 ` Michal Hocko
2017-11-09 16:27 ` Joe Perches
2017-11-09 16:27 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510070607.1000.23.camel@perches.com \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.