From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "axboe@kernel.dk" <axboe@kernel.dk>,
"ming.lei@redhat.com" <ming.lei@redhat.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"john.garry@huawei.com" <john.garry@huawei.com>,
"osandov@fb.com" <osandov@fb.com>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"loberman@redhat.com" <loberman@redhat.com>
Subject: Re: [PATCH] SCSI: don't get target/host busy_count in scsi_mq_get_budget()
Date: Wed, 8 Nov 2017 16:41:35 +0000 [thread overview]
Message-ID: <1510159293.24237.19.camel@wdc.com> (raw)
In-Reply-To: <1a153ff3-9d53-d347-cb16-b8480e690221@kernel.dk>
T24gVHVlLCAyMDE3LTExLTA3IGF0IDIwOjA2IC0wNzAwLCBKZW5zIEF4Ym9lIHdyb3RlOg0KPiBB
dCB0aGlzIHBvaW50LCBJIGhhdmUgbm8gaWRlYSB3aGF0IEJhcnQncyBzZXR1cCBsb29rcyBsaWtl
LiBCYXJ0LCBpdA0KPiB3b3VsZCBiZSBSRUFMTFkgaGVscGZ1bCBpZiB5b3UgY291bGQgdGVsbCB1
cyBob3cgeW91IGFyZSByZXByb2R1Y2luZw0KPiB5b3VyIGhhbmcuIEkgZG9uJ3Qga25vdyB3aHkg
dGhpcyBoYXMgdG8gYmUgZHJhZ2dlZCBvdXQuDQoNCkhlbGxvIEplbnMsDQoNCkl0IGlzIGEgZGlz
YXBwb2ludG1lbnQgdG8gbWUgdGhhdCB5b3UgaGF2ZSBhbGxvd2VkIE1pbmcgdG8gZXZhbHVhdGUg
b3RoZXINCmFwcHJvYWNoZXMgdGhhbiByZXZlcnRpbmcgImJsay1tcTogZG9uJ3QgaGFuZGxlIFRB
R19TSEFSRUQgaW4gcmVzdGFydCIuIFRoYXQNCnBhdGNoIG5hbWVseSByZXBsYWNlcyBhbiBhbGdv
cml0aG0gdGhhdCBpcyB0cnVzdGVkIGJ5IHRoZSBjb21tdW5pdHkgd2l0aCBhbg0KYWxnb3JpdGht
IG9mIHdoaWNoIGV2ZW4gTWluZyBhY2tub3dsZWRnZWQgdGhhdCBpdCBpcyByYWN5LiBBIHF1b3Rl
IGZyb20gWzFdOg0KIklPIGhhbmcgbWF5IGJlIGNhdXNlZCBpZiBhbGwgcmVxdWVzdHMgYXJlIGNv
bXBsZXRlZCBqdXN0IGJlZm9yZSB0aGUgY3VycmVudA0KU0NTSSBkZXZpY2UgaXMgYWRkZWQgdG8g
c2hvc3QtPnN0YXJ2ZWRfbGlzdCIuIEkgZG9uJ3Qga25vdyBvZiBhbnkgd2F5IHRvIGZpeA0KdGhh
dCByYWNlIG90aGVyIHRoYW4gc2VyaWFsaXppbmcgcmVxdWVzdCBzdWJtaXNzaW9uIGFuZCBjb21w
bGV0aW9uIGJ5IGFkZGluZw0KbG9ja2luZyBhcm91bmQgdGhlc2UgYWN0aW9ucywgd2hpY2ggaXMg
c29tZXRoaW5nIHdlIGRvbid0IHdhbnQuIEhlbmNlIG15DQpyZXF1ZXN0IHRvIHJldmVydCB0aGF0
IHBhdGNoLg0KDQpSZWdhcmRpbmcgdGhlIHRlc3QgSSBydW4sIGhlcmUgaXMgYSBzdW1tYXJ5IG9m
IHdoYXQgSSBtZW50aW9uZWQgaW4gcHJldmlvdXMNCmUtbWFpbHM6DQoqIEkgbW9kaWZpZWQgdGhl
IFNSUCBpbml0aWF0b3Igc3VjaCB0aGF0IHRoZSBTQ1NJIHRhcmdldCBxdWV1ZSBkZXB0aCBpcw0K
ICByZWR1Y2VkIHRvIG9uZSBieSBzZXR0aW5nIHN0YXJnZXQtPmNhbl9xdWV1ZSB0byAxIGZyb20g
aW5zaWRlDQogIHNjc2lfaG9zdF90ZW1wbGF0ZS50YXJnZXRfYWxsb2MuDQoqIFdpdGggdGhhdCBt
b2RpZmllZCBTUlAgaW5pdGlhdG9yIEkgcnVuIHRoZSBzcnAtdGVzdCBzb2Z0d2FyZSBhcyBmb2xs
b3dzDQogIHVudGlsIHNvbWV0aGluZyBicmVha3M6DQogIHdoaWxlIC4vcnVuX3Rlc3RzIC1mIHhm
cyAtZCAtZSBkZWFkbGluZSAtciA2MDsgZG8gOjsgZG9uZQ0KDQpUb2RheSBhIHN5c3RlbSB3aXRo
IGF0IGxlYXN0IG9uZSBJbmZpbmlCYW5kIEhDQSBpcyByZXF1aXJlZCB0byBydW4gdGhhdCB0ZXN0
Lg0KV2hlbiBJIGhhdmUgdGhlIHRpbWUgSSB3aWxsIHBvc3QgdGhlIFNSUCBpbml0aWF0b3IgYW5k
IHRhcmdldCBwYXRjaGVzIG9uIHRoZQ0KbGludXgtcmRtYSBtYWlsaW5nIGxpc3QgdGhhdCBtYWtl
IGl0IHBvc3NpYmxlIHRvIHJ1biB0aGF0IHRlc3QgYWdhaW5zdCB0aGUNClNvZnRSb0NFIGRyaXZl
ciAoZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZSkuIFRoZSBvbmx5IGhhcmR3YXJlIHJlcXVpcmVk
IHRvDQp1c2UgdGhhdCBkcml2ZXIgaXMgYW4gRXRoZXJuZXQgYWRhcHRlci4NCg0KQmFydC4NCg0K
WzFdIFtQQVRDSF0gU0NTSTogZG9uJ3QgZ2V0IHRhcmdldC9ob3N0IGJ1c3lfY291bnQgaW4gc2Nz
aV9tcV9nZXRfYnVkZ2V0KCkNCihodHRwczovL3d3dy5tYWlsLWFyY2hpdmUuY29tL2xpbnV4LWJs
b2NrQHZnZXIua2VybmVsLm9yZy9tc2cxNTI2My5odG1sKS4=
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "axboe@kernel.dk" <axboe@kernel.dk>,
"ming.lei@redhat.com" <ming.lei@redhat.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"john.garry@huawei.com" <john.garry@huawei.com>,
"osandov@fb.com" <osandov@fb.com>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"loberman@redhat.com" <loberman@redhat.com>
Subject: Re: [PATCH] SCSI: don't get target/host busy_count in scsi_mq_get_budget()
Date: Wed, 8 Nov 2017 16:41:35 +0000 [thread overview]
Message-ID: <1510159293.24237.19.camel@wdc.com> (raw)
In-Reply-To: <1a153ff3-9d53-d347-cb16-b8480e690221@kernel.dk>
On Tue, 2017-11-07 at 20:06 -0700, Jens Axboe wrote:
> At this point, I have no idea what Bart's setup looks like. Bart, it
> would be REALLY helpful if you could tell us how you are reproducing
> your hang. I don't know why this has to be dragged out.
Hello Jens,
It is a disappointment to me that you have allowed Ming to evaluate other
approaches than reverting "blk-mq: don't handle TAG_SHARED in restart". That
patch namely replaces an algorithm that is trusted by the community with an
algorithm of which even Ming acknowledged that it is racy. A quote from [1]:
"IO hang may be caused if all requests are completed just before the current
SCSI device is added to shost->starved_list". I don't know of any way to fix
that race other than serializing request submission and completion by adding
locking around these actions, which is something we don't want. Hence my
request to revert that patch.
Regarding the test I run, here is a summary of what I mentioned in previous
e-mails:
* I modified the SRP initiator such that the SCSI target queue depth is
reduced to one by setting starget->can_queue to 1 from inside
scsi_host_template.target_alloc.
* With that modified SRP initiator I run the srp-test software as follows
until something breaks:
while ./run_tests -f xfs -d -e deadline -r 60; do :; done
Today a system with at least one InfiniBand HCA is required to run that test.
When I have the time I will post the SRP initiator and target patches on the
linux-rdma mailing list that make it possible to run that test against the
SoftRoCE driver (drivers/infiniband/sw/rxe). The only hardware required to
use that driver is an Ethernet adapter.
Bart.
[1] [PATCH] SCSI: don't get target/host busy_count in scsi_mq_get_budget()
(https://www.mail-archive.com/linux-block@vger.kernel.org/msg15263.html).
next prev parent reply other threads:[~2017-11-08 16:41 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-04 1:55 [PATCH] SCSI: don't get target/host busy_count in scsi_mq_get_budget() Ming Lei
2017-11-04 14:19 ` Jens Axboe
2017-11-06 19:45 ` Bart Van Assche
2017-11-06 19:45 ` Bart Van Assche
2017-11-07 2:11 ` Ming Lei
2017-11-07 16:20 ` Bart Van Assche
2017-11-07 16:20 ` Bart Van Assche
2017-11-07 16:29 ` Jens Axboe
2017-11-07 17:10 ` Jens Axboe
2017-11-07 17:36 ` Jens Axboe
2017-11-07 22:06 ` Jens Axboe
2017-11-07 22:34 ` Bart Van Assche
2017-11-07 22:34 ` Bart Van Assche
2017-11-07 22:39 ` Jens Axboe
2017-11-08 0:50 ` Ming Lei
2017-11-08 1:03 ` Ming Lei
2017-11-08 3:01 ` Jens Axboe
2017-11-08 3:12 ` Ming Lei
2017-11-08 3:17 ` Jens Axboe
2017-11-08 3:17 ` Jens Axboe
2017-11-08 6:20 ` Ming Lei
2017-11-08 15:59 ` Ming Lei
2017-11-08 18:19 ` Jens Axboe
2017-11-07 17:34 ` Bart Van Assche
2017-11-07 17:34 ` Bart Van Assche
2017-11-08 0:53 ` Ming Lei
2017-11-08 2:06 ` Ming Lei
2017-11-08 0:39 ` Ming Lei
2017-11-08 2:55 ` Jens Axboe
2017-11-08 2:58 ` Ming Lei
2017-11-08 3:06 ` Jens Axboe
2017-11-08 16:41 ` Bart Van Assche [this message]
2017-11-08 16:41 ` Bart Van Assche
2017-11-08 17:57 ` Jens Axboe
2017-11-08 18:22 ` Laurence Oberman
2017-11-08 18:28 ` Jens Axboe
2017-11-09 4:02 ` Ming Lei
2017-11-09 2:05 ` Ming Lei
2017-11-07 10:15 ` Ming Lei
2017-11-07 16:17 ` Bart Van Assche
2017-11-07 16:17 ` Bart Van Assche
2017-11-08 3:12 ` Jens Axboe
2017-11-06 18:04 ` Bart Van Assche
2017-11-06 18:04 ` Bart Van Assche
2017-11-07 2:19 ` Ming Lei
2017-11-07 3:53 ` Martin K. Petersen
2017-11-07 3:53 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510159293.24237.19.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.