From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
bitbake-devel@lists.openembedded.org
Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH 3/4] fetch2/repo: Make fetcher always sync on unpack
Date: Wed, 08 Nov 2017 18:09:16 +0000 [thread overview]
Message-ID: <1510164556.3952.17.camel@linuxfoundation.org> (raw)
In-Reply-To: <03c9c452-1fab-60e3-2247-e6235482e718@gmail.com>
On Tue, 2017-11-07 at 21:31 +0200, Oleksandr Andrushchenko wrote:
> On 11/07/2017 03:45 PM, Richard Purdie wrote:
> >
> > On Tue, 2017-10-24 at 14:35 +0300, Oleksandr Andrushchenko wrote:
> > >
> > > From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> > >
> > > Currently if repo has fetched the repository and
> > > cached it to a tar file it never runs repo sync again,
> > > thus making the build use potentially outdated repo.
> > > Fix this by implementing unpack functionality which runs
> > > repo sync.
> > This sounds incorrect to me. The unpack task is not meant to touch
> > the
> > network at all, all network access should be done in the fetch
> > function.
> agree, so, instead this should be done via supporting source
>
> revisions, so fetcher can deal with it? Is this understanding
> correct?
Yes, correct.
Cheers,
Richard
next prev parent reply other threads:[~2017-11-08 18:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 11:35 [PATCH 0/4] fetch2/repo: Repo fetcher fixes and improvements Oleksandr Andrushchenko
2017-10-24 11:35 ` [PATCH 1/4] fetch2/repo: Fix missing logger import in repo fetcher Oleksandr Andrushchenko
2017-10-24 11:35 ` [PATCH 2/4] fetch2/repo: Always check if branch is correct Oleksandr Andrushchenko
2017-10-24 11:35 ` [PATCH 3/4] fetch2/repo: Make fetcher always sync on unpack Oleksandr Andrushchenko
2017-11-07 13:45 ` Richard Purdie
2017-11-07 19:31 ` Oleksandr Andrushchenko
2017-11-08 18:09 ` Richard Purdie [this message]
2017-10-24 11:35 ` [PATCH 4/4] fetch2/repo: Use multiple jobs to fetch and sync Oleksandr Andrushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510164556.3952.17.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=andr2000@gmail.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=oleksandr_andrushchenko@epam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.