From: Joe Perches <joe@perches.com>
To: Rob Herring <robh@kernel.org>, linux-kernel@vger.kernel.org
Cc: Andy Whitcroft <apw@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3] checkpatch.pl: Add SPDX license tag check
Date: Sat, 11 Nov 2017 05:53:12 -0800 [thread overview]
Message-ID: <1510408392.10883.5.camel@perches.com> (raw)
In-Reply-To: <20171110201909.6144-1-robh@kernel.org>
On Fri, 2017-11-10 at 14:19 -0600, Rob Herring wrote:
> SPDX license tags are a thing now in the kernel[1]. It has also been
> decided to make them the first line in files. As Linus put it:
Yes, SPDX tags are used in about a quarter of the files
in the kernel.
Again, where is this shown to be desired that this goes
into _every_ file?
If that is so, it needs to be specified _first_ somewhere
in the Documentation/ tree.
Probably in the process - 1.5 Licensing section.
> "The real reason _I_ personally would like to see at least all the new
> SPDX lines to go at the very top of the file is that every time when
> we have some kind of ambiguity about placement, we end up with
> multiple cases, and then people don't notice when merging, and you end
> up having two - or you just end up having unnecessary merge conflicts
> because two different people picked two different choices)."
>
> Add a warning if SPDX-License-Identifier tag is not present in the first
> line (or 2nd for #! scripts) of files.
>
> [1] https://lwn.net/Articles/738235/
subscription only link
next prev parent reply other threads:[~2017-11-11 13:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 20:19 [PATCH v3] checkpatch.pl: Add SPDX license tag check Rob Herring
2017-11-11 13:53 ` Joe Perches [this message]
2017-11-11 14:22 ` Greg Kroah-Hartman
2017-11-11 14:26 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510408392.10883.5.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.