From: Johannes Berg <johannes@sipsolutions.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Kir Kolyshkin" <kir@openvz.org>
Subject: Re: [net-next] tcp: allow drivers to tweak TSQ logic
Date: Mon, 13 Nov 2017 10:21:17 +0100 [thread overview]
Message-ID: <1510564877.30497.3.camel@sipsolutions.net> (raw)
In-Reply-To: <1510443535.2849.147.camel@edumazet-glaptop3.roam.corp.google.com> (sfid-20171112_003900_506756_66B2F6DE)
On Sat, 2017-11-11 at 15:38 -0800, Eric Dumazet wrote:
> > Hm. I wish we wouldn't have to do this on every skb, but perhaps it
> > doesn't matter that much.
>
> Yes, it does not matter, even at 40Gbit ;)
:)
> Same cache line already ;)
Hah. It seemed so far away, but actually looking at the layout helps :)
> > Unrelated to that, I think this is missing a documentation update since
> > the struct has kernel-doc comments.
>
> Yeah, I believe these kernel-doc on gigantic struct sock are useless and
> we should remove them, they have zero useful info.
No argument from me, but while it's there ... anyway I see you resent
this, thanks for doing this.
I'll try to get people to run some tests for our driver.
johannes
next prev parent reply other threads:[~2017-11-13 9:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 2:41 [PATCH net-next] tcp: allow drivers to tweak TSQ logic Eric Dumazet
2017-11-11 14:27 ` [net-next] " Johannes Berg
2017-11-11 23:38 ` Eric Dumazet
2017-11-13 9:21 ` Johannes Berg [this message]
2017-11-12 14:35 ` Toke Høiland-Jørgensen
2017-11-11 23:54 ` [PATCH v2 net-next] " Eric Dumazet
2017-11-12 13:39 ` Neal Cardwell
2017-11-14 7:18 ` David Miller
2017-11-28 13:10 ` Felix Fietkau
2017-11-28 17:33 ` Eric Dumazet
2017-12-12 14:34 ` [PATCH net-next] net: sk_pacing_shift_update() helper Eric Dumazet
2017-12-13 20:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510564877.30497.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kir@openvz.org \
--cc=netdev@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.