All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Fritz <chf.fritz@googlemail.com>
To: Rob Herring <robh@kernel.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: iio: add Intersil isl76683 light sensor bindings
Date: Tue, 14 Nov 2017 15:20:20 +0100	[thread overview]
Message-ID: <1510669220.1892.4.camel@googlemail.com> (raw)
In-Reply-To: <20171110212604.bpbsgtw7zbk5qp2d@rob-hp-laptop>

Hi Rob

On Fri, 2017-11-10 at 15:26 -0600, Rob Herring wrote:
> On Tue, Nov 07, 2017 at 04:36:22PM +0100, Christoph Fritz wrote:

> > +Optional properties:
> > +
> > +  - isil,external-resistor: integer in kOhm of external resistor R_ext.
> > +                            Valid values are from 1 to 1000.
> > +                            If not supplied, 100 kOhm will be assumed.
> 
> Add an unit suffix as defined in property-units.txt.

Thanks, I'll use "isil,external-resistor-ohms" as defined in
property-units.txt.

What bothers me a bit is that there is no "-kilo-ohms" suffix but a
"-micro-ohms" which is pretty uncommon. Even the only use of suffix
"-micro-ohms" could have been expressed easily as "-ohms" while being
more readable:

qcom,external-resistor-micro-ohms = <10000>;

Due to stable dt-api I suppose this cannot be changed and/or extended
with "-kilo-ohms", right?

Thanks
 -- Christoph

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Fritz <chf.fritz-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Peter Meerwald-Stadler
	<pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>,
	linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/3] dt-bindings: iio: add Intersil isl76683 light sensor bindings
Date: Tue, 14 Nov 2017 15:20:20 +0100	[thread overview]
Message-ID: <1510669220.1892.4.camel@googlemail.com> (raw)
In-Reply-To: <20171110212604.bpbsgtw7zbk5qp2d@rob-hp-laptop>

Hi Rob

On Fri, 2017-11-10 at 15:26 -0600, Rob Herring wrote:
> On Tue, Nov 07, 2017 at 04:36:22PM +0100, Christoph Fritz wrote:

> > +Optional properties:
> > +
> > +  - isil,external-resistor: integer in kOhm of external resistor R_ext.
> > +                            Valid values are from 1 to 1000.
> > +                            If not supplied, 100 kOhm will be assumed.
> 
> Add an unit suffix as defined in property-units.txt.

Thanks, I'll use "isil,external-resistor-ohms" as defined in
property-units.txt.

What bothers me a bit is that there is no "-kilo-ohms" suffix but a
"-micro-ohms" which is pretty uncommon. Even the only use of suffix
"-micro-ohms" could have been expressed easily as "-ohms" while being
more readable:

qcom,external-resistor-micro-ohms = <10000>;

Due to stable dt-api I suppose this cannot be changed and/or extended
with "-kilo-ohms", right?

Thanks
 -- Christoph

  reply	other threads:[~2017-11-14 14:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07 15:36 [PATCH 0/3] iio: add Intersil isl76683 light sensor support Christoph Fritz
2017-11-07 15:36 ` Christoph Fritz
2017-11-07 15:36 ` [PATCH 1/3] iio: light: add support for Intersil isl76683 sensor Christoph Fritz
2017-11-07 15:36   ` Christoph Fritz
2017-11-07 16:28   ` Peter Meerwald-Stadler
2017-11-10 15:55     ` Christoph Fritz
2017-11-11  0:50   ` Jonathan Cameron
2017-11-11  0:50     ` Jonathan Cameron
2017-11-07 15:36 ` [PATCH 2/3] dt-bindings: iio: add Intersil isl76683 light sensor bindings Christoph Fritz
2017-11-07 15:36   ` Christoph Fritz
2017-11-10 21:26   ` Rob Herring
2017-11-10 21:26     ` Rob Herring
2017-11-14 14:20     ` Christoph Fritz [this message]
2017-11-14 14:20       ` Christoph Fritz
2017-11-07 15:36 ` [PATCH 3/3] iio: light: isl76683 add way to adjust irq threshold Christoph Fritz
2017-11-07 15:36   ` Christoph Fritz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510669220.1892.4.camel@googlemail.com \
    --to=chf.fritz@googlemail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.