From: Ley Foon Tan <ley.foon.tan@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>, linux-pci@vger.kernel.org
Cc: "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Michal Simek" <michal.simek@xilinx.com>,
rfi@lists.rocketboards.org,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"Ley Foon Tan" <lftan@altera.com>,
linux-arm-kernel@lists.infradead.org,
"Tanmay Inamdar" <tinamdar@apm.com>
Subject: Re: [PATCH v1 2/3] PCI: altera: Rename altera_pcie_link_is_up() to altera_pcie_link_up()
Date: Wed, 15 Nov 2017 00:58:40 +0800 [thread overview]
Message-ID: <1510678720.2460.2.camel@intel.com> (raw)
In-Reply-To: <20171113224051.29024.76516.stgit@bhelgaas-glaptop.roam.corp.google.com>
T24gTW9uLCAyMDE3LTExLTEzIGF0IDE2OjQwIC0wNjAwLCBCam9ybiBIZWxnYWFzIHdyb3RlOgo+
IEZyb206IEJqb3JuIEhlbGdhYXMgPGJoZWxnYWFzQGdvb2dsZS5jb20+Cj4gCj4gUmVuYW1lIGFs
dGVyYV9wY2llX2xpbmtfaXNfdXAoKSB0byBhbHRlcmFfcGNpZV9saW5rX3VwKCkgdG8gZm9sbG93
Cj4gdGhlCj4gY29udmVudGlvbiBvZiBvdGhlciBkcml2ZXJzLsKgwqBObyBmdW5jdGlvbmFsIGNo
YW5nZSBpbnRlbmRlZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBCam9ybiBIZWxnYWFzIDxiaGVsZ2Fh
c0Bnb29nbGUuY29tPgo+IC0tLQo+IMKgZHJpdmVycy9wY2kvaG9zdC9wY2llLWFsdGVyYS5jIHzC
oMKgwqDCoDggKysrKy0tLS0KPiDCoDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQg
ZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2hvc3QvcGNpZS1hbHRl
cmEuYyBiL2RyaXZlcnMvcGNpL2hvc3QvcGNpZS0KPiBhbHRlcmEuYwo+IGluZGV4IGI0NjhiOGNj
Y2Y4ZC4uNWNjNGY1OTRkNzlhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcGNpL2hvc3QvcGNpZS1h
bHRlcmEuYwo+ICsrKyBiL2RyaXZlcnMvcGNpL2hvc3QvcGNpZS1hbHRlcmEuYwo+IEBAIC0xMDUs
NyArMTA1LDcgQEAgc3RhdGljIGlubGluZSB1MzIgY3JhX3JlYWRsKHN0cnVjdCBhbHRlcmFfcGNp
ZQo+ICpwY2llLCBjb25zdCB1MzIgcmVnKQo+IMKgwqDCoMKgwqDCoMKgwqByZXR1cm4gcmVhZGxf
cmVsYXhlZChwY2llLT5jcmFfYmFzZSArIHJlZyk7Cj4gwqB9Cj4gCj4gLXN0YXRpYyBib29sIGFs
dGVyYV9wY2llX2xpbmtfaXNfdXAoc3RydWN0IGFsdGVyYV9wY2llICpwY2llKQo+ICtzdGF0aWMg
Ym9vbCBhbHRlcmFfcGNpZV9saW5rX3VwKHN0cnVjdCBhbHRlcmFfcGNpZSAqcGNpZSkKPiDCoHsK
PiDCoMKgwqDCoMKgwqDCoMKgcmV0dXJuICEhKChjcmFfcmVhZGwocGNpZSwgUlBfTFRTU00pICYg
UlBfTFRTU01fTUFTSykgPT0KPiBMVFNTTV9MMCk7Cj4gwqB9Cj4gQEAgLTE0Miw3ICsxNDIsNyBA
QCBzdGF0aWMgYm9vbCBhbHRlcmFfcGNpZV92YWxpZF9kZXZpY2Uoc3RydWN0Cj4gYWx0ZXJhX3Bj
aWUgKnBjaWUsCj4gwqB7Cj4gwqDCoMKgwqDCoMKgwqDCoC8qIElmIHRoZXJlIGlzIG5vIGxpbmss
IHRoZW4gdGhlcmUgaXMgbm8gZGV2aWNlICovCj4gwqDCoMKgwqDCoMKgwqDCoGlmIChidXMtPm51
bWJlciAhPSBwY2llLT5yb290X2J1c19ucikgewo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqBpZiAoIWFsdGVyYV9wY2llX2xpbmtfaXNfdXAocGNpZSkpCj4gK8KgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoGlmICghYWx0ZXJhX3BjaWVfbGlua191cChwY2llKSkKPiDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqByZXR1cm4gZmFsc2U7Cj4g
wqDCoMKgwqDCoMKgwqDCoH0KPiAKPiBAQCAtNDEyLDcgKzQxMiw3IEBAIHN0YXRpYyB2b2lkIGFs
dGVyYV93YWl0X2xpbmtfcmV0cmFpbihzdHJ1Y3QKPiBhbHRlcmFfcGNpZSAqcGNpZSkKPiDCoMKg
wqDCoMKgwqDCoMKgLyogV2FpdCBmb3IgbGluayBpcyB1cCAqLwo+IMKgwqDCoMKgwqDCoMKgwqBz
dGFydF9qaWZmaWVzID0gamlmZmllczsKPiDCoMKgwqDCoMKgwqDCoMKgZm9yICg7Oykgewo+IC3C
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBpZiAoYWx0ZXJhX3BjaWVfbGlua19pc191cChw
Y2llKSkKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgaWYgKGFsdGVyYV9wY2llX2xp
bmtfdXAocGNpZSkpCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgYnJlYWs7Cj4gCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBpZiAodGlt
ZV9hZnRlcihqaWZmaWVzLCBzdGFydF9qaWZmaWVzICsKPiBMSU5LX1VQX1RJTUVPVVQpKSB7Cj4g
QEAgLTQyNyw3ICs0MjcsNyBAQCBzdGF0aWMgdm9pZCBhbHRlcmFfcGNpZV9yZXRyYWluKHN0cnVj
dAo+IGFsdGVyYV9wY2llICpwY2llKQo+IMKgewo+IMKgwqDCoMKgwqDCoMKgwqB1MTYgbGlua2Nh
cCwgbGlua3N0YXQsIGxpbmtjdGw7Cj4gCj4gLcKgwqDCoMKgwqDCoMKgaWYgKCFhbHRlcmFfcGNp
ZV9saW5rX2lzX3VwKHBjaWUpKQo+ICvCoMKgwqDCoMKgwqDCoGlmICghYWx0ZXJhX3BjaWVfbGlu
a191cChwY2llKSkKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJldHVybjsKPiAK
PiDCoMKgwqDCoMKgwqDCoMKgLyoKPiAKQWNrZWQtYnk6IExleSBGb29uIFRhbiA8bGV5LmZvb24u
dGFuQGludGVsLmNvbT4=
WARNING: multiple messages have this Message-ID (diff)
From: ley.foon.tan@intel.com (Ley Foon Tan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 2/3] PCI: altera: Rename altera_pcie_link_is_up() to altera_pcie_link_up()
Date: Wed, 15 Nov 2017 00:58:40 +0800 [thread overview]
Message-ID: <1510678720.2460.2.camel@intel.com> (raw)
In-Reply-To: <20171113224051.29024.76516.stgit@bhelgaas-glaptop.roam.corp.google.com>
On Mon, 2017-11-13 at 16:40 -0600, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> Rename altera_pcie_link_is_up() to altera_pcie_link_up() to follow
> the
> convention of other drivers.??No functional change intended.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> ?drivers/pci/host/pcie-altera.c |????8 ++++----
> ?1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-
> altera.c
> index b468b8cccf8d..5cc4f594d79a 100644
> --- a/drivers/pci/host/pcie-altera.c
> +++ b/drivers/pci/host/pcie-altera.c
> @@ -105,7 +105,7 @@ static inline u32 cra_readl(struct altera_pcie
> *pcie, const u32 reg)
> ????????return readl_relaxed(pcie->cra_base + reg);
> ?}
>
> -static bool altera_pcie_link_is_up(struct altera_pcie *pcie)
> +static bool altera_pcie_link_up(struct altera_pcie *pcie)
> ?{
> ????????return !!((cra_readl(pcie, RP_LTSSM) & RP_LTSSM_MASK) ==
> LTSSM_L0);
> ?}
> @@ -142,7 +142,7 @@ static bool altera_pcie_valid_device(struct
> altera_pcie *pcie,
> ?{
> ????????/* If there is no link, then there is no device */
> ????????if (bus->number != pcie->root_bus_nr) {
> -???????????????if (!altera_pcie_link_is_up(pcie))
> +???????????????if (!altera_pcie_link_up(pcie))
> ????????????????????????return false;
> ????????}
>
> @@ -412,7 +412,7 @@ static void altera_wait_link_retrain(struct
> altera_pcie *pcie)
> ????????/* Wait for link is up */
> ????????start_jiffies = jiffies;
> ????????for (;;) {
> -???????????????if (altera_pcie_link_is_up(pcie))
> +???????????????if (altera_pcie_link_up(pcie))
> ????????????????????????break;
>
> ????????????????if (time_after(jiffies, start_jiffies +
> LINK_UP_TIMEOUT)) {
> @@ -427,7 +427,7 @@ static void altera_pcie_retrain(struct
> altera_pcie *pcie)
> ?{
> ????????u16 linkcap, linkstat, linkctl;
>
> -???????if (!altera_pcie_link_is_up(pcie))
> +???????if (!altera_pcie_link_up(pcie))
> ????????????????return;
>
> ????????/*
>
Acked-by: Ley Foon Tan <ley.foon.tan@intel.com>
next prev parent reply other threads:[~2017-11-14 16:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 22:40 [PATCH v1 0/3] PCI: Rename host functions for consistency Bjorn Helgaas
2017-11-13 22:40 ` Bjorn Helgaas
2017-11-13 22:40 ` [PATCH v1 1/3] PCI: xgene: Rename xgene_pcie_probe_bridge() to xgene_pcie_probe() Bjorn Helgaas
2017-11-13 22:40 ` Bjorn Helgaas
2017-11-13 22:40 ` [PATCH v1 2/3] PCI: altera: Rename altera_pcie_link_is_up() to altera_pcie_link_up() Bjorn Helgaas
2017-11-13 22:40 ` Bjorn Helgaas
2017-11-14 16:58 ` Ley Foon Tan [this message]
2017-11-14 16:58 ` Ley Foon Tan
2017-11-13 22:40 ` [PATCH v1 3/3] PCI: xilinx: Rename xilinx_pcie_link_is_up() to xilinx_pcie_link_up() Bjorn Helgaas
2017-11-13 22:40 ` Bjorn Helgaas
2017-11-14 7:17 ` Michal Simek
2017-11-14 7:17 ` Michal Simek
2017-11-14 17:21 ` [PATCH v1 0/3] PCI: Rename host functions for consistency Lorenzo Pieralisi
2017-11-14 17:21 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510678720.2460.2.camel@intel.com \
--to=ley.foon.tan@intel.com \
--cc=helgaas@kernel.org \
--cc=lftan@altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=michal.simek@xilinx.com \
--cc=rfi@lists.rocketboards.org \
--cc=soren.brinkmann@xilinx.com \
--cc=tinamdar@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.