From: Joe Perches <joe@perches.com>
To: Harry Wentland <harry.wentland@amd.com>, linux-kernel@vger.kernel.org
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"David Airlie" <airlied@linux.ie>,
amd-gfx@lists.freedesktop.org,
"Christian König" <christian.koenig@amd.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/4] drm: amd: Fix line continuation formats
Date: Thu, 16 Nov 2017 07:50:12 -0800 [thread overview]
Message-ID: <1510847412.31559.25.camel@perches.com> (raw)
In-Reply-To: <1b2c63b7-319a-caab-6809-197784c179ef@amd.com>
On Thu, 2017-11-16 at 10:38 -0500, Harry Wentland wrote:
> On 2017-11-16 10:27 AM, Joe Perches wrote:
> > Line continuations with excess spacing causes unexpected output.
[]
> > @@ -872,9 +870,8 @@ static bool perform_clock_recovery_sequence(
> > if (retry_count >= LINK_TRAINING_MAX_CR_RETRY) {
> > ASSERT(0);
> > dm_logger_write(link->ctx->logger, LOG_ERROR,
> > - "%s: Link Training Error, could not \
> > - get CR after %d tries. \
> > - Possibly voltage swing issue", __func__,
> > + "%s: Link Training Error, could not get CR after %d tries. Possibly voltage swing issue",
>
> Would probably be good to add a '\n' here as well but that's not the main intention of this patch.
About 1/4 of the dm_logger_write calls are missing
newlines and I think it should be a separate patch.
I encourage you to fix them one day.
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
cheers, Joe
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Harry Wentland <harry.wentland@amd.com>, linux-kernel@vger.kernel.org
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"David Airlie" <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
"Christian König" <christian.koenig@amd.com>,
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/4] drm: amd: Fix line continuation formats
Date: Thu, 16 Nov 2017 07:50:12 -0800 [thread overview]
Message-ID: <1510847412.31559.25.camel@perches.com> (raw)
In-Reply-To: <1b2c63b7-319a-caab-6809-197784c179ef@amd.com>
On Thu, 2017-11-16 at 10:38 -0500, Harry Wentland wrote:
> On 2017-11-16 10:27 AM, Joe Perches wrote:
> > Line continuations with excess spacing causes unexpected output.
[]
> > @@ -872,9 +870,8 @@ static bool perform_clock_recovery_sequence(
> > if (retry_count >= LINK_TRAINING_MAX_CR_RETRY) {
> > ASSERT(0);
> > dm_logger_write(link->ctx->logger, LOG_ERROR,
> > - "%s: Link Training Error, could not \
> > - get CR after %d tries. \
> > - Possibly voltage swing issue", __func__,
> > + "%s: Link Training Error, could not get CR after %d tries. Possibly voltage swing issue",
>
> Would probably be good to add a '\n' here as well but that's not the main intention of this patch.
About 1/4 of the dm_logger_write calls are missing
newlines and I think it should be a separate patch.
I encourage you to fix them one day.
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
cheers, Joe
next prev parent reply other threads:[~2017-11-16 15:50 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 15:27 [PATCH 0/4] treewide: Fix line continuation formats Joe Perches
2017-11-16 15:27 ` Joe Perches
2017-11-16 15:27 ` Joe Perches
2017-11-16 15:27 ` [PATCH 1/4] rk3399_dmc: Fix line continuation format Joe Perches
2017-11-22 5:13 ` Chanwoo Choi
2017-11-22 10:41 ` Joe Perches
2017-11-23 1:21 ` MyungJoo Ham
2017-11-23 1:21 ` MyungJoo Ham
2017-11-23 1:45 ` Chanwoo Choi
2017-11-23 2:07 ` Joe Perches
2017-11-23 2:12 ` Chanwoo Choi
2017-11-23 2:18 ` Joe Perches
2017-11-23 2:23 ` Chanwoo Choi
2017-11-23 2:29 ` Joe Perches
2017-11-23 2:35 ` Chanwoo Choi
2017-11-23 2:38 ` Joe Perches
2017-11-16 15:27 ` [PATCH 2/4] drm: amd: Fix line continuation formats Joe Perches
2017-11-16 15:27 ` Joe Perches
[not found] ` <eee8836696843f983a9533d6441fa9f2d8cbe92f.1510845910.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2017-11-16 15:38 ` Harry Wentland
2017-11-16 15:38 ` Harry Wentland
2017-11-16 15:50 ` Joe Perches [this message]
2017-11-16 15:50 ` Joe Perches
[not found] ` <1510847412.31559.25.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2017-11-17 19:52 ` Alex Deucher
2017-11-17 19:52 ` Alex Deucher
2017-11-16 15:27 ` [PATCH 3/4] [media] dibx000_common: Fix line continuation format Joe Perches
2017-11-16 15:27 ` [PATCH 4/4] ima: " Joe Perches
2017-11-16 15:27 ` Joe Perches
2017-11-16 17:11 ` [PATCH 0/4] treewide: Fix line continuation formats Mimi Zohar
2017-11-16 17:11 ` Mimi Zohar
2017-11-16 17:11 ` Mimi Zohar
2017-11-16 17:17 ` Joe Perches
2017-11-16 17:17 ` Joe Perches
2017-11-16 19:35 ` Mimi Zohar
2017-11-16 19:35 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510847412.31559.25.camel@perches.com \
--to=joe@perches.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.