From: Joe Perches <joe@perches.com>
To: Andreas Brauchli <a.brauchli@elementarea.net>,
Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: allow URL >80 chars
Date: Sat, 18 Nov 2017 06:39:55 -0800 [thread overview]
Message-ID: <1511015995.31022.11.camel@perches.com> (raw)
In-Reply-To: <1510999663.4806.28.camel@elementarea.net>
On Sat, 2017-11-18 at 11:07 +0100, Andreas Brauchli wrote:
> Is the patch acceptable if it only catches URL with protocol specifiers
> foo:// ? That would catch most cases and doesn't show false positives:
> $ git grep -E '://\S{75}.*' -- '*.[ch]'
Of course. but I suggest using a prefix like
\b[\w\.\+\-]+://
so the URL scheme is properly described.
It might be best if there was some generic mechanism
to identify possible URIs and not just URLs instead.
https://en.wikipedia.org/wiki/Uniform_Resource_Identifier
prev parent reply other threads:[~2017-11-18 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 15:56 [PATCH] checkpatch: allow URL >80 chars Andreas Brauchli
2017-11-18 5:21 ` Joe Perches
2017-11-18 10:07 ` Andreas Brauchli
2017-11-18 14:39 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511015995.31022.11.camel@perches.com \
--to=joe@perches.com \
--cc=a.brauchli@elementarea.net \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.