diff for duplicates of <1511026783.10238.2.camel@primarydata.com> diff --git a/a/1.txt b/N1/1.txt index 72670ce..22be48d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,35 +1,54 @@ -T24gU2F0LCAyMDE3LTExLTE4IGF0IDEyOjE5IC0wNTAwLCBCb3JpcyBPc3Ryb3Zza3kgd3JvdGU6 -DQo+IENvbW1pdCBmY2Q4ODQzYzQwNmI0NjQzMzg1N2FlNDVlNWU5ZDg0YjAxYTdkMjBiIGJyZWFr -cyBvbiBvbGRlcg0KPiBjb21waWxlcnMgd2hpY2ggY2Fubm90IHByb2Nlc3MgaW5pdGlhbGl6ZXJz -IGZvciBhbm9ueW1vdXMgc3RydWN0dXJlczoNCj4gDQo+ICtjb25zdCBuZnM0X3N0YXRlaWQgaW52 -YWxpZF9zdGF0ZWlkID0gew0KPiArICAgICAgIHsNCj4gKyAgICAgICAgICAgICAgIC5zZXFpZCA9 -IGNwdV90b19iZTMyKDB4ZmZmZmZmZmZVKSwNCj4gKyAgICAgICAgICAgICAgIC5vdGhlciA9IHsg -MCB9LA0KPiArICAgICAgIH0sDQo+ICsgICAgICAgLnR5cGUgPSBORlM0X0lOVkFMSURfU1RBVEVJ -RF9UWVBFLA0KPiArfTsNCj4gDQo+IA0KPiAvaG9tZS9idWlsZC9saW51eC1saW51cy9mcy9uZnMv -bmZzNHN0YXRlLmM6NzQ6IGVycm9yOiB1bmtub3duIGZpZWxkDQo+IOKAmHNlcWlk4oCZIHNwZWNp -ZmllZCBpbiBpbml0aWFsaXplcg0KPiAvaG9tZS9idWlsZC9saW51eC1saW51cy9mcy9uZnMvbmZz -NHN0YXRlLmM6NzQ6IHdhcm5pbmc6IG1pc3NpbmcNCj4gYnJhY2VzDQo+IGFyb3VuZCBpbml0aWFs -aXplcg0KPiAvaG9tZS9idWlsZC9saW51eC1saW51cy9mcy9uZnMvbmZzNHN0YXRlLmM6NzQ6IHdh -cm5pbmc6IChuZWFyDQo+IGluaXRpYWxpemF0aW9uIGZvciDigJhpbnZhbGlkX3N0YXRlaWQuPGFu -b255bW91cz4uZGF0YeKAmSkNCj4gL2hvbWUvYnVpbGQvbGludXgtbGludXMvZnMvbmZzL25mczRz -dGF0ZS5jOjc0OiB3YXJuaW5nOiBvdmVyZmxvdyBpbg0KPiBpbXBsaWNpdCBjb25zdGFudCBjb252 -ZXJzaW9uDQo+IC9ob21lL2J1aWxkL2xpbnV4LWxpbnVzL2ZzL25mcy9uZnM0c3RhdGUuYzo3NTog -ZXJyb3I6IHVua25vd24gZmllbGQNCj4g4oCYb3RoZXLigJkgc3BlY2lmaWVkIGluIGluaXRpYWxp -emVyDQo+IC9ob21lL2J1aWxkL2xpbnV4LWxpbnVzL2ZzL25mcy9uZnM0c3RhdGUuYzo3NTogZXJy -b3I6IGV4dHJhIGJyYWNlDQo+IGdyb3VwDQo+IGF0IGVuZCBvZiBpbml0aWFsaXplcg0KPiAvaG9t -ZS9idWlsZC9saW51eC1saW51cy9mcy9uZnMvbmZzNHN0YXRlLmM6NzU6IGVycm9yOiAobmVhcg0K -PiBpbml0aWFsaXphdGlvbiBmb3Ig4oCYaW52YWxpZF9zdGF0ZWlkLjxhbm9ueW1vdXM+4oCZKQ0K -PiAvaG9tZS9idWlsZC9saW51eC1saW51cy9mcy9uZnMvbmZzNHN0YXRlLmM6NzU6IHdhcm5pbmc6 -IGV4Y2Vzcw0KPiBlbGVtZW50cw0KPiBpbiB1bmlvbiBpbml0aWFsaXplcg0KPiAvaG9tZS9idWls -ZC9saW51eC1saW51cy9mcy9uZnMvbmZzNHN0YXRlLmM6NzU6IHdhcm5pbmc6IChuZWFyDQo+IGlu -aXRpYWxpemF0aW9uIGZvciDigJhpbnZhbGlkX3N0YXRlaWQuPGFub255bW91cz7igJkpDQo+IG1h -a2VbNF06ICoqKiBbZnMvbmZzL25mczRzdGF0ZS5vXSBFcnJvciAxDQo+IG1ha2VbM106ICoqKiBb -ZnMvbmZzXSBFcnJvciAyDQo+IA0KPiANCj4gRkMtNjQgPGJ1aWxkQGJ1aWxkLW1rMjp+PiBnY2Mg -LS12ZXJzaW9uDQo+IGdjYyAoR0NDKSA0LjQuNCAyMDEwMDUwMyAoUmVkIEhhdCA0LjQuNC0yKQ0K -PiANCj4gDQo+IEEgc2ltaWxhciBidWcgd2FzIGZpeGVkIGJ5IGUwNzE0ZWM0ZjllZmU3Yjg2ODI4 -YjBkY2MwNzdmZDhmNWQ4ZTVlOTENCj4gYnV0DQo+IEkgZG9uJ3QgdGhpbmsgdGhlIHNhbWUgYXBw -cm9hY2ggY2FuIHdvcmsgaGVyZS4NCg0KDQpJIGRvbid0IGhhdmUgYW55IHNldHVwcyB3aXRoIGdj -YyA0LjQuNC4gV2hhdCBpcyBpdCBleHBlY3RpbmcgaGVyZT8gSXMNCml0IGV4cGVjdGluZyBhbiBl -eHRyYSBzZXQgb2YgYnJhY2VzIGR1ZSB0byB0aGUgYW5vbnltb3VzICJzdHJ1Y3QiPw0KDQotLSAN -ClRyb25kIE15a2xlYnVzdA0KTGludXggTkZTIGNsaWVudCBtYWludGFpbmVyLCBQcmltYXJ5RGF0 -YQ0KdHJvbmQubXlrbGVidXN0QHByaW1hcnlkYXRhLmNvbQ0K +On Sat, 2017-11-18 at 12:19 -0500, Boris Ostrovsky wrote: +> Commit fcd8843c406b46433857ae45e5e9d84b01a7d20b breaks on older +> compilers which cannot process initializers for anonymous structures: +> +> +const nfs4_stateid invalid_stateid = { +> + { +> + .seqid = cpu_to_be32(0xffffffffU), +> + .other = { 0 }, +> + }, +> + .type = NFS4_INVALID_STATEID_TYPE, +> +}; +> +> +> /home/build/linux-linus/fs/nfs/nfs4state.c:74: error: unknown field +> ‘seqid’ specified in initializer +> /home/build/linux-linus/fs/nfs/nfs4state.c:74: warning: missing +> braces +> around initializer +> /home/build/linux-linus/fs/nfs/nfs4state.c:74: warning: (near +> initialization for ‘invalid_stateid.<anonymous>.data’) +> /home/build/linux-linus/fs/nfs/nfs4state.c:74: warning: overflow in +> implicit constant conversion +> /home/build/linux-linus/fs/nfs/nfs4state.c:75: error: unknown field +> ‘other’ specified in initializer +> /home/build/linux-linus/fs/nfs/nfs4state.c:75: error: extra brace +> group +> at end of initializer +> /home/build/linux-linus/fs/nfs/nfs4state.c:75: error: (near +> initialization for ‘invalid_stateid.<anonymous>’) +> /home/build/linux-linus/fs/nfs/nfs4state.c:75: warning: excess +> elements +> in union initializer +> /home/build/linux-linus/fs/nfs/nfs4state.c:75: warning: (near +> initialization for ‘invalid_stateid.<anonymous>’) +> make[4]: *** [fs/nfs/nfs4state.o] Error 1 +> make[3]: *** [fs/nfs] Error 2 +> +> +> FC-64 <build@build-mk2:~> gcc --version +> gcc (GCC) 4.4.4 20100503 (Red Hat 4.4.4-2) +> +> +> A similar bug was fixed by e0714ec4f9efe7b86828b0dcc077fd8f5d8e5e91 +> but +> I don't think the same approach can work here. + + +I don't have any setups with gcc 4.4.4. What is it expecting here? Is +it expecting an extra set of braces due to the anonymous "struct"? + +-- +Trond Myklebust +Linux NFS client maintainer, PrimaryData +trond.myklebust@primarydata.com diff --git a/a/content_digest b/N1/content_digest index 7fba8f6..a60d395 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -8,40 +8,59 @@ " linux-nfs@vger.kernel.org <linux-nfs@vger.kernel.org>\0" "\00:1\0" "b\0" - "T24gU2F0LCAyMDE3LTExLTE4IGF0IDEyOjE5IC0wNTAwLCBCb3JpcyBPc3Ryb3Zza3kgd3JvdGU6\n" - "DQo+IENvbW1pdCBmY2Q4ODQzYzQwNmI0NjQzMzg1N2FlNDVlNWU5ZDg0YjAxYTdkMjBiIGJyZWFr\n" - "cyBvbiBvbGRlcg0KPiBjb21waWxlcnMgd2hpY2ggY2Fubm90IHByb2Nlc3MgaW5pdGlhbGl6ZXJz\n" - "IGZvciBhbm9ueW1vdXMgc3RydWN0dXJlczoNCj4gDQo+ICtjb25zdCBuZnM0X3N0YXRlaWQgaW52\n" - "YWxpZF9zdGF0ZWlkID0gew0KPiArICAgICAgIHsNCj4gKyAgICAgICAgICAgICAgIC5zZXFpZCA9\n" - "IGNwdV90b19iZTMyKDB4ZmZmZmZmZmZVKSwNCj4gKyAgICAgICAgICAgICAgIC5vdGhlciA9IHsg\n" - "MCB9LA0KPiArICAgICAgIH0sDQo+ICsgICAgICAgLnR5cGUgPSBORlM0X0lOVkFMSURfU1RBVEVJ\n" - "RF9UWVBFLA0KPiArfTsNCj4gDQo+IA0KPiAvaG9tZS9idWlsZC9saW51eC1saW51cy9mcy9uZnMv\n" - "bmZzNHN0YXRlLmM6NzQ6IGVycm9yOiB1bmtub3duIGZpZWxkDQo+IOKAmHNlcWlk4oCZIHNwZWNp\n" - "ZmllZCBpbiBpbml0aWFsaXplcg0KPiAvaG9tZS9idWlsZC9saW51eC1saW51cy9mcy9uZnMvbmZz\n" - "NHN0YXRlLmM6NzQ6IHdhcm5pbmc6IG1pc3NpbmcNCj4gYnJhY2VzDQo+IGFyb3VuZCBpbml0aWFs\n" - "aXplcg0KPiAvaG9tZS9idWlsZC9saW51eC1saW51cy9mcy9uZnMvbmZzNHN0YXRlLmM6NzQ6IHdh\n" - "cm5pbmc6IChuZWFyDQo+IGluaXRpYWxpemF0aW9uIGZvciDigJhpbnZhbGlkX3N0YXRlaWQuPGFu\n" - "b255bW91cz4uZGF0YeKAmSkNCj4gL2hvbWUvYnVpbGQvbGludXgtbGludXMvZnMvbmZzL25mczRz\n" - "dGF0ZS5jOjc0OiB3YXJuaW5nOiBvdmVyZmxvdyBpbg0KPiBpbXBsaWNpdCBjb25zdGFudCBjb252\n" - "ZXJzaW9uDQo+IC9ob21lL2J1aWxkL2xpbnV4LWxpbnVzL2ZzL25mcy9uZnM0c3RhdGUuYzo3NTog\n" - "ZXJyb3I6IHVua25vd24gZmllbGQNCj4g4oCYb3RoZXLigJkgc3BlY2lmaWVkIGluIGluaXRpYWxp\n" - "emVyDQo+IC9ob21lL2J1aWxkL2xpbnV4LWxpbnVzL2ZzL25mcy9uZnM0c3RhdGUuYzo3NTogZXJy\n" - "b3I6IGV4dHJhIGJyYWNlDQo+IGdyb3VwDQo+IGF0IGVuZCBvZiBpbml0aWFsaXplcg0KPiAvaG9t\n" - "ZS9idWlsZC9saW51eC1saW51cy9mcy9uZnMvbmZzNHN0YXRlLmM6NzU6IGVycm9yOiAobmVhcg0K\n" - "PiBpbml0aWFsaXphdGlvbiBmb3Ig4oCYaW52YWxpZF9zdGF0ZWlkLjxhbm9ueW1vdXM+4oCZKQ0K\n" - "PiAvaG9tZS9idWlsZC9saW51eC1saW51cy9mcy9uZnMvbmZzNHN0YXRlLmM6NzU6IHdhcm5pbmc6\n" - "IGV4Y2Vzcw0KPiBlbGVtZW50cw0KPiBpbiB1bmlvbiBpbml0aWFsaXplcg0KPiAvaG9tZS9idWls\n" - "ZC9saW51eC1saW51cy9mcy9uZnMvbmZzNHN0YXRlLmM6NzU6IHdhcm5pbmc6IChuZWFyDQo+IGlu\n" - "aXRpYWxpemF0aW9uIGZvciDigJhpbnZhbGlkX3N0YXRlaWQuPGFub255bW91cz7igJkpDQo+IG1h\n" - "a2VbNF06ICoqKiBbZnMvbmZzL25mczRzdGF0ZS5vXSBFcnJvciAxDQo+IG1ha2VbM106ICoqKiBb\n" - "ZnMvbmZzXSBFcnJvciAyDQo+IA0KPiANCj4gRkMtNjQgPGJ1aWxkQGJ1aWxkLW1rMjp+PiBnY2Mg\n" - "LS12ZXJzaW9uDQo+IGdjYyAoR0NDKSA0LjQuNCAyMDEwMDUwMyAoUmVkIEhhdCA0LjQuNC0yKQ0K\n" - "PiANCj4gDQo+IEEgc2ltaWxhciBidWcgd2FzIGZpeGVkIGJ5IGUwNzE0ZWM0ZjllZmU3Yjg2ODI4\n" - "YjBkY2MwNzdmZDhmNWQ4ZTVlOTENCj4gYnV0DQo+IEkgZG9uJ3QgdGhpbmsgdGhlIHNhbWUgYXBw\n" - "cm9hY2ggY2FuIHdvcmsgaGVyZS4NCg0KDQpJIGRvbid0IGhhdmUgYW55IHNldHVwcyB3aXRoIGdj\n" - "YyA0LjQuNC4gV2hhdCBpcyBpdCBleHBlY3RpbmcgaGVyZT8gSXMNCml0IGV4cGVjdGluZyBhbiBl\n" - "eHRyYSBzZXQgb2YgYnJhY2VzIGR1ZSB0byB0aGUgYW5vbnltb3VzICJzdHJ1Y3QiPw0KDQotLSAN\n" - "ClRyb25kIE15a2xlYnVzdA0KTGludXggTkZTIGNsaWVudCBtYWludGFpbmVyLCBQcmltYXJ5RGF0\n" - YQ0KdHJvbmQubXlrbGVidXN0QHByaW1hcnlkYXRhLmNvbQ0K + "On Sat, 2017-11-18 at 12:19 -0500, Boris Ostrovsky wrote:\n" + "> Commit fcd8843c406b46433857ae45e5e9d84b01a7d20b breaks on older\n" + "> compilers which cannot process initializers for anonymous structures:\n" + "> \n" + "> +const nfs4_stateid invalid_stateid = {\n" + "> + {\n" + "> + .seqid = cpu_to_be32(0xffffffffU),\n" + "> + .other = { 0 },\n" + "> + },\n" + "> + .type = NFS4_INVALID_STATEID_TYPE,\n" + "> +};\n" + "> \n" + "> \n" + "> /home/build/linux-linus/fs/nfs/nfs4state.c:74: error: unknown field\n" + "> \342\200\230seqid\342\200\231 specified in initializer\n" + "> /home/build/linux-linus/fs/nfs/nfs4state.c:74: warning: missing\n" + "> braces\n" + "> around initializer\n" + "> /home/build/linux-linus/fs/nfs/nfs4state.c:74: warning: (near\n" + "> initialization for \342\200\230invalid_stateid.<anonymous>.data\342\200\231)\n" + "> /home/build/linux-linus/fs/nfs/nfs4state.c:74: warning: overflow in\n" + "> implicit constant conversion\n" + "> /home/build/linux-linus/fs/nfs/nfs4state.c:75: error: unknown field\n" + "> \342\200\230other\342\200\231 specified in initializer\n" + "> /home/build/linux-linus/fs/nfs/nfs4state.c:75: error: extra brace\n" + "> group\n" + "> at end of initializer\n" + "> /home/build/linux-linus/fs/nfs/nfs4state.c:75: error: (near\n" + "> initialization for \342\200\230invalid_stateid.<anonymous>\342\200\231)\n" + "> /home/build/linux-linus/fs/nfs/nfs4state.c:75: warning: excess\n" + "> elements\n" + "> in union initializer\n" + "> /home/build/linux-linus/fs/nfs/nfs4state.c:75: warning: (near\n" + "> initialization for \342\200\230invalid_stateid.<anonymous>\342\200\231)\n" + "> make[4]: *** [fs/nfs/nfs4state.o] Error 1\n" + "> make[3]: *** [fs/nfs] Error 2\n" + "> \n" + "> \n" + "> FC-64 <build@build-mk2:~> gcc --version\n" + "> gcc (GCC) 4.4.4 20100503 (Red Hat 4.4.4-2)\n" + "> \n" + "> \n" + "> A similar bug was fixed by e0714ec4f9efe7b86828b0dcc077fd8f5d8e5e91\n" + "> but\n" + "> I don't think the same approach can work here.\n" + "\n" + "\n" + "I don't have any setups with gcc 4.4.4. What is it expecting here? Is\n" + "it expecting an extra set of braces due to the anonymous \"struct\"?\n" + "\n" + "-- \n" + "Trond Myklebust\n" + "Linux NFS client maintainer, PrimaryData\n" + trond.myklebust@primarydata.com -655390f98de880a1f4642b0ff2fd7cbb288e535221e91603343a642659c061f8 +a461132f833f074f3fd9a3319f9153d29533075fd094eccdf0fbf148169e62ca
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.