From: Trond Myklebust <trondmy@primarydata.com>
To: "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
"Anna.Schumaker@Netapp.com" <Anna.Schumaker@Netapp.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: Commit fcd8843c40 breaks old compilers
Date: Sat, 18 Nov 2017 17:39:45 +0000 [thread overview]
Message-ID: <1511026783.10238.2.camel@primarydata.com> (raw)
In-Reply-To: <09a3d9ca-d191-5899-613d-8d0dbe0b68ea@oracle.com>
T24gU2F0LCAyMDE3LTExLTE4IGF0IDEyOjE5IC0wNTAwLCBCb3JpcyBPc3Ryb3Zza3kgd3JvdGU6
DQo+IENvbW1pdCBmY2Q4ODQzYzQwNmI0NjQzMzg1N2FlNDVlNWU5ZDg0YjAxYTdkMjBiIGJyZWFr
cyBvbiBvbGRlcg0KPiBjb21waWxlcnMgd2hpY2ggY2Fubm90IHByb2Nlc3MgaW5pdGlhbGl6ZXJz
IGZvciBhbm9ueW1vdXMgc3RydWN0dXJlczoNCj4gDQo+ICtjb25zdCBuZnM0X3N0YXRlaWQgaW52
YWxpZF9zdGF0ZWlkID0gew0KPiArICAgICAgIHsNCj4gKyAgICAgICAgICAgICAgIC5zZXFpZCA9
IGNwdV90b19iZTMyKDB4ZmZmZmZmZmZVKSwNCj4gKyAgICAgICAgICAgICAgIC5vdGhlciA9IHsg
MCB9LA0KPiArICAgICAgIH0sDQo+ICsgICAgICAgLnR5cGUgPSBORlM0X0lOVkFMSURfU1RBVEVJ
RF9UWVBFLA0KPiArfTsNCj4gDQo+IA0KPiAvaG9tZS9idWlsZC9saW51eC1saW51cy9mcy9uZnMv
bmZzNHN0YXRlLmM6NzQ6IGVycm9yOiB1bmtub3duIGZpZWxkDQo+IOKAmHNlcWlk4oCZIHNwZWNp
ZmllZCBpbiBpbml0aWFsaXplcg0KPiAvaG9tZS9idWlsZC9saW51eC1saW51cy9mcy9uZnMvbmZz
NHN0YXRlLmM6NzQ6IHdhcm5pbmc6IG1pc3NpbmcNCj4gYnJhY2VzDQo+IGFyb3VuZCBpbml0aWFs
aXplcg0KPiAvaG9tZS9idWlsZC9saW51eC1saW51cy9mcy9uZnMvbmZzNHN0YXRlLmM6NzQ6IHdh
cm5pbmc6IChuZWFyDQo+IGluaXRpYWxpemF0aW9uIGZvciDigJhpbnZhbGlkX3N0YXRlaWQuPGFu
b255bW91cz4uZGF0YeKAmSkNCj4gL2hvbWUvYnVpbGQvbGludXgtbGludXMvZnMvbmZzL25mczRz
dGF0ZS5jOjc0OiB3YXJuaW5nOiBvdmVyZmxvdyBpbg0KPiBpbXBsaWNpdCBjb25zdGFudCBjb252
ZXJzaW9uDQo+IC9ob21lL2J1aWxkL2xpbnV4LWxpbnVzL2ZzL25mcy9uZnM0c3RhdGUuYzo3NTog
ZXJyb3I6IHVua25vd24gZmllbGQNCj4g4oCYb3RoZXLigJkgc3BlY2lmaWVkIGluIGluaXRpYWxp
emVyDQo+IC9ob21lL2J1aWxkL2xpbnV4LWxpbnVzL2ZzL25mcy9uZnM0c3RhdGUuYzo3NTogZXJy
b3I6IGV4dHJhIGJyYWNlDQo+IGdyb3VwDQo+IGF0IGVuZCBvZiBpbml0aWFsaXplcg0KPiAvaG9t
ZS9idWlsZC9saW51eC1saW51cy9mcy9uZnMvbmZzNHN0YXRlLmM6NzU6IGVycm9yOiAobmVhcg0K
PiBpbml0aWFsaXphdGlvbiBmb3Ig4oCYaW52YWxpZF9zdGF0ZWlkLjxhbm9ueW1vdXM+4oCZKQ0K
PiAvaG9tZS9idWlsZC9saW51eC1saW51cy9mcy9uZnMvbmZzNHN0YXRlLmM6NzU6IHdhcm5pbmc6
IGV4Y2Vzcw0KPiBlbGVtZW50cw0KPiBpbiB1bmlvbiBpbml0aWFsaXplcg0KPiAvaG9tZS9idWls
ZC9saW51eC1saW51cy9mcy9uZnMvbmZzNHN0YXRlLmM6NzU6IHdhcm5pbmc6IChuZWFyDQo+IGlu
aXRpYWxpemF0aW9uIGZvciDigJhpbnZhbGlkX3N0YXRlaWQuPGFub255bW91cz7igJkpDQo+IG1h
a2VbNF06ICoqKiBbZnMvbmZzL25mczRzdGF0ZS5vXSBFcnJvciAxDQo+IG1ha2VbM106ICoqKiBb
ZnMvbmZzXSBFcnJvciAyDQo+IA0KPiANCj4gRkMtNjQgPGJ1aWxkQGJ1aWxkLW1rMjp+PiBnY2Mg
LS12ZXJzaW9uDQo+IGdjYyAoR0NDKSA0LjQuNCAyMDEwMDUwMyAoUmVkIEhhdCA0LjQuNC0yKQ0K
PiANCj4gDQo+IEEgc2ltaWxhciBidWcgd2FzIGZpeGVkIGJ5IGUwNzE0ZWM0ZjllZmU3Yjg2ODI4
YjBkY2MwNzdmZDhmNWQ4ZTVlOTENCj4gYnV0DQo+IEkgZG9uJ3QgdGhpbmsgdGhlIHNhbWUgYXBw
cm9hY2ggY2FuIHdvcmsgaGVyZS4NCg0KDQpJIGRvbid0IGhhdmUgYW55IHNldHVwcyB3aXRoIGdj
YyA0LjQuNC4gV2hhdCBpcyBpdCBleHBlY3RpbmcgaGVyZT8gSXMNCml0IGV4cGVjdGluZyBhbiBl
eHRyYSBzZXQgb2YgYnJhY2VzIGR1ZSB0byB0aGUgYW5vbnltb3VzICJzdHJ1Y3QiPw0KDQotLSAN
ClRyb25kIE15a2xlYnVzdA0KTGludXggTkZTIGNsaWVudCBtYWludGFpbmVyLCBQcmltYXJ5RGF0
YQ0KdHJvbmQubXlrbGVidXN0QHByaW1hcnlkYXRhLmNvbQ0K
WARNING: multiple messages have this Message-ID (diff)
From: Trond Myklebust <trondmy@primarydata.com>
To: "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
"Anna.Schumaker@Netapp.com" <Anna.Schumaker@Netapp.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: Commit fcd8843c40 breaks old compilers
Date: Sat, 18 Nov 2017 17:39:45 +0000 [thread overview]
Message-ID: <1511026783.10238.2.camel@primarydata.com> (raw)
In-Reply-To: <09a3d9ca-d191-5899-613d-8d0dbe0b68ea@oracle.com>
On Sat, 2017-11-18 at 12:19 -0500, Boris Ostrovsky wrote:
> Commit fcd8843c406b46433857ae45e5e9d84b01a7d20b breaks on older
> compilers which cannot process initializers for anonymous structures:
>
> +const nfs4_stateid invalid_stateid = {
> + {
> + .seqid = cpu_to_be32(0xffffffffU),
> + .other = { 0 },
> + },
> + .type = NFS4_INVALID_STATEID_TYPE,
> +};
>
>
> /home/build/linux-linus/fs/nfs/nfs4state.c:74: error: unknown field
> ‘seqid’ specified in initializer
> /home/build/linux-linus/fs/nfs/nfs4state.c:74: warning: missing
> braces
> around initializer
> /home/build/linux-linus/fs/nfs/nfs4state.c:74: warning: (near
> initialization for ‘invalid_stateid.<anonymous>.data’)
> /home/build/linux-linus/fs/nfs/nfs4state.c:74: warning: overflow in
> implicit constant conversion
> /home/build/linux-linus/fs/nfs/nfs4state.c:75: error: unknown field
> ‘other’ specified in initializer
> /home/build/linux-linus/fs/nfs/nfs4state.c:75: error: extra brace
> group
> at end of initializer
> /home/build/linux-linus/fs/nfs/nfs4state.c:75: error: (near
> initialization for ‘invalid_stateid.<anonymous>’)
> /home/build/linux-linus/fs/nfs/nfs4state.c:75: warning: excess
> elements
> in union initializer
> /home/build/linux-linus/fs/nfs/nfs4state.c:75: warning: (near
> initialization for ‘invalid_stateid.<anonymous>’)
> make[4]: *** [fs/nfs/nfs4state.o] Error 1
> make[3]: *** [fs/nfs] Error 2
>
>
> FC-64 <build@build-mk2:~> gcc --version
> gcc (GCC) 4.4.4 20100503 (Red Hat 4.4.4-2)
>
>
> A similar bug was fixed by e0714ec4f9efe7b86828b0dcc077fd8f5d8e5e91
> but
> I don't think the same approach can work here.
I don't have any setups with gcc 4.4.4. What is it expecting here? Is
it expecting an extra set of braces due to the anonymous "struct"?
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
next prev parent reply other threads:[~2017-11-18 17:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-18 17:19 Commit fcd8843c40 breaks old compilers Boris Ostrovsky
2017-11-18 17:39 ` Trond Myklebust [this message]
2017-11-18 17:39 ` Trond Myklebust
2017-11-18 18:07 ` Boris Ostrovsky
2017-11-18 18:12 ` Trond Myklebust
2017-11-18 18:12 ` Trond Myklebust
2017-11-18 18:32 ` Boris Ostrovsky
2017-11-18 18:50 ` [PATCH] NFSv4: Ensure gcc 4.4.4 can compile initialiser for "invalid_stateid" Trond Myklebust
2017-11-18 19:26 ` Boris Ostrovsky
2017-11-19 10:58 ` Geert Uytterhoeven
2017-11-20 12:52 ` Commit fcd8843c40 breaks old compilers Arnd Bergmann
2017-11-20 14:11 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511026783.10238.2.camel@primarydata.com \
--to=trondmy@primarydata.com \
--cc=Anna.Schumaker@Netapp.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.