All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Vasyl Gomonovych <gomonovych@gmail.com>,
	ck.hu@mediatek.com, airlied@linux.ie, matthias.bgg@gmail.com,
	dri-devel@lists.freedesktop.org
Cc: linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/mediatek: Use ERR_CAST instead of ERR_PTR(PTR_ERR())
Date: Thu, 23 Nov 2017 10:31:44 +0100	[thread overview]
Message-ID: <1511429504.7685.12.camel@pengutronix.de> (raw)
In-Reply-To: <1511303493-14897-1-git-send-email-gomonovych@gmail.com>

On Tue, 2017-11-21 at 23:31 +0100, Vasyl Gomonovych wrote:
> Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)).
> 
> drivers/gpu/drm/mediatek/mtk_drm_gem.c:223:9-16: WARNING: ERR_CAST can be used with mtk_gem
> Generated by: scripts/coccinelle/api/err_cast.cocci
> 
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> index f595ac816b55..5766b42fc174 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> @@ -220,7 +220,7 @@ struct drm_gem_object *mtk_gem_prime_import_sg_table(struct drm_device *dev,
>  	mtk_gem = mtk_drm_gem_init(dev, attach->dmabuf->size);
>  
>  	if (IS_ERR(mtk_gem))
> -		return ERR_PTR(PTR_ERR(mtk_gem));
> +		return ERR_CAST(mtk_gem));
>  
>  	expected = sg_dma_address(sg->sgl);
>  	for_each_sg(sg->sgl, s, sg->nents, i) {

Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: p.zabel@pengutronix.de (Philipp Zabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/mediatek: Use ERR_CAST instead of ERR_PTR(PTR_ERR())
Date: Thu, 23 Nov 2017 10:31:44 +0100	[thread overview]
Message-ID: <1511429504.7685.12.camel@pengutronix.de> (raw)
In-Reply-To: <1511303493-14897-1-git-send-email-gomonovych@gmail.com>

On Tue, 2017-11-21 at 23:31 +0100, Vasyl Gomonovych wrote:
> Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)).
> 
> drivers/gpu/drm/mediatek/mtk_drm_gem.c:223:9-16: WARNING: ERR_CAST can be used with mtk_gem
> Generated by: scripts/coccinelle/api/err_cast.cocci
> 
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> index f595ac816b55..5766b42fc174 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> @@ -220,7 +220,7 @@ struct drm_gem_object *mtk_gem_prime_import_sg_table(struct drm_device *dev,
>  	mtk_gem = mtk_drm_gem_init(dev, attach->dmabuf->size);
>  
>  	if (IS_ERR(mtk_gem))
> -		return ERR_PTR(PTR_ERR(mtk_gem));
> +		return ERR_CAST(mtk_gem));
>  
>  	expected = sg_dma_address(sg->sgl);
>  	for_each_sg(sg->sgl, s, sg->nents, i) {

Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp

WARNING: multiple messages have this Message-ID (diff)
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Vasyl Gomonovych <gomonovych@gmail.com>,
	ck.hu@mediatek.com, airlied@linux.ie, matthias.bgg@gmail.com,
	dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/mediatek: Use ERR_CAST instead of ERR_PTR(PTR_ERR())
Date: Thu, 23 Nov 2017 10:31:44 +0100	[thread overview]
Message-ID: <1511429504.7685.12.camel@pengutronix.de> (raw)
In-Reply-To: <1511303493-14897-1-git-send-email-gomonovych@gmail.com>

On Tue, 2017-11-21 at 23:31 +0100, Vasyl Gomonovych wrote:
> Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)).
> 
> drivers/gpu/drm/mediatek/mtk_drm_gem.c:223:9-16: WARNING: ERR_CAST can be used with mtk_gem
> Generated by: scripts/coccinelle/api/err_cast.cocci
> 
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> index f595ac816b55..5766b42fc174 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> @@ -220,7 +220,7 @@ struct drm_gem_object *mtk_gem_prime_import_sg_table(struct drm_device *dev,
>  	mtk_gem = mtk_drm_gem_init(dev, attach->dmabuf->size);
>  
>  	if (IS_ERR(mtk_gem))
> -		return ERR_PTR(PTR_ERR(mtk_gem));
> +		return ERR_CAST(mtk_gem));
>  
>  	expected = sg_dma_address(sg->sgl);
>  	for_each_sg(sg->sgl, s, sg->nents, i) {

Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp

  reply	other threads:[~2017-11-23  9:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-21 22:31 [PATCH] drm/mediatek: Use ERR_CAST instead of ERR_PTR(PTR_ERR()) Vasyl Gomonovych
2017-11-21 22:31 ` Vasyl Gomonovych
2017-11-23  9:31 ` Philipp Zabel [this message]
2017-11-23  9:31   ` Philipp Zabel
2017-11-23  9:31   ` Philipp Zabel
     [not found]   ` <1511429504.7685.12.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2018-04-25  5:48     ` CK Hu
2018-04-25  5:48       ` CK Hu
2018-04-25  5:48       ` CK Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1511429504.7685.12.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=airlied@linux.ie \
    --cc=ck.hu@mediatek.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gomonovych@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.