From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
linux-bluetooth@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH v1] Bluetooth: introduce DEFINE_SHOW_ATTRIBUTE() macro
Date: Thu, 23 Nov 2017 15:18:10 +0200 [thread overview]
Message-ID: <1511443090.25007.418.camel@linux.intel.com> (raw)
In-Reply-To: <2404941a-6e4a-3665-f737-00b48819d204@infradead.org>
On Wed, 2017-11-22 at 14:13 -0800, Randy Dunlap wrote:
> On 11/22/2017 02:04 PM, Randy Dunlap wrote:
> > On 11/22/2017 01:15 PM, Andy Shevchenko wrote:
> > > This macro deduplicates a lot of similar code across the
> > > hci_debugfs.c
> > > module. Targeting to be moved to seq_file.h eventually
> > > +DEFINE_SHOW_ATTRIBUTE(__name)
> >
> > eh?
>
> OK, it's a continuation of the macro above it.
> Sorry about that.
NP.
It's just for better looking patch, I can move code around of course,
but as I stated in commit message I would like eventually to move it to
seq_file.h for everyone to use (there are basically a lot of users
already).
> > > +> +#define DEFINE_SHOW_ATTRIBUTE(__name)
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>,
Johan Hedberg
<johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v1] Bluetooth: introduce DEFINE_SHOW_ATTRIBUTE() macro
Date: Thu, 23 Nov 2017 15:18:10 +0200 [thread overview]
Message-ID: <1511443090.25007.418.camel@linux.intel.com> (raw)
In-Reply-To: <2404941a-6e4a-3665-f737-00b48819d204-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
On Wed, 2017-11-22 at 14:13 -0800, Randy Dunlap wrote:
> On 11/22/2017 02:04 PM, Randy Dunlap wrote:
> > On 11/22/2017 01:15 PM, Andy Shevchenko wrote:
> > > This macro deduplicates a lot of similar code across the
> > > hci_debugfs.c
> > > module. Targeting to be moved to seq_file.h eventually
> > > +DEFINE_SHOW_ATTRIBUTE(__name)
> >
> > eh?
>
> OK, it's a continuation of the macro above it.
> Sorry about that.
NP.
It's just for better looking patch, I can move code around of course,
but as I stated in commit message I would like eventually to move it to
seq_file.h for everyone to use (there are basically a lot of users
already).
> > > +> +#define DEFINE_SHOW_ATTRIBUTE(__name)
--
Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Intel Finland Oy
next prev parent reply other threads:[~2017-11-23 13:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 21:15 [PATCH v1] Bluetooth: introduce DEFINE_SHOW_ATTRIBUTE() macro Andy Shevchenko
2017-11-22 21:15 ` Andy Shevchenko
2017-11-22 22:04 ` Randy Dunlap
2017-11-22 22:13 ` Randy Dunlap
2017-11-23 13:18 ` Andy Shevchenko [this message]
2017-11-23 13:18 ` Andy Shevchenko
2017-12-13 19:21 ` Marcel Holtmann
2017-12-13 19:21 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511443090.25007.418.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.