From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Mackerras <paulus@ozlabs.org>
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH v2 11/11] powerpc/kvm: Use the PACA virt/real mode info instead of mfmsr
Date: Sun, 26 Nov 2017 21:58:07 +0000 [thread overview]
Message-ID: <1511733487.2466.66.camel@kernel.crashing.org> (raw)
In-Reply-To: <20171125051709.GC10920@fergus.ozlabs.ibm.com>
On Sat, 2017-11-25 at 16:17 +1100, Paul Mackerras wrote:
> On Thu, Nov 23, 2017 at 03:36:19PM +1100, Benjamin Herrenschmidt wrote:
> > This shaves off a bunch of cycles from the KVM exit path
> > and the XIVE related hypercall.
>
> Comment below...
>
> > diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> > index 83862fba8cfb..ade13f7a9077 100644
> > --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> > +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> > @@ -81,6 +81,8 @@ _GLOBAL_TOC(kvmppc_hv_entry_trampoline)
> > RFI
> >
> > kvmppc_call_hv_entry:
> > + li r0,0
> > + stb r0,HSTATE_EXIT_VIRT(r13)
>
> Don't we need to clear HSTATE_EXIT_VIRT(r13) similarly in the entry
> path for offline secondary CPU threads, i.e. somewhere around the
> kvm_secondary_got_guest label?
Quite possibly, I am not too familiar with that path. I'll have a look.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Mackerras <paulus@ozlabs.org>
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH v2 11/11] powerpc/kvm: Use the PACA virt/real mode info instead of mfmsr
Date: Mon, 27 Nov 2017 08:58:07 +1100 [thread overview]
Message-ID: <1511733487.2466.66.camel@kernel.crashing.org> (raw)
In-Reply-To: <20171125051709.GC10920@fergus.ozlabs.ibm.com>
On Sat, 2017-11-25 at 16:17 +1100, Paul Mackerras wrote:
> On Thu, Nov 23, 2017 at 03:36:19PM +1100, Benjamin Herrenschmidt wrote:
> > This shaves off a bunch of cycles from the KVM exit path
> > and the XIVE related hypercall.
>
> Comment below...
>
> > diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> > index 83862fba8cfb..ade13f7a9077 100644
> > --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> > +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> > @@ -81,6 +81,8 @@ _GLOBAL_TOC(kvmppc_hv_entry_trampoline)
> > RFI
> >
> > kvmppc_call_hv_entry:
> > + li r0,0
> > + stb r0,HSTATE_EXIT_VIRT(r13)
>
> Don't we need to clear HSTATE_EXIT_VIRT(r13) similarly in the entry
> path for offline secondary CPU threads, i.e. somewhere around the
> kvm_secondary_got_guest label?
Quite possibly, I am not too familiar with that path. I'll have a look.
Cheers,
Ben.
next prev parent reply other threads:[~2017-11-26 21:58 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 4:36 [PATCH v2 01/11] powerpc/kvm/xive: Add more debugfs queues info Benjamin Herrenschmidt
2017-11-23 4:36 ` Benjamin Herrenschmidt
2017-11-23 4:36 ` [PATCH v2 02/11] powerpc/kvm/xive: Enable use of the new "single escalation" feature Benjamin Herrenschmidt
2017-11-23 4:36 ` Benjamin Herrenschmidt
2017-11-23 4:36 ` [PATCH v2 03/11] powerpc/kvm/xive: Don't use existing "prodded" flag for xive escalations Benjamin Herrenschmidt
2017-11-23 4:36 ` Benjamin Herrenschmidt
2017-11-23 4:36 ` [PATCH v2 04/11] powerpc/kvm/xive: Check DR not IR to chose real vs virt mode MMIOs Benjamin Herrenschmidt
2017-11-23 4:36 ` Benjamin Herrenschmidt
2017-11-23 4:36 ` [PATCH v2 05/11] powerpc/kvm/xive: Make xive_pushed a byte, not a word Benjamin Herrenschmidt
2017-11-23 4:36 ` Benjamin Herrenschmidt
2017-11-23 4:36 ` [PATCH v2 06/11] powerpc/xive: Move definition of ESB bits Benjamin Herrenschmidt
2017-11-23 4:36 ` Benjamin Herrenschmidt
2017-11-23 4:36 ` [PATCH v2 07/11] powerpc/xive: Add interrupt flag to disable automatic EOI Benjamin Herrenschmidt
2017-11-23 4:36 ` Benjamin Herrenschmidt
2017-11-23 4:36 ` [PATCH v2 08/11] powerpc/kvm/xive: Keep escalation interrupt masked unless ceded Benjamin Herrenschmidt
2017-11-23 4:36 ` Benjamin Herrenschmidt
2017-11-25 4:56 ` Paul Mackerras
2017-11-25 4:56 ` Paul Mackerras
2017-11-26 21:55 ` Benjamin Herrenschmidt
2017-11-26 21:55 ` Benjamin Herrenschmidt
2017-11-23 4:36 ` [PATCH v2 09/11] powerpc/kvm: Make "no_xive:" label local Benjamin Herrenschmidt
2017-11-23 4:36 ` Benjamin Herrenschmidt
2017-11-23 4:36 ` [PATCH v2 10/11] powerpc/kvm: Store the MMU mode in the PACA on KVM exit Benjamin Herrenschmidt
2017-11-23 4:36 ` Benjamin Herrenschmidt
2017-11-24 15:15 ` kbuild test robot
2017-11-24 15:15 ` kbuild test robot
2017-11-25 5:03 ` Paul Mackerras
2017-11-25 5:03 ` Paul Mackerras
2017-11-26 21:57 ` Benjamin Herrenschmidt
2017-11-26 21:57 ` Benjamin Herrenschmidt
2017-11-23 4:36 ` [PATCH v2 11/11] powerpc/kvm: Use the PACA virt/real mode info instead of mfmsr Benjamin Herrenschmidt
2017-11-23 4:36 ` Benjamin Herrenschmidt
2017-11-25 5:17 ` Paul Mackerras
2017-11-25 5:17 ` Paul Mackerras
2017-11-26 21:58 ` Benjamin Herrenschmidt [this message]
2017-11-26 21:58 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511733487.2466.66.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.